diff options
author | erg@chromium.org <erg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-15 21:03:54 +0000 |
---|---|---|
committer | erg@chromium.org <erg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-15 21:03:54 +0000 |
commit | 3a3d4747769aec2954a2ca21de4812c5892994aa (patch) | |
tree | db112f2c73cc39e9d6088059eae1fc9d35b74920 /net/url_request/url_request_job.cc | |
parent | 2235b22b88260fde392b753b5d7bb7904e5efbc6 (diff) | |
download | chromium_src-3a3d4747769aec2954a2ca21de4812c5892994aa.zip chromium_src-3a3d4747769aec2954a2ca21de4812c5892994aa.tar.gz chromium_src-3a3d4747769aec2954a2ca21de4812c5892994aa.tar.bz2 |
Move implementation from header to source.
This is an effort to speed up compile and link time, and also minimizing the
size of the intermediary .o files on disk. For example, just moving the
constructor/destructor from the classes in chrome/browser/pref_member.{cc,h}
netted a 368k drop in total .o file size. In aggregate, this shrinks
libbrowser.a by 10 megabytes, and a few odd megabytes on most other chrome .a files.
A lot of this was done before I started harvesting what the most included
symbols were across all of chrome's code. Most of them are in webkit, but
there's plenty in base/ that are used everywhere to keep me busy for several
patches to come.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3012001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52528 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/url_request/url_request_job.cc')
-rw-r--r-- | net/url_request/url_request_job.cc | 67 |
1 files changed, 63 insertions, 4 deletions
diff --git a/net/url_request/url_request_job.cc b/net/url_request/url_request_job.cc index 4e737ba..7ce60c3 100644 --- a/net/url_request/url_request_job.cc +++ b/net/url_request/url_request_job.cc @@ -54,6 +54,13 @@ URLRequestJob::~URLRequestJob() { g_url_request_job_tracker.RemoveJob(this); } +void URLRequestJob::SetUpload(net::UploadData* upload) { +} + +void URLRequestJob::SetExtraRequestHeaders( + const net::HttpRequestHeaders& headers) { +} + void URLRequestJob::Kill() { // Make sure the request is notified that we are done. We assume that the // request took care of setting its error status before calling Kill. @@ -65,10 +72,6 @@ void URLRequestJob::DetachRequest() { request_ = NULL; } -bool URLRequestJob::IsDownload() const { - return (load_flags_ & net::LOAD_IS_DOWNLOAD) != 0; -} - void URLRequestJob::SetupFilter() { std::vector<Filter::FilterType> encoding_types; if (GetContentEncodings(&encoding_types)) { @@ -92,6 +95,14 @@ bool URLRequestJob::IsRedirectResponse(GURL* location, return true; } +bool URLRequestJob::IsSafeRedirect(const GURL& location) { + return true; +} + +bool URLRequestJob::NeedsAuth() { + return false; +} + void URLRequestJob::GetAuthChallengeInfo( scoped_refptr<net::AuthChallengeInfo>* auth_info) { // This will only be called if NeedsAuth() returns true, in which @@ -148,6 +159,10 @@ int64 URLRequestJob::GetByteReadCount() const { return filter_input_byte_count_; } +bool URLRequestJob::GetMimeType(std::string* mime_type) const { + return false; +} + bool URLRequestJob::GetURL(GURL* gurl) const { if (!request_) return false; @@ -161,6 +176,18 @@ base::Time URLRequestJob::GetRequestTime() const { return request_->request_time(); }; +bool URLRequestJob::IsCachedContent() const { + return false; +} + +int URLRequestJob::GetResponseCode() const { + return -1; +} + +int URLRequestJob::GetInputStreamBufferSize() const { + return kFilterBufSize; +} + // This function calls ReadData to get stream data. If a filter exists, passes // the data to the attached filter. Then returns the output from filter back to // the caller. @@ -199,6 +226,38 @@ void URLRequestJob::StopCaching() { // Nothing to do here. } +net::LoadState URLRequestJob::GetLoadState() const { + return net::LOAD_STATE_IDLE; +} + +uint64 URLRequestJob::GetUploadProgress() const { + return 0; +} + +bool URLRequestJob::GetCharset(std::string* charset) { + return false; +} + +void URLRequestJob::GetResponseInfo(net::HttpResponseInfo* info) { +} + +bool URLRequestJob::GetResponseCookies(std::vector<std::string>* cookies) { + return false; +} + +bool URLRequestJob::GetContentEncodings( + std::vector<Filter::FilterType>* encoding_types) { + return false; +} + +bool URLRequestJob::IsDownload() const { + return (load_flags_ & net::LOAD_IS_DOWNLOAD) != 0; +} + +bool URLRequestJob::IsSdchResponse() const { + return false; +} + bool URLRequestJob::ReadRawDataForFilter(int* bytes_read) { bool rv = false; |