diff options
| author | battre@chromium.org <battre@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-13 09:01:28 +0000 |
|---|---|---|
| committer | battre@chromium.org <battre@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-13 09:01:28 +0000 |
| commit | 34b6db5e3093d11b88a925001a0230f81bf844f9 (patch) | |
| tree | 8c1891417e7a5178b36ed367141737a307c647a2 /net/url_request/url_request_test_util.h | |
| parent | 462232c4cf79e1b51d9a2f721c26f812172ad640 (diff) | |
| download | chromium_src-34b6db5e3093d11b88a925001a0230f81bf844f9.zip chromium_src-34b6db5e3093d11b88a925001a0230f81bf844f9.tar.gz chromium_src-34b6db5e3093d11b88a925001a0230f81bf844f9.tar.bz2 | |
Revert 92331 - Fix leaking request IDs in webRequest API
The current webRequest API did not guarantee that either onCompleted or onErrorOccurred is called for each request. If an extension fills a REQUEST_ID -> URL hashmap for all requests at the onBeforeRequest event, and tried to delete the entries on onCompleted and onErrorOccurred, some entries remained in the hashmap.
BUG=86139
TEST=execute example extension attached to bug
Review URL: http://codereview.chromium.org/7190007
TBR=battre@chromium.org
Review URL: http://codereview.chromium.org/7351011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92339 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/url_request/url_request_test_util.h')
| -rw-r--r-- | net/url_request/url_request_test_util.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/net/url_request/url_request_test_util.h b/net/url_request/url_request_test_util.h index 74d8fab..f7755b8 100644 --- a/net/url_request/url_request_test_util.h +++ b/net/url_request/url_request_test_util.h @@ -179,7 +179,6 @@ class TestNetworkDelegate : public net::NetworkDelegate { int error_count() const { return error_count_; } int created_requests() const { return created_requests_; } int destroyed_requests() const { return destroyed_requests_; } - int completed_requests() const { return completed_requests_; } protected: // net::NetworkDelegate: @@ -207,7 +206,6 @@ class TestNetworkDelegate : public net::NetworkDelegate { int error_count_; int created_requests_; int destroyed_requests_; - int completed_requests_; }; #endif // NET_URL_REQUEST_URL_REQUEST_TEST_UTIL_H_ |