diff options
| author | battre@chromium.org <battre@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-13 10:41:01 +0000 |
|---|---|---|
| committer | battre@chromium.org <battre@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-13 10:41:01 +0000 |
| commit | a83dd330dfcc8914c2f1a348d619f0c39b8da50e (patch) | |
| tree | 8b292fe9f4a8293ce9faad34ccff25a2dabd9336 /net/url_request/url_request_test_util.h | |
| parent | b5523b350fa5eee2eaf1aa4fb9bc63f14815539a (diff) | |
| download | chromium_src-a83dd330dfcc8914c2f1a348d619f0c39b8da50e.zip chromium_src-a83dd330dfcc8914c2f1a348d619f0c39b8da50e.tar.gz chromium_src-a83dd330dfcc8914c2f1a348d619f0c39b8da50e.tar.bz2 | |
Fix leaking request IDs in webRequest API
The current webRequest API did not guarantee that either onCompleted or onErrorOccurred is called for each request. If an extension fills a REQUEST_ID -> URL hashmap for all requests at the onBeforeRequest event, and tried to delete the entries on onCompleted and onErrorOccurred, some entries remained in the hashmap.
BUG=86139
TEST=execute example extension attached to bug
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92331
Review URL: http://codereview.chromium.org/7190007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92349 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/url_request/url_request_test_util.h')
| -rw-r--r-- | net/url_request/url_request_test_util.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/net/url_request/url_request_test_util.h b/net/url_request/url_request_test_util.h index f7755b8..74d8fab 100644 --- a/net/url_request/url_request_test_util.h +++ b/net/url_request/url_request_test_util.h @@ -179,6 +179,7 @@ class TestNetworkDelegate : public net::NetworkDelegate { int error_count() const { return error_count_; } int created_requests() const { return created_requests_; } int destroyed_requests() const { return destroyed_requests_; } + int completed_requests() const { return completed_requests_; } protected: // net::NetworkDelegate: @@ -206,6 +207,7 @@ class TestNetworkDelegate : public net::NetworkDelegate { int error_count_; int created_requests_; int destroyed_requests_; + int completed_requests_; }; #endif // NET_URL_REQUEST_URL_REQUEST_TEST_UTIL_H_ |