summaryrefslogtreecommitdiffstats
path: root/net/url_request/url_request_throttler_entry.h
diff options
context:
space:
mode:
authorjoi@chromium.org <joi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-06-07 13:21:15 +0000
committerjoi@chromium.org <joi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-06-07 13:21:15 +0000
commita1d4ab0736c3706165d284fa76c95d67f6ab3bf9 (patch)
treea2e9d0d10c021aee60ab59d2619750546785654b /net/url_request/url_request_throttler_entry.h
parent54acdbf5115fb8ff7484a822ee98af1615977da0 (diff)
downloadchromium_src-a1d4ab0736c3706165d284fa76c95d67f6ab3bf9.zip
chromium_src-a1d4ab0736c3706165d284fa76c95d67f6ab3bf9.tar.gz
chromium_src-a1d4ab0736c3706165d284fa76c95d67f6ab3bf9.tar.bz2
Introduce a delegate to avoid hardcoding "chrome-extension" in net/.
Also, deal with a couple of TODOs in the throttling code, and remove metrics we no longer need since we are no longer running field trials for this code. BUG=119760 Review URL: https://chromiumcodereview.appspot.com/10440119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141000 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/url_request/url_request_throttler_entry.h')
-rw-r--r--net/url_request/url_request_throttler_entry.h15
1 files changed, 1 insertions, 14 deletions
diff --git a/net/url_request/url_request_throttler_entry.h b/net/url_request/url_request_throttler_entry.h
index 3ebd5c9..e5399c9 100644
--- a/net/url_request/url_request_throttler_entry.h
+++ b/net/url_request/url_request_throttler_entry.h
@@ -93,7 +93,7 @@ class NET_EXPORT URLRequestThrottlerEntry
void DetachManager();
// Implementation of URLRequestThrottlerEntryInterface.
- virtual bool ShouldRejectRequest(int load_flags) const OVERRIDE;
+ virtual bool ShouldRejectRequest(const URLRequest& request) const OVERRIDE;
virtual int64 ReserveSendingTimeForNextRequest(
const base::TimeTicks& earliest_time) OVERRIDE;
virtual base::TimeTicks GetExponentialBackoffReleaseTime() const OVERRIDE;
@@ -118,10 +118,6 @@ class NET_EXPORT URLRequestThrottlerEntry
void HandleThrottlingHeader(const std::string& header_value,
const std::string& host);
- // Used internally to keep track of failure->success transitions and
- // generate statistics about them.
- void HandleMetricsTracking(int response_code);
-
// Retrieves the back-off entry object we're using. Used to enable a
// unit testing seam for dependency injection in tests.
virtual const BackoffEntry* GetBackoffEntry() const;
@@ -164,15 +160,6 @@ class NET_EXPORT URLRequestThrottlerEntry
// Access it through GetBackoffEntry() to allow a unit test seam.
BackoffEntry backoff_entry_;
- // The time of the last successful response, plus knowledge of whether
- // the last response was successful or not, let us generate statistics on
- // the length of perceived downtime for a given URL, and the error count
- // when such transitions occur. This is useful for experiments with
- // throttling but will likely become redundant after they are finished.
- // TODO(joi): Remove when the time is right
- base::TimeTicks last_successful_response_time_;
- bool last_response_was_success_;
-
// Weak back-reference to the manager object managing us.
URLRequestThrottlerManager* manager_;