summaryrefslogtreecommitdiffstats
path: root/net/url_request
diff options
context:
space:
mode:
authornsylvain@chromium.org <nsylvain@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-03-07 16:13:11 +0000
committernsylvain@chromium.org <nsylvain@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-03-07 16:13:11 +0000
commit7c825a47e993f941e13d505727e0d3bc6699d193 (patch)
tree5892e892aed7ad3b4d85fcc1affe43ee0f38ef5f /net/url_request
parent44986391568796028c6ecf84f4112facdaee7e22 (diff)
downloadchromium_src-7c825a47e993f941e13d505727e0d3bc6699d193.zip
chromium_src-7c825a47e993f941e13d505727e0d3bc6699d193.tar.gz
chromium_src-7c825a47e993f941e13d505727e0d3bc6699d193.tar.bz2
Revert change 11197 because it created 138 new layout tests
failures. Review URL: http://codereview.chromium.org/39311 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11201 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/url_request')
-rw-r--r--net/url_request/url_request.cc18
-rw-r--r--net/url_request/url_request.h17
-rw-r--r--net/url_request/url_request_job.h3
3 files changed, 6 insertions, 32 deletions
diff --git a/net/url_request/url_request.cc b/net/url_request/url_request.cc
index 3de8439..fefd24c 100644
--- a/net/url_request/url_request.cc
+++ b/net/url_request/url_request.cc
@@ -260,23 +260,10 @@ void URLRequest::Start() {
}
void URLRequest::Cancel() {
- DoCancel(net::ERR_ABORTED, net::SSLInfo());
+ CancelWithError(net::ERR_ABORTED);
}
-void URLRequest::SimulateError(int os_error) {
- DoCancel(os_error, net::SSLInfo());
-}
-
-void URLRequest::SimulateSSLError(int os_error, const net::SSLInfo& ssl_info) {
- // This should only be called on a started request.
- if (!is_pending_ || !job_ || job_->has_response_started()) {
- NOTREACHED();
- return;
- }
- DoCancel(os_error, ssl_info);
-}
-
-void URLRequest::DoCancel(int os_error, const net::SSLInfo& ssl_info) {
+void URLRequest::CancelWithError(int os_error) {
DCHECK(os_error < 0);
// If the URL request already has an error status, then canceling is a no-op.
@@ -284,7 +271,6 @@ void URLRequest::DoCancel(int os_error, const net::SSLInfo& ssl_info) {
if (status_.is_success()) {
status_.set_status(URLRequestStatus::CANCELED);
status_.set_os_error(os_error);
- response_info_.ssl_info = ssl_info;
}
// There's nothing to do if we are not waiting on a Job.
diff --git a/net/url_request/url_request.h b/net/url_request/url_request.h
index 4309689..f4aee3a 100644
--- a/net/url_request/url_request.h
+++ b/net/url_request/url_request.h
@@ -354,15 +354,10 @@ class URLRequest {
// no effect once the response has completed.
void Cancel();
- // Cancels the request and sets the error to |os_error| (see net_error_list.h
- // for values).
- void SimulateError(int os_error);
-
- // Cancels the request and sets the error to |os_error| (see net_error_list.h
- // for values) and attaches |ssl_info| as the SSLInfo for that request. This
- // is useful to attach a certificate and certificate error to a canceled
- // request.
- void SimulateSSLError(int os_error, const net::SSLInfo& ssl_info);
+ // Similar to Cancel but sets the error to |os_error| (see net_error_list.h
+ // for values) instead of net::ERR_ABORTED.
+ // Used to attach a reason for canceling a request.
+ void CancelWithError(int os_error);
// Read initiates an asynchronous read from the response, and must only
// be called after the OnResponseStarted callback is received with a
@@ -440,10 +435,6 @@ class URLRequest {
// been orphaned.
void OrphanJob();
- // Cancels the request and set the error and ssl info for this request to the
- // passed values.
- void DoCancel(int os_error, const net::SSLInfo& ssl_info);
-
// Discard headers which have meaning in POST (Content-Length, Content-Type,
// Origin).
static std::string StripPostSpecificHeaders(const std::string& headers);
diff --git a/net/url_request/url_request_job.h b/net/url_request/url_request_job.h
index aac3768..fae5a1b 100644
--- a/net/url_request/url_request_job.h
+++ b/net/url_request/url_request_job.h
@@ -192,9 +192,6 @@ class URLRequestJob : public base::RefCountedThreadSafe<URLRequestJob> {
expected_content_size_ = size;
}
- // Whether we have processed the response for that request yet.
- bool has_response_started() const { return has_handled_response_; }
-
protected:
// Notifies the job that headers have been received.
void NotifyHeadersComplete();