diff options
| author | jeremy@chromium.org <jeremy@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-12-17 20:11:50 +0000 |
|---|---|---|
| committer | jeremy@chromium.org <jeremy@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-12-17 20:11:50 +0000 |
| commit | 29ccac132a03315af30ee8dfc7b370a0f30d9661 (patch) | |
| tree | cbd8426793301ad9d51a62e2a3321b410e7c5f04 /net/url_request | |
| parent | 9360a522bce9026154a0417015b8680c45f7720f (diff) | |
| download | chromium_src-29ccac132a03315af30ee8dfc7b370a0f30d9661.zip chromium_src-29ccac132a03315af30ee8dfc7b370a0f30d9661.tar.gz chromium_src-29ccac132a03315af30ee8dfc7b370a0f30d9661.tar.bz2 | |
* On POSIX, make sure we don't leak FDs when launching child Processes.
* Add a facility to LaunchProcess() to remap a given FD into a child process.
This change is needed for 2 reasons:
1)We want to use a socketpair() for IPC, the child process needs a known FD # for it's side of the socket.
2)The OS X Sandbox doesn't close FDs.
Review URL: http://codereview.chromium.org/14497
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7156 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/url_request')
| -rw-r--r-- | net/url_request/url_request_unittest.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/url_request/url_request_unittest.h b/net/url_request/url_request_unittest.h index e2b8ca3..52fa429 100644 --- a/net/url_request/url_request_unittest.h +++ b/net/url_request/url_request_unittest.h @@ -342,8 +342,9 @@ class TestServer : public base::ProcessFilter { if (!cert_path.empty()) command_line.push_back("--https=" + WideToUTF8(cert_path)); + base::file_handle_mapping_vector no_mappings; ASSERT_TRUE( - base::LaunchApp(command_line, false, &process_handle_)) << + base::LaunchApp(command_line, no_mappings, false, &process_handle_)) << "Failed to launch " << command_line[0] << " ..."; #endif |