diff options
author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-30 19:28:44 +0000 |
---|---|---|
committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-30 19:28:44 +0000 |
commit | 528c56de01bbbd38788ed6cf8d2eea4c56cbe19e (patch) | |
tree | ac4f7a001affd772c4ab89701d3d46109b5f9e19 /net/url_request | |
parent | 5c86ada8d84f6e67d17b027d347052ef451241c4 (diff) | |
download | chromium_src-528c56de01bbbd38788ed6cf8d2eea4c56cbe19e.zip chromium_src-528c56de01bbbd38788ed6cf8d2eea4c56cbe19e.tar.gz chromium_src-528c56de01bbbd38788ed6cf8d2eea4c56cbe19e.tar.bz2 |
Move the number conversions from string_util to a new file.
Use the base namespace in the new file. Update callers.
I removed all wstring variants and also the string->number ones that ignore the return value. That encourages people to write code and forget about error handling.
TEST=included unit tests
BUG=none
Review URL: http://codereview.chromium.org/3056029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54355 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/url_request')
-rw-r--r-- | net/url_request/url_request_unittest.cc | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/net/url_request/url_request_unittest.cc b/net/url_request/url_request_unittest.cc index b232db4..48f5351 100644 --- a/net/url_request/url_request_unittest.cc +++ b/net/url_request/url_request_unittest.cc @@ -22,7 +22,7 @@ #include "base/path_service.h" #include "base/process_util.h" #include "base/string_piece.h" -#include "base/string_util.h" +#include "base/string_number_conversions.h" #include "net/base/cookie_monster.h" #include "net/base/cookie_policy.h" #include "net/base/load_flags.h" @@ -172,7 +172,7 @@ TEST_F(URLRequestTestHTTP, ProxyTunnelRedirectTest) { { URLRequest r(GURL("https://www.redirect.com/"), &d); std::string proxy("localhost:"); - proxy.append(IntToString(kHTTPDefaultPort)); + proxy.append(base::IntToString(kHTTPDefaultPort)); r.set_context(new TestURLRequestContext(proxy)); r.Start(); @@ -197,7 +197,7 @@ TEST_F(URLRequestTestHTTP, UnexpectedServerAuthTest) { { URLRequest r(GURL("https://www.server-auth.com/"), &d); std::string proxy("localhost:"); - proxy.append(IntToString(kHTTPDefaultPort)); + proxy.append(base::IntToString(kHTTPDefaultPort)); r.set_context(new TestURLRequestContext(proxy)); r.Start(); @@ -1761,7 +1761,7 @@ TEST_F(URLRequestTestHTTP, Post307RedirectPost) { req.set_upload(CreateSimpleUploadData(kData).get()); net::HttpRequestHeaders headers; headers.SetHeader(net::HttpRequestHeaders::kContentLength, - UintToString(arraysize(kData) - 1)); + base::UintToString(arraysize(kData) - 1)); req.SetExtraRequestHeaders(headers); req.Start(); MessageLoop::current()->Run(); |