summaryrefslogtreecommitdiffstats
path: root/net/url_request
diff options
context:
space:
mode:
authormkosiba@chromium.org <mkosiba@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-09-07 18:24:29 +0000
committermkosiba@chromium.org <mkosiba@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-09-07 18:24:29 +0000
commit2756a8ead95f2e02e1df63f86ce8703bbada27b8 (patch)
tree4fc1797ef163d09d2e618b3ed7b7c89719b681cc /net/url_request
parented028002706859ad939e24f13771bca3243cbe05 (diff)
downloadchromium_src-2756a8ead95f2e02e1df63f86ce8703bbada27b8.zip
chromium_src-2756a8ead95f2e02e1df63f86ce8703bbada27b8.tar.gz
chromium_src-2756a8ead95f2e02e1df63f86ce8703bbada27b8.tar.bz2
Remove the HANDLED_EXTERNALLY status code.
This removes the HANDLED_EXTERNALLY status replacing its use with ResourceRequestInfo::HandledExternally. BUG=none TEST=unit_tests, content_unittests Review URL: https://chromiumcodereview.appspot.com/10640019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155427 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/url_request')
-rw-r--r--net/url_request/url_fetcher_impl_unittest.cc1
-rw-r--r--net/url_request/url_request_status.h9
2 files changed, 2 insertions, 8 deletions
diff --git a/net/url_request/url_fetcher_impl_unittest.cc b/net/url_request/url_fetcher_impl_unittest.cc
index d68586d..a94e887 100644
--- a/net/url_request/url_fetcher_impl_unittest.cc
+++ b/net/url_request/url_fetcher_impl_unittest.cc
@@ -552,6 +552,7 @@ void URLFetcherStopOnRedirectTest::OnURLFetchComplete(
callback_called_ = true;
EXPECT_EQ(GURL(kRedirectTarget), source->GetURL());
EXPECT_EQ(URLRequestStatus::CANCELED, source->GetStatus().status());
+ EXPECT_EQ(ERR_ABORTED, source->GetStatus().error());
EXPECT_EQ(301, source->GetResponseCode());
CleanupAfterFetchComplete();
}
diff --git a/net/url_request/url_request_status.h b/net/url_request/url_request_status.h
index 5cf1218..521a3d45 100644
--- a/net/url_request/url_request_status.h
+++ b/net/url_request/url_request_status.h
@@ -22,11 +22,6 @@ class URLRequestStatus {
// completed.
IO_PENDING,
- // Request was successful but was handled by an external program, so there
- // is no response data. This usually means the current page should not be
- // navigated, but no error should be displayed. |error_| will be 0.
- HANDLED_EXTERNALLY,
-
// Request was cancelled programatically.
CANCELED,
@@ -44,9 +39,7 @@ class URLRequestStatus {
void set_error(int e) { error_ = e; }
// Returns true if the status is success, which makes some calling code more
- // convenient because this is the most common test. Note that we do NOT treat
- // HANDLED_EXTERNALLY as success. For everything except user notifications,
- // this value should be handled like an error (processing should stop).
+ // convenient because this is the most common test.
bool is_success() const {
return status_ == SUCCESS || status_ == IO_PENDING;
}