summaryrefslogtreecommitdiffstats
path: root/net/url_request
diff options
context:
space:
mode:
authorrdsmith@chromium.org <rdsmith@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-06-11 04:28:50 +0000
committerrdsmith@chromium.org <rdsmith@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-06-11 04:28:50 +0000
commitd887518a7b052b930f6464dc28430325b836ad15 (patch)
tree618a49b64e9aef9fb363ae95ff852753728694d8 /net/url_request
parent26ff5f02212c15fa96b95f826234e91cfe145222 (diff)
downloadchromium_src-d887518a7b052b930f6464dc28430325b836ad15.zip
chromium_src-d887518a7b052b930f6464dc28430325b836ad15.tar.gz
chromium_src-d887518a7b052b930f6464dc28430325b836ad15.tar.bz2
Don't advertise SDCH for post requests.
BUG=382626 R=jar@chromium.org Review URL: https://codereview.chromium.org/321863002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276253 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/url_request')
-rw-r--r--net/url_request/url_request_http_job.cc5
1 files changed, 5 insertions, 0 deletions
diff --git a/net/url_request/url_request_http_job.cc b/net/url_request/url_request_http_job.cc
index a7388d1..af786c7 100644
--- a/net/url_request/url_request_http_job.cc
+++ b/net/url_request/url_request_http_job.cc
@@ -473,6 +473,11 @@ void URLRequestHttpJob::AddExtraHeaders() {
if (!request_info_.extra_headers.HasHeader(
HttpRequestHeaders::kAcceptEncoding)) {
bool advertise_sdch = SdchManager::Global() &&
+ // We don't support SDCH responses to POST as there is a possibility
+ // of having SDCH encoded responses returned (e.g. by the cache)
+ // which we cannot decode, and in those situations, we will need
+ // to retransmit the request without SDCH, which is illegal for a POST.
+ request()->method() != "POST" &&
SdchManager::Global()->IsInSupportedDomain(request_->url());
std::string avail_dictionaries;
if (advertise_sdch) {