summaryrefslogtreecommitdiffstats
path: root/net/url_request
diff options
context:
space:
mode:
authorwillchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-03-29 22:02:47 +0000
committerwillchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-03-29 22:02:47 +0000
commit270c641ccd0cd589b8488c5123e5c5830ee10a0b (patch)
treecd0a3f192a7305e3c18e8a9edf5ed5d716476baf /net/url_request
parent11de360780b9cbb846161cd7c772cc26d6f29616 (diff)
downloadchromium_src-270c641ccd0cd589b8488c5123e5c5830ee10a0b.zip
chromium_src-270c641ccd0cd589b8488c5123e5c5830ee10a0b.tar.gz
chromium_src-270c641ccd0cd589b8488c5123e5c5830ee10a0b.tar.bz2
Reland r42300: "HttpRequestHeaders refactor."
Adds a fix and tests for empty header values. The particular bug happened when the value was non-empty, but was all LWS, so it was effectively empty. BUG=22588 Review URL: http://codereview.chromium.org/1370001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43000 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/url_request')
-rw-r--r--net/url_request/url_request_unittest.cc6
1 files changed, 3 insertions, 3 deletions
diff --git a/net/url_request/url_request_unittest.cc b/net/url_request/url_request_unittest.cc
index dc39667..439851b 100644
--- a/net/url_request/url_request_unittest.cc
+++ b/net/url_request/url_request_unittest.cc
@@ -1092,7 +1092,7 @@ TEST_F(URLRequestTestHTTP, VaryHeader) {
TestDelegate d;
URLRequest req(server_->TestServerPage("echoheader?foo"), &d);
req.set_context(context);
- req.SetExtraRequestHeaders("foo:1");
+ req.SetExtraRequestHeaders("foo: 1");
req.Start();
MessageLoop::current()->Run();
}
@@ -1102,7 +1102,7 @@ TEST_F(URLRequestTestHTTP, VaryHeader) {
TestDelegate d;
URLRequest req(server_->TestServerPage("echoheader?foo"), &d);
req.set_context(context);
- req.SetExtraRequestHeaders("foo:1");
+ req.SetExtraRequestHeaders("foo: 1");
req.Start();
MessageLoop::current()->Run();
@@ -1114,7 +1114,7 @@ TEST_F(URLRequestTestHTTP, VaryHeader) {
TestDelegate d;
URLRequest req(server_->TestServerPage("echoheader?foo"), &d);
req.set_context(context);
- req.SetExtraRequestHeaders("foo:2");
+ req.SetExtraRequestHeaders("foo: 2");
req.Start();
MessageLoop::current()->Run();