diff options
| author | joth@chromium.org <joth@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-11-15 13:31:49 +0000 |
|---|---|---|
| committer | joth@chromium.org <joth@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-11-15 13:31:49 +0000 |
| commit | 6de0fd1d935e8c6c9257f1082dbd227acb1a06b1 (patch) | |
| tree | 0ed5bc4ef9c2da0b498c30e562218f4528eaac9e /net/url_request | |
| parent | 0f86c358fdb5e47aa9cd4a99b12da5e66507d080 (diff) | |
| download | chromium_src-6de0fd1d935e8c6c9257f1082dbd227acb1a06b1.zip chromium_src-6de0fd1d935e8c6c9257f1082dbd227acb1a06b1.tar.gz chromium_src-6de0fd1d935e8c6c9257f1082dbd227acb1a06b1.tar.bz2 | |
Allow linker initialization of lazy instance
Using the initializer list construct = {0} allows the object to be linker initialized.
Modify the LazyInstance class design to make it a pod aggregate type that can be linker initialized this way. Also combines the instance and state members, in line with the Singleton<> class design.
Introduces a new LAZY_INSTANCE_INITIALIZER macro specifically for using to init all lazy instances + modify all existing callsites to use it. (Old code would no longer compile)
BUG=94925
TEST=existing tests pass. http://build.chromium.org/f/chromium/perf/linux-release/sizes/report.html?history=150&header=chrome-si&graph=chrome-si&rev=-1 should step downward.
TBR=jam@chromium.org,rvargas@chromium.org,darin@chromium.org,ben@chromium.org,apatrick@chromium.org,akalin@chromium.org
Review URL: http://codereview.chromium.org/8491043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110076 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/url_request')
| -rw-r--r-- | net/url_request/url_request.cc | 2 | ||||
| -rw-r--r-- | net/url_request/url_request_test_job.cc | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/net/url_request/url_request.cc b/net/url_request/url_request.cc index 66d629b..9fcae42 100644 --- a/net/url_request/url_request.cc +++ b/net/url_request/url_request.cc @@ -58,7 +58,7 @@ uint64 g_next_url_request_identifier = 1; // This lock protects g_next_url_request_identifier. base::LazyInstance<base::Lock, base::LeakyLazyInstanceTraits<base::Lock> > - g_next_url_request_identifier_lock(base::LINKER_INITIALIZED); + g_next_url_request_identifier_lock = LAZY_INSTANCE_INITIALIZER; // Returns an prior unused identifier for URL requests. uint64 GenerateURLRequestIdentifier() { diff --git a/net/url_request/url_request_test_job.cc b/net/url_request/url_request_test_job.cc index 1df6f63..6668b03 100644 --- a/net/url_request/url_request_test_job.cc +++ b/net/url_request/url_request_test_job.cc @@ -23,7 +23,7 @@ namespace { typedef std::list<URLRequestTestJob*> URLRequestJobList; base::LazyInstance<URLRequestJobList, base::LeakyLazyInstanceTraits<URLRequestJobList> > - g_pending_jobs(base::LINKER_INITIALIZED); + g_pending_jobs = LAZY_INSTANCE_INITIALIZER; } // namespace |