summaryrefslogtreecommitdiffstats
path: root/net/url_request
diff options
context:
space:
mode:
authorestade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-01-07 00:39:04 +0000
committerestade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-01-07 00:39:04 +0000
commita6ec0897e904792a60a12a58b26dd2214dbcfa39 (patch)
treec0040197acf7510b074af818ef8335b832e22e25 /net/url_request
parent1b4209f4c56fbdb6fe72aca508e8aa1c534964d4 (diff)
downloadchromium_src-a6ec0897e904792a60a12a58b26dd2214dbcfa39.zip
chromium_src-a6ec0897e904792a60a12a58b26dd2214dbcfa39.tar.gz
chromium_src-a6ec0897e904792a60a12a58b26dd2214dbcfa39.tar.bz2
Revert r70628. It broke Linux valgrind bots. See for example
http://build.chromium.org/p/chromium.memory/builders/Linux%20Tests%20%28valgrind%29%281%29/builds/963 First pass at adding http/backend cache events to the NetLog. Adds sources and events for ActiveCacheEntry and EntryImpl objects, as well as adding cache read/write events to HttpCacheTransactions. Most new read/write events are only logged when NetLog logging mode is set to log all events. Also, net-internals now merges begin and end events that have parameters, as long as only one of them has parameters. I think this increases readability, at the cost of making it a little more difficult to follow timings with just the "st" values. BUG=59382 TEST=none yet, other than updates to existing tests. Originally applied: http://src.chromium.org/viewvc/chrome?view=rev&revision=70618 Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=70619 Fixed and trying again... Review URL: http://codereview.chromium.org/6125001 BUG=none TEST=linux valgrind goes green. Review URL: http://codereview.chromium.org/6142003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70688 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/url_request')
-rw-r--r--net/url_request/url_request_unittest.h1
-rw-r--r--net/url_request/view_cache_helper_unittest.cc2
2 files changed, 1 insertions, 2 deletions
diff --git a/net/url_request/url_request_unittest.h b/net/url_request/url_request_unittest.h
index c336b41..b13d268 100644
--- a/net/url_request/url_request_unittest.h
+++ b/net/url_request/url_request_unittest.h
@@ -173,7 +173,6 @@ class TestURLRequestContext : public URLRequestContext {
http_auth_handler_factory_,
network_delegate_,
NULL),
- NULL /* net_log */,
net::HttpCache::DefaultBackend::InMemory(0));
// In-memory cookie store.
cookie_store_ = new net::CookieMonster(NULL, NULL);
diff --git a/net/url_request/view_cache_helper_unittest.cc b/net/url_request/view_cache_helper_unittest.cc
index 3903c2b..5338ee5 100644
--- a/net/url_request/view_cache_helper_unittest.cc
+++ b/net/url_request/view_cache_helper_unittest.cc
@@ -25,7 +25,7 @@ class TestURLRequestContext : public URLRequestContext {
};
TestURLRequestContext::TestURLRequestContext()
- : cache_(reinterpret_cast<net::HttpTransactionFactory*>(NULL), NULL,
+ : cache_(reinterpret_cast<net::HttpTransactionFactory*>(NULL),
net::HttpCache::DefaultBackend::InMemory(0)) {
http_transaction_factory_ = &cache_;
}