diff options
| author | mmenke@chromium.org <mmenke@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-29 22:34:51 +0000 |
|---|---|---|
| committer | mmenke@chromium.org <mmenke@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-29 22:34:51 +0000 |
| commit | 32aa415f8eab2790052277fecfb843e8ad2ba38c (patch) | |
| tree | d315900a8d6f25f527feeab9ba2df8b975dfb107 /net/url_request | |
| parent | 3abba2674d55de917a2ac4d3d2534746845dd076 (diff) | |
| download | chromium_src-32aa415f8eab2790052277fecfb843e8ad2ba38c.zip chromium_src-32aa415f8eab2790052277fecfb843e8ad2ba38c.tar.gz chromium_src-32aa415f8eab2790052277fecfb843e8ad2ba38c.tar.bz2 | |
Remove HttpStream::GetResponseInfo, which is not currently used.
HttpStream::GetResponseInfo returned a pointer to an object not owned
by the HttpStream, so could result in returning freed memory, in the
case the stream outlives its client. This happens in the case an
HttpResponseBodyDrainer is used.
As the method isn't used anywhere, seems a good idea to get rid of it.
BUG=none
Review URL: https://codereview.chromium.org/303443009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273629 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/url_request')
| -rw-r--r-- | net/url_request/url_request_http_job_unittest.cc | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/net/url_request/url_request_http_job_unittest.cc b/net/url_request/url_request_http_job_unittest.cc index 40aac63..a112ed9 100644 --- a/net/url_request/url_request_http_job_unittest.cc +++ b/net/url_request/url_request_http_job_unittest.cc @@ -213,10 +213,6 @@ class FakeWebSocketHandshakeStream : public WebSocketHandshakeStreamBase { return ERR_IO_PENDING; } - virtual const HttpResponseInfo* GetResponseInfo() const OVERRIDE { - return NULL; - } - virtual int ReadResponseBody(IOBuffer* buf, int buf_len, const CompletionCallback& callback) OVERRIDE { |