diff options
| author | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-04 01:05:03 +0000 |
|---|---|---|
| committer | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-04 01:05:03 +0000 |
| commit | eb4ecaca516c112de4a31a354490fe5e6c90b42f (patch) | |
| tree | a88735c3bbef8aea407e3298bcb8e922f30732fe /net/url_request | |
| parent | 84d388914a464d1c04da5a666660df68fa00862f (diff) | |
| download | chromium_src-eb4ecaca516c112de4a31a354490fe5e6c90b42f.zip chromium_src-eb4ecaca516c112de4a31a354490fe5e6c90b42f.tar.gz chromium_src-eb4ecaca516c112de4a31a354490fe5e6c90b42f.tar.bz2 | |
Add more variables to the URLRequest leak assertion crash dumps.
BUG=90971
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10378005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135261 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/url_request')
| -rw-r--r-- | net/url_request/url_request.h | 5 | ||||
| -rw-r--r-- | net/url_request/url_request_context.cc | 4 |
2 files changed, 7 insertions, 2 deletions
diff --git a/net/url_request/url_request.h b/net/url_request/url_request.h index 958f6ab..bff16d7 100644 --- a/net/url_request/url_request.h +++ b/net/url_request/url_request.h @@ -589,6 +589,9 @@ class NET_EXPORT URLRequest : NON_EXPORTED_BASE(public base::NonThreadSafe), // unit tests outside of net :(. URLRequestJob* job() { return job_; } + // TODO(willchan): Undo this. Only temporarily public. + bool has_delegate() const { return delegate_ != NULL; } + protected: // Allow the URLRequestJob class to control the is_pending() flag. void set_is_pending(bool value) { is_pending_ = value; } @@ -663,8 +666,6 @@ class NET_EXPORT URLRequest : NON_EXPORTED_BASE(public base::NonThreadSafe), // occurs. void NotifyResponseStarted(); - bool has_delegate() const { return delegate_ != NULL; } - // These functions delegate to |delegate_| and may only be used if // |delegate_| is not NULL. See URLRequest::Delegate for the meaning // of these functions. diff --git a/net/url_request/url_request_context.cc b/net/url_request/url_request_context.cc index 1076f00..08cf95a 100644 --- a/net/url_request/url_request_context.cc +++ b/net/url_request/url_request_context.cc @@ -75,8 +75,12 @@ void URLRequestContext::AssertNoURLRequests() const { char url_buf[128]; const URLRequest* request = *url_requests_->begin(); base::strlcpy(url_buf, request->url().spec().c_str(), arraysize(url_buf)); + bool has_delegate = request->has_delegate(); + int load_flags = request->load_flags(); base::debug::Alias(url_buf); base::debug::Alias(&num_requests); + base::debug::Alias(&has_delegate); + base::debug::Alias(&load_flags); CHECK(false); } } |