diff options
| author | satorux@chromium.org <satorux@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-12-10 08:12:54 +0000 |
|---|---|---|
| committer | satorux@chromium.org <satorux@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-12-10 08:12:54 +0000 |
| commit | 06489a012706979c4a82bc2f3ac502b82fca2346 (patch) | |
| tree | 48f056ae8cb3f1735744ee61cb5a8f0581e7dddc /net/websockets/websocket.h | |
| parent | 27477a9f30776550ac1264d65f8f2a69984b32d0 (diff) | |
| download | chromium_src-06489a012706979c4a82bc2f3ac502b82fca2346.zip chromium_src-06489a012706979c4a82bc2f3ac502b82fca2346.tar.gz chromium_src-06489a012706979c4a82bc2f3ac502b82fca2346.tar.bz2 | |
Improve the test coverage of WebSocket class.
The logic for creating the client handshake message is substantially
complex so it would be nice to have better test coverage, before it
gets more complex.
TEST=net_unittests
BUG=none
Review URL: http://codereview.chromium.org/473003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34241 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/websockets/websocket.h')
| -rw-r--r-- | net/websockets/websocket.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/net/websockets/websocket.h b/net/websockets/websocket.h index 566ee6f..0cf95db 100644 --- a/net/websockets/websocket.h +++ b/net/websockets/websocket.h @@ -95,6 +95,9 @@ class WebSocket : public base::RefCountedThreadSafe<WebSocket>, return client_socket_factory_; } + // Creates the client handshake message from |this|. + std::string CreateClientHandshakeMessage() const; + private: GURL url_; std::string protocol_; @@ -154,9 +157,6 @@ class WebSocket : public base::RefCountedThreadSafe<WebSocket>, friend class base::RefCountedThreadSafe<WebSocket>; virtual ~WebSocket(); - // Creates client handshake mssage based on |request_|. - IOBufferWithSize* CreateClientHandshakeMessage() const; - // Checks handshake. // Prerequisite: Server handshake message is received in |current_read_buf_|. // Returns number of bytes for server handshake message, |