diff options
| author | jar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-04 23:08:15 +0000 |
|---|---|---|
| committer | jar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-04 23:08:15 +0000 |
| commit | d7a80be378e94a6b649de4ac49509f461d0d99e7 (patch) | |
| tree | e6e54a3ceb492fb9ac4cce14ced1b1b36aa3c99c /net | |
| parent | 05a46357ae3242d583b87db562eb21e7de03aad9 (diff) | |
| download | chromium_src-d7a80be378e94a6b649de4ac49509f461d0d99e7.zip chromium_src-d7a80be378e94a6b649de4ac49509f461d0d99e7.tar.gz chromium_src-d7a80be378e94a6b649de4ac49509f461d0d99e7.tar.bz2 | |
Skip generation of stats, since code is now shared across threads
The stats function was not written to be shared across threads, and
recent use by sync on a second thread is causing it to malfunction
(because it uses function level statics).
r=wtc
bug=74467
Review URL: http://codereview.chromium.org/6624023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76989 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net')
| -rw-r--r-- | net/base/connection_type_histograms.cc | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/net/base/connection_type_histograms.cc b/net/base/connection_type_histograms.cc index 5146e91e..06cdead 100644 --- a/net/base/connection_type_histograms.cc +++ b/net/base/connection_type_histograms.cc @@ -21,6 +21,11 @@ namespace net { // Each histogram has an unused bucket at the end to allow seamless future // expansion. void UpdateConnectionTypeHistograms(ConnectionType type) { + // TODO(wtc): Bug 74467 Move these stats up to a higher level, where the + // explicit static (shown below) and the implicit statics (inside the + // HISTOGRAM macros) will be thread safe. +#if 0 // Don't do anything for now. + static bool had_connection_type[NUM_OF_CONNECTION_TYPES]; if (type >= 0 && type < NUM_OF_CONNECTION_TYPES) { @@ -35,6 +40,7 @@ void UpdateConnectionTypeHistograms(ConnectionType type) { } else { NOTREACHED(); // Someone's logging an invalid type! } +#endif // 0 } } // namespace net |