diff options
author | tfarina@chromium.org <tfarina@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-15 00:21:34 +0000 |
---|---|---|
committer | tfarina@chromium.org <tfarina@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-15 00:21:34 +0000 |
commit | aeb53f0e2f6352ec7fbc2113270a97072b42c764 (patch) | |
tree | 1f4da7884df919c21903a7881964273a9f7496fd /net | |
parent | ec8962ca7de01eb5685b32a4361dd7be8f7e6293 (diff) | |
download | chromium_src-aeb53f0e2f6352ec7fbc2113270a97072b42c764.zip chromium_src-aeb53f0e2f6352ec7fbc2113270a97072b42c764.tar.gz chromium_src-aeb53f0e2f6352ec7fbc2113270a97072b42c764.tar.bz2 |
net: Remove typedef net::URLRequestContext URLRequestContext;
BUG=64263
TEST=compiled locally, trybots
Review URL: http://codereview.chromium.org/6338002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71522 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net')
-rw-r--r-- | net/ocsp/nss_ocsp.cc | 8 | ||||
-rw-r--r-- | net/proxy/init_proxy_resolver_unittest.cc | 4 | ||||
-rw-r--r-- | net/proxy/proxy_script_fetcher.h | 2 | ||||
-rw-r--r-- | net/proxy/proxy_script_fetcher_impl.cc | 12 | ||||
-rw-r--r-- | net/proxy/proxy_script_fetcher_impl.h | 6 | ||||
-rw-r--r-- | net/proxy/proxy_script_fetcher_impl_unittest.cc | 20 | ||||
-rw-r--r-- | net/proxy/proxy_service_unittest.cc | 4 | ||||
-rw-r--r-- | net/socket_stream/socket_stream.cc | 6 | ||||
-rw-r--r-- | net/socket_stream/socket_stream.h | 8 | ||||
-rw-r--r-- | net/socket_stream/socket_stream_job.h | 4 | ||||
-rw-r--r-- | net/spdy/spdy_test_util.h | 4 | ||||
-rw-r--r-- | net/url_request/url_request_context.h | 3 | ||||
-rw-r--r-- | net/url_request/url_request_unittest.cc | 16 | ||||
-rw-r--r-- | net/url_request/url_request_unittest.h | 2 | ||||
-rw-r--r-- | net/url_request/view_cache_helper_unittest.cc | 6 | ||||
-rw-r--r-- | net/websockets/websocket_job_unittest.cc | 4 |
16 files changed, 53 insertions, 56 deletions
diff --git a/net/ocsp/nss_ocsp.cc b/net/ocsp/nss_ocsp.cc index 78eb7f5..d541370 100644 --- a/net/ocsp/nss_ocsp.cc +++ b/net/ocsp/nss_ocsp.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2010 The Chromium Authors. All rights reserved. +// Copyright (c) 2011 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -39,7 +39,7 @@ namespace { // Protects |g_request_context|. pthread_mutex_t g_request_context_lock = PTHREAD_MUTEX_INITIALIZER; -static URLRequestContext* g_request_context = NULL; +static net::URLRequestContext* g_request_context = NULL; class OCSPRequestSession; @@ -349,7 +349,7 @@ class OCSPRequestSession DCHECK(!request_); pthread_mutex_lock(&g_request_context_lock); - URLRequestContext* url_request_context = g_request_context; + net::URLRequestContext* url_request_context = g_request_context; pthread_mutex_unlock(&g_request_context_lock); if (url_request_context == NULL) @@ -575,7 +575,7 @@ SECStatus OCSPCreateSession(const char* host, PRUint16 portnum, SEC_HTTP_SERVER_SESSION* pSession) { VLOG(1) << "OCSP create session: host=" << host << " port=" << portnum; pthread_mutex_lock(&g_request_context_lock); - URLRequestContext* request_context = g_request_context; + net::URLRequestContext* request_context = g_request_context; pthread_mutex_unlock(&g_request_context_lock); if (request_context == NULL) { LOG(ERROR) << "No URLRequestContext for OCSP handler."; diff --git a/net/proxy/init_proxy_resolver_unittest.cc b/net/proxy/init_proxy_resolver_unittest.cc index c1a69d1..91097d0e 100644 --- a/net/proxy/init_proxy_resolver_unittest.cc +++ b/net/proxy/init_proxy_resolver_unittest.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2009 The Chromium Authors. All rights reserved. +// Copyright (c) 2011 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -107,7 +107,7 @@ class RuleBasedProxyScriptFetcher : public ProxyScriptFetcher { virtual void Cancel() {} - virtual URLRequestContext* GetRequestContext() { return NULL; } + virtual net::URLRequestContext* GetRequestContext() { return NULL; } private: const Rules* rules_; diff --git a/net/proxy/proxy_script_fetcher.h b/net/proxy/proxy_script_fetcher.h index 9829316..e42d979 100644 --- a/net/proxy/proxy_script_fetcher.h +++ b/net/proxy/proxy_script_fetcher.h @@ -49,7 +49,7 @@ class ProxyScriptFetcher { // Returns the request context that this fetcher uses to issue downloads, // or NULL. - virtual URLRequestContext* GetRequestContext() = 0; + virtual net::URLRequestContext* GetRequestContext() = 0; }; } // namespace net diff --git a/net/proxy/proxy_script_fetcher_impl.cc b/net/proxy/proxy_script_fetcher_impl.cc index 0a54046..0724127 100644 --- a/net/proxy/proxy_script_fetcher_impl.cc +++ b/net/proxy/proxy_script_fetcher_impl.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2010 The Chromium Authors. All rights reserved. +// Copyright (c) 2011 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -70,7 +70,7 @@ void ConvertResponseToUTF16(const std::string& charset, } // namespace ProxyScriptFetcherImpl::ProxyScriptFetcherImpl( - URLRequestContext* url_request_context) + net::URLRequestContext* url_request_context) : ALLOW_THIS_IN_INITIALIZER_LIST(task_factory_(this)), url_request_context_(url_request_context), buf_(new net::IOBuffer(kBufSize)), @@ -134,7 +134,7 @@ void ProxyScriptFetcherImpl::Cancel() { ResetCurRequestState(); } -URLRequestContext* ProxyScriptFetcherImpl::GetRequestContext() { +net::URLRequestContext* ProxyScriptFetcherImpl::GetRequestContext() { return url_request_context_; } @@ -260,9 +260,9 @@ void ProxyScriptFetcherImpl::FetchCompleted() { int result_code = result_code_; CompletionCallback* callback = callback_; - // Hold a reference to the URLRequestContext to prevent re-entrancy from - // ~URLRequestContext. - scoped_refptr<URLRequestContext> context(cur_request_->context()); + // Hold a reference to the net::URLRequestContext to prevent re-entrancy from + // ~net::URLRequestContext. + scoped_refptr<net::URLRequestContext> context(cur_request_->context()); ResetCurRequestState(); callback->Run(result_code); diff --git a/net/proxy/proxy_script_fetcher_impl.h b/net/proxy/proxy_script_fetcher_impl.h index bd141f3..2dc0335 100644 --- a/net/proxy/proxy_script_fetcher_impl.h +++ b/net/proxy/proxy_script_fetcher_impl.h @@ -33,7 +33,7 @@ class ProxyScriptFetcherImpl : public ProxyScriptFetcher, // Note that while a request is in progress, we will be holding a reference // to |url_request_context|. Be careful not to create cycles between the // fetcher and the context; you can break such cycles by calling Cancel(). - explicit ProxyScriptFetcherImpl(URLRequestContext* url_request_context); + explicit ProxyScriptFetcherImpl(net::URLRequestContext* url_request_context); virtual ~ProxyScriptFetcherImpl(); @@ -42,7 +42,7 @@ class ProxyScriptFetcherImpl : public ProxyScriptFetcher, virtual int Fetch(const GURL& url, string16* text, CompletionCallback* callback); virtual void Cancel(); - virtual URLRequestContext* GetRequestContext(); + virtual net::URLRequestContext* GetRequestContext(); // net::URLRequest::Delegate methods: virtual void OnAuthRequired(net::URLRequest* request, @@ -80,7 +80,7 @@ class ProxyScriptFetcherImpl : public ProxyScriptFetcher, ScopedRunnableMethodFactory<ProxyScriptFetcherImpl> task_factory_; // The context used for making network requests. - URLRequestContext* url_request_context_; + net::URLRequestContext* url_request_context_; // Buffer that net::URLRequest writes into. enum { kBufSize = 4096 }; diff --git a/net/proxy/proxy_script_fetcher_impl_unittest.cc b/net/proxy/proxy_script_fetcher_impl_unittest.cc index 043f71e..84b822c 100644 --- a/net/proxy/proxy_script_fetcher_impl_unittest.cc +++ b/net/proxy/proxy_script_fetcher_impl_unittest.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2010 The Chromium Authors. All rights reserved. +// Copyright (c) 2011 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -32,7 +32,7 @@ struct FetchResult { }; // A non-mock URL request which can access http:// and file:// urls. -class RequestContext : public URLRequestContext { +class RequestContext : public net::URLRequestContext { public: RequestContext() { net::ProxyConfig no_proxy; @@ -88,7 +88,7 @@ class ProxyScriptFetcherImplTest : public PlatformTest { }; TEST_F(ProxyScriptFetcherImplTest, FileUrl) { - scoped_refptr<URLRequestContext> context(new RequestContext); + scoped_refptr<net::URLRequestContext> context(new RequestContext); ProxyScriptFetcherImpl pac_fetcher(context); { // Fetch a non-existent file. @@ -116,7 +116,7 @@ TEST_F(ProxyScriptFetcherImplTest, FileUrl) { TEST_F(ProxyScriptFetcherImplTest, HttpMimeType) { ASSERT_TRUE(test_server_.Start()); - scoped_refptr<URLRequestContext> context(new RequestContext); + scoped_refptr<net::URLRequestContext> context(new RequestContext); ProxyScriptFetcherImpl pac_fetcher(context); { // Fetch a PAC with mime type "text/plain" @@ -151,7 +151,7 @@ TEST_F(ProxyScriptFetcherImplTest, HttpMimeType) { TEST_F(ProxyScriptFetcherImplTest, HttpStatusCode) { ASSERT_TRUE(test_server_.Start()); - scoped_refptr<URLRequestContext> context(new RequestContext); + scoped_refptr<net::URLRequestContext> context(new RequestContext); ProxyScriptFetcherImpl pac_fetcher(context); { // Fetch a PAC which gives a 500 -- FAIL @@ -177,7 +177,7 @@ TEST_F(ProxyScriptFetcherImplTest, HttpStatusCode) { TEST_F(ProxyScriptFetcherImplTest, ContentDisposition) { ASSERT_TRUE(test_server_.Start()); - scoped_refptr<URLRequestContext> context(new RequestContext); + scoped_refptr<net::URLRequestContext> context(new RequestContext); ProxyScriptFetcherImpl pac_fetcher(context); // Fetch PAC scripts via HTTP with a Content-Disposition header -- should @@ -194,7 +194,7 @@ TEST_F(ProxyScriptFetcherImplTest, ContentDisposition) { TEST_F(ProxyScriptFetcherImplTest, NoCache) { ASSERT_TRUE(test_server_.Start()); - scoped_refptr<URLRequestContext> context(new RequestContext); + scoped_refptr<net::URLRequestContext> context(new RequestContext); ProxyScriptFetcherImpl pac_fetcher(context); // Fetch a PAC script whose HTTP headers make it cacheable for 1 hour. @@ -226,7 +226,7 @@ TEST_F(ProxyScriptFetcherImplTest, NoCache) { TEST_F(ProxyScriptFetcherImplTest, TooLarge) { ASSERT_TRUE(test_server_.Start()); - scoped_refptr<URLRequestContext> context(new RequestContext); + scoped_refptr<net::URLRequestContext> context(new RequestContext); ProxyScriptFetcherImpl pac_fetcher(context); // Set the maximum response size to 50 bytes. @@ -267,7 +267,7 @@ TEST_F(ProxyScriptFetcherImplTest, TooLarge) { TEST_F(ProxyScriptFetcherImplTest, Hang) { ASSERT_TRUE(test_server_.Start()); - scoped_refptr<URLRequestContext> context(new RequestContext); + scoped_refptr<net::URLRequestContext> context(new RequestContext); ProxyScriptFetcherImpl pac_fetcher(context); // Set the timeout period to 0.5 seconds. @@ -305,7 +305,7 @@ TEST_F(ProxyScriptFetcherImplTest, Hang) { TEST_F(ProxyScriptFetcherImplTest, Encodings) { ASSERT_TRUE(test_server_.Start()); - scoped_refptr<URLRequestContext> context(new RequestContext); + scoped_refptr<net::URLRequestContext> context(new RequestContext); ProxyScriptFetcherImpl pac_fetcher(context); // Test a response that is gzip-encoded -- should get inflated. diff --git a/net/proxy/proxy_service_unittest.cc b/net/proxy/proxy_service_unittest.cc index 7dec769..aefd5a3 100644 --- a/net/proxy/proxy_service_unittest.cc +++ b/net/proxy/proxy_service_unittest.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2010 The Chromium Authors. All rights reserved. +// Copyright (c) 2011 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -98,7 +98,7 @@ class MockProxyScriptFetcher : public ProxyScriptFetcher { virtual void Cancel() {} - virtual URLRequestContext* GetRequestContext() { return NULL; } + virtual net::URLRequestContext* GetRequestContext() { return NULL; } const GURL& pending_request_url() const { return pending_request_url_; diff --git a/net/socket_stream/socket_stream.cc b/net/socket_stream/socket_stream.cc index 573b5d0..be402c6 100644 --- a/net/socket_stream/socket_stream.cc +++ b/net/socket_stream/socket_stream.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2010 The Chromium Authors. All rights reserved. +// Copyright (c) 2011 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. // @@ -96,8 +96,8 @@ void SocketStream::SetUserData(const void* key, UserData* data) { user_data_[key] = linked_ptr<UserData>(data); } -void SocketStream::set_context(URLRequestContext* context) { - scoped_refptr<URLRequestContext> prev_context = context_; +void SocketStream::set_context(net::URLRequestContext* context) { + scoped_refptr<net::URLRequestContext> prev_context = context_; context_ = context; diff --git a/net/socket_stream/socket_stream.h b/net/socket_stream/socket_stream.h index b2afd1b..7288dec 100644 --- a/net/socket_stream/socket_stream.h +++ b/net/socket_stream/socket_stream.h @@ -1,4 +1,4 @@ -// Copyright (c) 2010 The Chromium Authors. All rights reserved. +// Copyright (c) 2011 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -112,8 +112,8 @@ class SocketStream : public base::RefCountedThreadSafe<SocketStream> { Delegate* delegate() const { return delegate_; } int max_pending_send_allowed() const { return max_pending_send_allowed_; } - URLRequestContext* context() const { return context_.get(); } - void set_context(URLRequestContext* context); + net::URLRequestContext* context() const { return context_.get(); } + void set_context(net::URLRequestContext* context); BoundNetLog* net_log() { return &net_log_; } @@ -271,7 +271,7 @@ class SocketStream : public base::RefCountedThreadSafe<SocketStream> { GURL url_; int max_pending_send_allowed_; - scoped_refptr<URLRequestContext> context_; + scoped_refptr<net::URLRequestContext> context_; UserDataMap user_data_; diff --git a/net/socket_stream/socket_stream_job.h b/net/socket_stream/socket_stream_job.h index 973c20a..6253499 100644 --- a/net/socket_stream/socket_stream_job.h +++ b/net/socket_stream/socket_stream_job.h @@ -42,10 +42,10 @@ class SocketStreamJob : public base::RefCountedThreadSafe<SocketStreamJob> { virtual SocketStream::UserData* GetUserData(const void* key) const; virtual void SetUserData(const void* key, SocketStream::UserData* data); - URLRequestContext* context() const { + net::URLRequestContext* context() const { return socket_->context(); } - void set_context(URLRequestContext* context) { + void set_context(net::URLRequestContext* context) { socket_->set_context(context); } diff --git a/net/spdy/spdy_test_util.h b/net/spdy/spdy_test_util.h index 1b052fa..96ce5de 100644 --- a/net/spdy/spdy_test_util.h +++ b/net/spdy/spdy_test_util.h @@ -1,4 +1,4 @@ -// Copyright (c) 2010 The Chromium Authors. All rights reserved. +// Copyright (c) 2011 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -397,7 +397,7 @@ class SpdySessionDependencies { } }; -class SpdyURLRequestContext : public URLRequestContext { +class SpdyURLRequestContext : public net::URLRequestContext { public: SpdyURLRequestContext() { host_resolver_ = new MockHostResolver(); diff --git a/net/url_request/url_request_context.h b/net/url_request/url_request_context.h index b54faf4..2c737ca 100644 --- a/net/url_request/url_request_context.h +++ b/net/url_request/url_request_context.h @@ -192,7 +192,4 @@ class URLRequestContext } // namespace net -// TODO(tfarina): Fix the callers and remove this! -typedef net::URLRequestContext URLRequestContext; - #endif // NET_URL_REQUEST_URL_REQUEST_CONTEXT_H_ diff --git a/net/url_request/url_request_unittest.cc b/net/url_request/url_request_unittest.cc index 8d57e1e..e53a6e3 100644 --- a/net/url_request/url_request_unittest.cc +++ b/net/url_request/url_request_unittest.cc @@ -150,7 +150,7 @@ class URLRequestTestHTTP : public URLRequestTest { } uploadBytes[kMsgSize] = '\0'; - scoped_refptr<URLRequestContext> context(new TestURLRequestContext()); + scoped_refptr<net::URLRequestContext> context(new TestURLRequestContext()); for (int i = 0; i < kIterations; ++i) { TestDelegate d; @@ -531,7 +531,7 @@ TEST_F(URLRequestTestHTTP, CancelTest4) { TEST_F(URLRequestTestHTTP, CancelTest5) { ASSERT_TRUE(test_server_.Start()); - scoped_refptr<URLRequestContext> context(new TestURLRequestContext()); + scoped_refptr<net::URLRequestContext> context(new TestURLRequestContext()); // populate cache { @@ -1138,7 +1138,7 @@ TEST_F(URLRequestTestHTTP, CancelDeferredRedirect) { TEST_F(URLRequestTestHTTP, VaryHeader) { ASSERT_TRUE(test_server_.Start()); - scoped_refptr<URLRequestContext> context(new TestURLRequestContext()); + scoped_refptr<net::URLRequestContext> context(new TestURLRequestContext()); // populate the cache { @@ -1184,7 +1184,7 @@ TEST_F(URLRequestTestHTTP, VaryHeader) { TEST_F(URLRequestTestHTTP, BasicAuth) { ASSERT_TRUE(test_server_.Start()); - scoped_refptr<URLRequestContext> context(new TestURLRequestContext()); + scoped_refptr<net::URLRequestContext> context(new TestURLRequestContext()); // populate the cache { @@ -1234,7 +1234,7 @@ TEST_F(URLRequestTestHTTP, BasicAuthWithCookies) { // Request a page that will give a 401 containing a Set-Cookie header. // Verify that when the transaction is restarted, it includes the new cookie. { - scoped_refptr<URLRequestContext> context(new TestURLRequestContext()); + scoped_refptr<net::URLRequestContext> context(new TestURLRequestContext()); TestDelegate d; d.set_username(kUser); d.set_password(kSecret); @@ -1255,7 +1255,7 @@ TEST_F(URLRequestTestHTTP, BasicAuthWithCookies) { // Same test as above, except this time the restart is initiated earlier // (without user intervention since identity is embedded in the URL). { - scoped_refptr<URLRequestContext> context(new TestURLRequestContext()); + scoped_refptr<net::URLRequestContext> context(new TestURLRequestContext()); TestDelegate d; GURL::Replacements replacements; @@ -1283,7 +1283,7 @@ TEST_F(URLRequestTest, DoNotSendCookies) { net::TestServer test_server(net::TestServer::TYPE_HTTP, FilePath()); ASSERT_TRUE(test_server.Start()); - scoped_refptr<URLRequestContext> context(new TestURLRequestContext()); + scoped_refptr<net::URLRequestContext> context(new TestURLRequestContext()); // Set up a cookie. { @@ -1332,7 +1332,7 @@ TEST_F(URLRequestTest, DoNotSaveCookies) { net::TestServer test_server(net::TestServer::TYPE_HTTP, FilePath()); ASSERT_TRUE(test_server.Start()); - scoped_refptr<URLRequestContext> context(new TestURLRequestContext()); + scoped_refptr<net::URLRequestContext> context(new TestURLRequestContext()); // Set up a cookie. { diff --git a/net/url_request/url_request_unittest.h b/net/url_request/url_request_unittest.h index 043ee87..f133015 100644 --- a/net/url_request/url_request_unittest.h +++ b/net/url_request/url_request_unittest.h @@ -122,7 +122,7 @@ class TestCookiePolicy : public net::CookiePolicy { //----------------------------------------------------------------------------- -class TestURLRequestContext : public URLRequestContext { +class TestURLRequestContext : public net::URLRequestContext { public: TestURLRequestContext() { host_resolver_ = diff --git a/net/url_request/view_cache_helper_unittest.cc b/net/url_request/view_cache_helper_unittest.cc index 3903c2b..b99a90c 100644 --- a/net/url_request/view_cache_helper_unittest.cc +++ b/net/url_request/view_cache_helper_unittest.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2010 The Chromium Authors. All rights reserved. +// Copyright (c) 2011 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -13,7 +13,7 @@ namespace { -class TestURLRequestContext : public URLRequestContext { +class TestURLRequestContext : public net::URLRequestContext { public: TestURLRequestContext(); @@ -81,7 +81,7 @@ void WriteToEntry(disk_cache::Backend* cache, const std::string key, entry->Close(); } -void FillCache(URLRequestContext* context) { +void FillCache(net::URLRequestContext* context) { TestCompletionCallback cb; disk_cache::Backend* cache; int rv = diff --git a/net/websockets/websocket_job_unittest.cc b/net/websockets/websocket_job_unittest.cc index 342a2a3..a0ff609 100644 --- a/net/websockets/websocket_job_unittest.cc +++ b/net/websockets/websocket_job_unittest.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2010 The Chromium Authors. All rights reserved. +// Copyright (c) 2011 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -177,7 +177,7 @@ class MockCookiePolicy : public CookiePolicy, CompletionCallback* callback_; }; -class MockURLRequestContext : public URLRequestContext { +class MockURLRequestContext : public net::URLRequestContext { public: MockURLRequestContext(CookieStore* cookie_store, CookiePolicy* cookie_policy) { |