Remove unnecessary null pointer tests to avoid a false Coverity

FORWARD_NULL defect.

In the for loop, at most one buffer in the |buffers| array
is of type SECBUFFER_DATA and at most one is of type SECBUFFER_EXTRA.
The null pointer test for decrypted_ptr_ is not necessary because
when we encounter the only buffer of type SECBUFFER_DATA, decrypted_ptr_
must be NULL (the initial value).  I added a DCHECK to assert that.
Similarly the null pointer test for received_ptr_ is not necessary.

R=mattm
BUG=22286
CID=5331
TEST=one
Review URL: http://codereview.chromium.org/371014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31499 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 13 insertions, 7 deletions

diff --git a/net/socket/ssl_client_socket_win.cc b/net/socket/ssl_client_socket_win.cc
index 7212095..3d1841b 100644
--- a/net/socket/ssl_client_socket_win.cc
+++ b/net/socket/ssl_client_socket_win.cc
@@ -1091,13 +1091,19 @@ int SSLClientSocketWin::DoPayloadDecrypt() {
     received_ptr_ = NULL;
     bytes_received_ = 0;
     for (int i = 1; i < 4; i++) {
-      if (!decrypted_ptr_ && buffers[i].BufferType == SECBUFFER_DATA) {
-        decrypted_ptr_ = static_cast<char*>(buffers[i].pvBuffer);
-        bytes_decrypted_ = buffers[i].cbBuffer;
-      }
-      if (!received_ptr_ && buffers[i].BufferType == SECBUFFER_EXTRA) {
-        received_ptr_ = static_cast<char*>(buffers[i].pvBuffer);
-        bytes_received_ = buffers[i].cbBuffer;
+      switch (buffers[i].BufferType) {
+        case SECBUFFER_DATA:
+          DCHECK(!decrypted_ptr_ && bytes_decrypted_ == 0);
+          decrypted_ptr_ = static_cast<char*>(buffers[i].pvBuffer);
+          bytes_decrypted_ = buffers[i].cbBuffer;
+          break;
+        case SECBUFFER_EXTRA:
+          DCHECK(!received_ptr_ && bytes_received_ == 0);
+          received_ptr_ = static_cast<char*>(buffers[i].pvBuffer);
+          bytes_received_ = buffers[i].cbBuffer;
+          break;
+        default:
+          break;
       }
     }