summaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorrtenneti@chromium.org <rtenneti@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-10-17 23:50:01 +0000
committerrtenneti@chromium.org <rtenneti@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-10-17 23:50:01 +0000
commit41d513cb215f685eb5bd7b57ad91643773b0e9e2 (patch)
tree4f1d8eed6958a051a113c13d9a95e34c2295dc97 /net
parente24c23bd6174420b0ff4339e88434c09b2a3c5e1 (diff)
downloadchromium_src-41d513cb215f685eb5bd7b57ad91643773b0e9e2.zip
chromium_src-41d513cb215f685eb5bd7b57ad91643773b0e9e2.tar.gz
chromium_src-41d513cb215f685eb5bd7b57ad91643773b0e9e2.tar.bz2
Changes the sending of PING to 1 secs instead
of 200ms BUG=100587 R=jar TEST=network unit tests Review URL: http://codereview.chromium.org/8330002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105968 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net')
-rw-r--r--net/spdy/spdy_session.cc10
1 files changed, 8 insertions, 2 deletions
diff --git a/net/spdy/spdy_session.cc b/net/spdy/spdy_session.cc
index f2ee00a..62db0f7 100644
--- a/net/spdy/spdy_session.cc
+++ b/net/spdy/spdy_session.cc
@@ -237,7 +237,7 @@ bool SpdySession::enable_ping_based_connection_checking_ = true;
int SpdySession::connection_at_risk_of_loss_ms_ = 0;
// static
-int SpdySession::trailing_ping_delay_time_ms_ = 200;
+int SpdySession::trailing_ping_delay_time_ms_ = 1000;
// static
int SpdySession::hung_interval_ms_ = 10000;
@@ -528,6 +528,11 @@ int SpdySession::WriteSynStream(
make_scoped_refptr(
new NetLogSpdySynParameter(headers, flags, stream_id, 0)));
}
+
+ // Some servers don't like too many pings, so we limit our current sending to
+ // no more than one ping for any syn sent. To do this, we avoid ever setting
+ // this to true unless we send a syn (which we have just done). This approach
+ // may change over time as servers change their responses to pings.
need_to_send_ping_ = true;
return ERR_IO_PENDING;
@@ -1542,7 +1547,8 @@ void SpdySession::SendPrefacePingIfNoneInFlight() {
}
void SpdySession::SendPrefacePing() {
- // TODO(rtenneti): Enable sending Preface-PING after server fix.
+ // TODO(rtenneti): Send preface pings when more servers support additional
+ // pings.
// WritePingFrame(next_ping_id_);
}