diff options
| author | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-12 19:57:16 +0000 |
|---|---|---|
| committer | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-12 19:57:16 +0000 |
| commit | 97d052416394e439380cb932dfaed867e9db650b (patch) | |
| tree | be6caff6c95a4294713bb26aecdb947b2fdb7c65 /net | |
| parent | 0aa22e2feda12ca6a9e9f26a084a2307acfcc080 (diff) | |
| download | chromium_src-97d052416394e439380cb932dfaed867e9db650b.zip chromium_src-97d052416394e439380cb932dfaed867e9db650b.tar.gz chromium_src-97d052416394e439380cb932dfaed867e9db650b.tar.bz2 | |
Revert r41459:
"Change Mac to DCHECK if NetworkChangeNotifier observer list is not empty by destruction time."
Apparently NetworkChangeNotifierMac's observers are still getting leaked in ExtensionApiTest.ShowPageActionPopup.
Review URL: http://codereview.chromium.org/871007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41464 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net')
| -rw-r--r-- | net/base/network_change_notifier_mac.h | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/net/base/network_change_notifier_mac.h b/net/base/network_change_notifier_mac.h index 01a491f..44d4806 100644 --- a/net/base/network_change_notifier_mac.h +++ b/net/base/network_change_notifier_mac.h @@ -51,7 +51,9 @@ class NetworkChangeNotifierMac : public NetworkChangeNotifier { // Receives the OS X network change notifications on this thread. scoped_ptr<base::Thread> notifier_thread_; - ObserverList<Observer, true> observers_; + // TODO(willchan): Fix the URLRequestContextGetter leaks and flip the false to + // true so we assert that all observers have been removed. + ObserverList<Observer, false> observers_; // Used to initialize the notifier thread. ScopedRunnableMethodFactory<NetworkChangeNotifierMac> method_factory_; |