diff options
| author | satish@chromium.org <satish@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-25 16:01:40 +0000 |
|---|---|---|
| committer | satish@chromium.org <satish@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-25 16:01:40 +0000 |
| commit | bea5da03c45dd6f9af65096203279ee3f51260af (patch) | |
| tree | 6ca17200a2f9246a92468b3bf12bf8911766f030 /net | |
| parent | a2fedb1e1311bc6acffabebc03e8dbca761b385e (diff) | |
| download | chromium_src-bea5da03c45dd6f9af65096203279ee3f51260af.zip chromium_src-bea5da03c45dd6f9af65096203279ee3f51260af.tar.gz chromium_src-bea5da03c45dd6f9af65096203279ee3f51260af.tar.bz2 | |
Use QuitTask instead of Quit() to signal request completion.
This allows for cases where the request complete callback is invoked outside a message loop,
for e.g. in TestPostChunkedDataAfterStart(). Quit() can only be invoked inside a message
loop whereas posting a QuitTask to the message loop can be done from anywhere.
BUG=none
TEST=TestPostChunkedDataAfterStart passes through the tsan bots and net_unittests in general runs fine.
Review URL: http://codereview.chromium.org/6329019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72493 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net')
| -rw-r--r-- | net/url_request/url_request_unittest.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/url_request/url_request_unittest.h b/net/url_request/url_request_unittest.h index f133015..030b59b 100644 --- a/net/url_request/url_request_unittest.h +++ b/net/url_request/url_request_unittest.h @@ -223,7 +223,7 @@ class TestDelegate : public net::URLRequest::Delegate { received_redirect_count_++; if (quit_on_redirect_) { *defer_redirect = true; - MessageLoop::current()->Quit(); + MessageLoop::current()->PostTask(FROM_HERE, new MessageLoop::QuitTask()); } else if (cancel_in_rr_) { request->Cancel(); } @@ -290,7 +290,7 @@ class TestDelegate : public net::URLRequest::Delegate { virtual void OnResponseCompleted(net::URLRequest* request) { if (quit_on_complete_) - MessageLoop::current()->Quit(); + MessageLoop::current()->PostTask(FROM_HERE, new MessageLoop::QuitTask()); } void OnAuthRequired(net::URLRequest* request, |