diff options
| author | wtc@chromium.org <wtc@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-11-15 20:57:56 +0000 |
|---|---|---|
| committer | wtc@chromium.org <wtc@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-11-15 20:57:56 +0000 |
| commit | 39183509b964fde4266147aa160328261535061f (patch) | |
| tree | 0475fc4524c572992564cfcb9f5605c45325e6db /net | |
| parent | d4142d2e00cd58cfdb8b9600c4058faf26f62220 (diff) | |
| download | chromium_src-39183509b964fde4266147aa160328261535061f.zip chromium_src-39183509b964fde4266147aa160328261535061f.tar.gz chromium_src-39183509b964fde4266147aa160328261535061f.tar.bz2 | |
Don't call base::ClosePlatformFile on a closed file handle.
This is a form of double free. On Windows. when running inside a
debugger, CloseHandle will throw an exception.
This problem was introduced in r166091
https://chromiumcodereview.appspot.com/10701050
R=pivanof@gmail.com,willchan@chromium.org
BUG=115067, 112474
TEST=net_unittests
Review URL: https://chromiumcodereview.appspot.com/11365275
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168025 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net')
| -rw-r--r-- | net/base/file_stream_unittest.cc | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/net/base/file_stream_unittest.cc b/net/base/file_stream_unittest.cc index 22d3427..e9307cd5 100644 --- a/net/base/file_stream_unittest.cc +++ b/net/base/file_stream_unittest.cc @@ -91,7 +91,6 @@ TEST_F(FileStreamTest, FileHandleNotLeftOpen) { base::PlatformFileInfo info; // The file should be closed. EXPECT_FALSE(base::GetPlatformFileInfo(file, &info)); - EXPECT_FALSE(base::ClosePlatformFile(file)); } // Test the use of FileStream with a file handle provided at construction. |