diff options
| author | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-03-08 23:53:17 +0000 |
|---|---|---|
| committer | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-03-08 23:53:17 +0000 |
| commit | 84727696d86ee57bb530e8d39579769953204483 (patch) | |
| tree | 77770fb7a9eace2dc2f7fa4739fc503f9e8374d7 /net | |
| parent | 97999ecce9a3cb5d6ce0fc2851b4695d27e5d124 (diff) | |
| download | chromium_src-84727696d86ee57bb530e8d39579769953204483.zip chromium_src-84727696d86ee57bb530e8d39579769953204483.tar.gz chromium_src-84727696d86ee57bb530e8d39579769953204483.tar.bz2 | |
SSL histograms did not use same buckets. Realign them.
SSL resume and full handshake histograms used max buckets of 1 minute.
SSL combined (resume+full) histograms used max buckets of 10 minutes.
This made analysis minorly annoying. Fix them. Looks like 1-10min buckets had
basically 0 samples. So rename the combined histograms and use max buckets of 1
minute.
Since the SPDY connection latencies are there too and they similarly have
little to no samples > 1 minute, rename that histogram and use max bucket of 1
minute. Note that it's also suffixed _2 to be consistent.
Renamed SSL_Connection_Latency to SSL_Connection_Latency_2 with the underscore
so I can keep the same basename "SSL_Connection_Latency" in the histograms.xml
histogram description file, with the same underscore separator for the combined
histogram and the full/resume handshake histograms.
BUG=181209
Review URL: https://chromiumcodereview.appspot.com/12710005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187082 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net')
| -rw-r--r-- | net/socket/ssl_client_socket_pool.cc | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/net/socket/ssl_client_socket_pool.cc b/net/socket/ssl_client_socket_pool.cc index 64ebf28..898df6e 100644 --- a/net/socket/ssl_client_socket_pool.cc +++ b/net/socket/ssl_client_socket_pool.cc @@ -322,17 +322,17 @@ int SSLConnectJob::DoSSLConnectComplete(int result) { base::TimeDelta connect_duration = connect_timing_.ssl_end - connect_timing_.ssl_start; if (using_spdy) { - UMA_HISTOGRAM_CUSTOM_TIMES("Net.SpdyConnectionLatency", + UMA_HISTOGRAM_CUSTOM_TIMES("Net.SpdyConnectionLatency_2", connect_duration, base::TimeDelta::FromMilliseconds(1), - base::TimeDelta::FromMinutes(10), + base::TimeDelta::FromMinutes(1), 100); } - UMA_HISTOGRAM_CUSTOM_TIMES("Net.SSL_Connection_Latency", + UMA_HISTOGRAM_CUSTOM_TIMES("Net.SSL_Connection_Latency_2", connect_duration, base::TimeDelta::FromMilliseconds(1), - base::TimeDelta::FromMinutes(10), + base::TimeDelta::FromMinutes(1), 100); SSLInfo ssl_info; @@ -357,10 +357,10 @@ int SSLConnectJob::DoSSLConnectComplete(int result) { (host.size() > 11 && host.rfind(".google.com") == host.size() - 11); if (is_google) { - UMA_HISTOGRAM_CUSTOM_TIMES("Net.SSL_Connection_Latency_Google", + UMA_HISTOGRAM_CUSTOM_TIMES("Net.SSL_Connection_Latency_Google2", connect_duration, base::TimeDelta::FromMilliseconds(1), - base::TimeDelta::FromMinutes(10), + base::TimeDelta::FromMinutes(1), 100); if (ssl_info.handshake_type == SSLInfo::HANDSHAKE_RESUME) { UMA_HISTOGRAM_CUSTOM_TIMES("Net.SSL_Connection_Latency_Google_" |