diff options
| author | erikwright@chromium.org <erikwright@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-07 16:51:24 +0000 |
|---|---|---|
| committer | erikwright@chromium.org <erikwright@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-07 16:51:24 +0000 |
| commit | 18a728de85cf6b020056f380d0e52eac52cb1983 (patch) | |
| tree | 1852c087dda35efe2a639bbc76ff89892b510281 /net | |
| parent | bd045d0d8f75020124a9da26442ca6a5e1f5fe70 (diff) | |
| download | chromium_src-18a728de85cf6b020056f380d0e52eac52cb1983.zip chromium_src-18a728de85cf6b020056f380d0e52eac52cb1983.tar.gz chromium_src-18a728de85cf6b020056f380d0e52eac52cb1983.tar.bz2 | |
Don't attempt to forward declare StringPiece.
1) This is discouraged because it prevents callers from benefiting from automatic coersion from string/char* types.
2) A follow-up CL (http://codereview.chromium.org/8659047/) will make StringPiece a template, and thus awkward to forward declare. The very small number of places that were appropriately forward declaring it do not justify writing a 'string_piece_forward.h'.
BUG=87634
R=willchan@chromium.org
Review URL: http://codereview.chromium.org/8817019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113404 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net')
| -rw-r--r-- | net/base/x509_cert_types.h | 2 | ||||
| -rw-r--r-- | net/base/x509_certificate.h | 1 | ||||
| -rw-r--r-- | net/socket/ssl_socket.h | 5 |
3 files changed, 2 insertions, 6 deletions
diff --git a/net/base/x509_cert_types.h b/net/base/x509_cert_types.h index ab91a8d..72cf58c 100644 --- a/net/base/x509_cert_types.h +++ b/net/base/x509_cert_types.h @@ -12,6 +12,7 @@ #include <string> #include <vector> +#include "base/string_piece.h" #include "build/build_config.h" #include "net/base/net_export.h" @@ -21,7 +22,6 @@ namespace base { class Time; -class StringPiece; } // namespace base namespace net { diff --git a/net/base/x509_certificate.h b/net/base/x509_certificate.h index 04d0b8e..6e155683 100644 --- a/net/base/x509_certificate.h +++ b/net/base/x509_certificate.h @@ -38,7 +38,6 @@ struct CERTCertificateStr; class Pickle; namespace crypto { -class StringPiece; class RSAPrivateKey; } // namespace crypto diff --git a/net/socket/ssl_socket.h b/net/socket/ssl_socket.h index 8445d7d..1291b46 100644 --- a/net/socket/ssl_socket.h +++ b/net/socket/ssl_socket.h @@ -6,12 +6,9 @@ #define NET_SOCKET_SSL_SOCKET_H_ #include "base/basictypes.h" +#include "base/string_piece.h" #include "net/socket/stream_socket.h" -namespace base { -class StringPiece; -} // namespace base - namespace net { // SSLSocket interface defines method that are common between client |