summaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorwillchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-04-10 16:57:06 +0000
committerwillchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-04-10 16:57:06 +0000
commit5d456c5cf9732f4bc7556c86ad278c25333913c1 (patch)
tree0196645deef8338c13aadfc4f8b170f952958f68 /net
parent55c43f3e365e664e65d89086ddea07d94066ff19 (diff)
downloadchromium_src-5d456c5cf9732f4bc7556c86ad278c25333913c1.zip
chromium_src-5d456c5cf9732f4bc7556c86ad278c25333913c1.tar.gz
chromium_src-5d456c5cf9732f4bc7556c86ad278c25333913c1.tar.bz2
Remove unnecessary references to URLRequestContext.
The actual URLRequestContext used by the Chromium embedder here is the "proxy script fetcher" URLRequestContext. It is owned by the browser process's IOThread. Therefore, there's no need to refcount it within objects owned by the ProxyService of that URLRequestContext. BUG=58859 TEST=none Review URL: http://codereview.chromium.org/10024019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131562 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net')
-rw-r--r--net/proxy/dhcp_proxy_script_adapter_fetcher_win.cc4
-rw-r--r--net/proxy/dhcp_proxy_script_adapter_fetcher_win.h4
-rw-r--r--net/proxy/dhcp_proxy_script_fetcher.h4
-rw-r--r--net/proxy/dhcp_proxy_script_fetcher_factory.h4
-rw-r--r--net/proxy/dhcp_proxy_script_fetcher_win.h4
5 files changed, 11 insertions, 9 deletions
diff --git a/net/proxy/dhcp_proxy_script_adapter_fetcher_win.cc b/net/proxy/dhcp_proxy_script_adapter_fetcher_win.cc
index 660b49f..ed77893 100644
--- a/net/proxy/dhcp_proxy_script_adapter_fetcher_win.cc
+++ b/net/proxy/dhcp_proxy_script_adapter_fetcher_win.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -6,6 +6,7 @@
#include "base/bind.h"
#include "base/bind_helpers.h"
+#include "base/logging.h"
#include "base/message_loop_proxy.h"
#include "base/metrics/histogram.h"
#include "base/sys_string_conversions.h"
@@ -35,6 +36,7 @@ DhcpProxyScriptAdapterFetcher::DhcpProxyScriptAdapterFetcher(
: state_(STATE_START),
result_(ERR_IO_PENDING),
url_request_context_(url_request_context) {
+ DCHECK(url_request_context_);
}
DhcpProxyScriptAdapterFetcher::~DhcpProxyScriptAdapterFetcher() {
diff --git a/net/proxy/dhcp_proxy_script_adapter_fetcher_win.h b/net/proxy/dhcp_proxy_script_adapter_fetcher_win.h
index 54954fc..554f528 100644
--- a/net/proxy/dhcp_proxy_script_adapter_fetcher_win.h
+++ b/net/proxy/dhcp_proxy_script_adapter_fetcher_win.h
@@ -1,4 +1,4 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -167,7 +167,7 @@ class NET_EXPORT_PRIVATE DhcpProxyScriptAdapterFetcher
// Implements a timeout on the call to the Win32 DHCP API.
base::OneShotTimer<DhcpProxyScriptAdapterFetcher> wait_timer_;
- scoped_refptr<URLRequestContext> url_request_context_;
+ URLRequestContext* const url_request_context_;
DISALLOW_IMPLICIT_CONSTRUCTORS(DhcpProxyScriptAdapterFetcher);
};
diff --git a/net/proxy/dhcp_proxy_script_fetcher.h b/net/proxy/dhcp_proxy_script_fetcher.h
index 101ddff..df67662 100644
--- a/net/proxy/dhcp_proxy_script_fetcher.h
+++ b/net/proxy/dhcp_proxy_script_fetcher.h
@@ -1,4 +1,4 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -9,10 +9,10 @@
#include "base/basictypes.h"
#include "base/compiler_specific.h"
#include "base/string16.h"
+#include "googleurl/src/gurl.h"
#include "net/base/completion_callback.h"
#include "net/base/net_export.h"
#include "net/proxy/proxy_script_fetcher.h"
-#include "net/url_request/url_request_context.h"
namespace net {
diff --git a/net/proxy/dhcp_proxy_script_fetcher_factory.h b/net/proxy/dhcp_proxy_script_fetcher_factory.h
index f234a73..4301768 100644
--- a/net/proxy/dhcp_proxy_script_fetcher_factory.h
+++ b/net/proxy/dhcp_proxy_script_fetcher_factory.h
@@ -1,4 +1,4 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -10,11 +10,11 @@
#include "base/memory/singleton.h"
#include "net/base/completion_callback.h"
#include "net/base/net_export.h"
-#include "net/url_request/url_request_context.h"
namespace net {
class DhcpProxyScriptFetcher;
+class URLRequestContext;
// Factory object for creating the appropriate concrete base class of
// DhcpProxyScriptFetcher for your operating system and settings.
diff --git a/net/proxy/dhcp_proxy_script_fetcher_win.h b/net/proxy/dhcp_proxy_script_fetcher_win.h
index ce6c7dc..c6085e9 100644
--- a/net/proxy/dhcp_proxy_script_fetcher_win.h
+++ b/net/proxy/dhcp_proxy_script_fetcher_win.h
@@ -1,4 +1,4 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -154,7 +154,7 @@ class NET_EXPORT_PRIVATE DhcpProxyScriptFetcherWin
base::OneShotTimer<DhcpProxyScriptFetcherWin> wait_timer_;
- scoped_refptr<URLRequestContext> url_request_context_;
+ URLRequestContext* const url_request_context_;
// NULL or the AdapterQuery currently in flight.
scoped_refptr<AdapterQuery> last_query_;