summaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorgavinp@chromium.org <gavinp@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-03-25 21:21:29 +0000
committergavinp@chromium.org <gavinp@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-03-25 21:21:29 +0000
commit62f826a653e610583a727df87050c3f6b72a0a66 (patch)
treeb6a7332fa75ff523d7965b946841dcf20714f186 /net
parent95a39c850bc250fcfd9f6bbbe446f964958b9106 (diff)
downloadchromium_src-62f826a653e610583a727df87050c3f6b72a0a66.zip
chromium_src-62f826a653e610583a727df87050c3f6b72a0a66.tar.gz
chromium_src-62f826a653e610583a727df87050c3f6b72a0a66.tar.bz2
Remove the Throttling.HttpResponseCode histogram.
The experiment is over, let's get rid of the (big) histogram. BUG=None Review URL: http://codereview.chromium.org/9826043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128831 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net')
-rw-r--r--net/url_request/url_request_throttler_entry.cc8
-rw-r--r--net/url_request/url_request_throttler_unittest.cc5
2 files changed, 2 insertions, 11 deletions
diff --git a/net/url_request/url_request_throttler_entry.cc b/net/url_request/url_request_throttler_entry.cc
index 3c608c0..3ef2db0 100644
--- a/net/url_request/url_request_throttler_entry.cc
+++ b/net/url_request/url_request_throttler_entry.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -380,12 +380,6 @@ void URLRequestThrottlerEntry::HandleThrottlingHeader(
}
void URLRequestThrottlerEntry::HandleMetricsTracking(int response_code) {
- // This is essentially the same as the "Net.HttpResponseCode" UMA stat
- // but we are tracking it separately here for the throttling experiment
- // to make sure we count only the responses seen by throttling.
- // TODO(joi): Remove after experiment.
- UMA_HISTOGRAM_ENUMERATION("Throttling.HttpResponseCode", response_code, 600);
-
// Note that we are not interested in whether the code is considered
// an error for the backoff logic, but whether it is a 5xx error in
// general. This is because here, we are tracking the apparent total
diff --git a/net/url_request/url_request_throttler_unittest.cc b/net/url_request/url_request_throttler_unittest.cc
index 4c8f492..8ea46b0 100644
--- a/net/url_request/url_request_throttler_unittest.cc
+++ b/net/url_request/url_request_throttler_unittest.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -182,7 +182,6 @@ class URLRequestThrottlerEntryTest : public testing::Test {
const char* kHistogramNames[] = {
"Throttling.CustomRetryAfterMs",
"Throttling.FailureCountAtSuccess",
- "Throttling.HttpResponseCode",
"Throttling.PerceivedDowntime",
"Throttling.RequestThrottled",
"Throttling.SiteOptedOut",
@@ -300,8 +299,6 @@ TEST_F(URLRequestThrottlerEntryTest, InterfaceUpdateSuccessThenFailure) {
entry_->UpdateWithResponse("", &success_response);
CalculateHistogramDeltas();
- ASSERT_EQ(1, samples_["Throttling.HttpResponseCode"].counts(503));
- ASSERT_EQ(2, samples_["Throttling.HttpResponseCode"].counts(200));
ASSERT_EQ(1, samples_["Throttling.FailureCountAtSuccess"].counts(1));
ASSERT_EQ(1, samples_["Throttling.PerceivedDowntime"].TotalCount());
}