diff options
| author | mirandac@google.com <mirandac@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-20 23:44:09 +0000 |
|---|---|---|
| committer | mirandac@google.com <mirandac@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-20 23:44:09 +0000 |
| commit | 8b8114e419cde13c91f35dee70e821c3d1048fde (patch) | |
| tree | f0a7d9ac6e445a3a241a0d309c48877634431c58 /net | |
| parent | 717d9d19e8a95c72ff6952b1f89c174a21fc2468 (diff) | |
| download | chromium_src-8b8114e419cde13c91f35dee70e821c3d1048fde.zip chromium_src-8b8114e419cde13c91f35dee70e821c3d1048fde.tar.gz chromium_src-8b8114e419cde13c91f35dee70e821c3d1048fde.tar.bz2 | |
Speculative fix for blank status bubble.
Fixes a codepath which could possibly lead to an empty status bubble. I haven't been able to repro, but calling SetText instead of SetTextAndAnimate looks like the one spot that doesn't check for an empty string before displaying. Eliminating this loophole by consolidating into a single method, SetText, that always triggers the "hide" animation on an empty string, and only triggers animate if |should_animate| is set. This is actually closer to the SetText method before I added the status bubble expansion code.
BUG=43640
TEST=no more empty link target bubbles floating on the screen.
Review URL: http://codereview.chromium.org/2111013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47863 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net')
0 files changed, 0 insertions, 0 deletions