diff options
author | bulach@chromium.org <bulach@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-05 11:34:47 +0000 |
---|---|---|
committer | bulach@chromium.org <bulach@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-05 11:34:47 +0000 |
commit | 1e71d3071d7fbe324fb9ede296441aaf884f8d66 (patch) | |
tree | a6770338efa2b4b4c0872ef0a1e3fee40a1300ae /net | |
parent | b63efe1d971ef90da5b674adbbd08b5907b8934e (diff) | |
download | chromium_src-1e71d3071d7fbe324fb9ede296441aaf884f8d66.zip chromium_src-1e71d3071d7fbe324fb9ede296441aaf884f8d66.tar.gz chromium_src-1e71d3071d7fbe324fb9ede296441aaf884f8d66.tar.bz2 |
Fixes for OpenSSL
A couple of nit fixes following:
+ http://codereview.chromium.org/7247005
+ http://codereview.chromium.org/6990036
+ Fixes a typo (ctx / context)
+ Adds new abstract methods from stream_socket.h
BUG=
TEST=
Review URL: http://codereview.chromium.org/7253038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91498 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net')
-rw-r--r-- | net/base/cert_database_openssl.cc | 3 | ||||
-rw-r--r-- | net/socket/ssl_client_socket_openssl.cc | 16 | ||||
-rw-r--r-- | net/socket/ssl_client_socket_openssl.h | 2 |
3 files changed, 20 insertions, 1 deletions
diff --git a/net/base/cert_database_openssl.cc b/net/base/cert_database_openssl.cc index 01ac118..333d04c 100644 --- a/net/base/cert_database_openssl.cc +++ b/net/base/cert_database_openssl.cc @@ -61,7 +61,8 @@ void CertDatabase::ListModules(CryptoModuleList* modules, bool need_rw) const { int CertDatabase::ImportFromPKCS12(CryptoModule* module, const std::string& data, - const string16& password) { + const string16& password, + bool is_extractable) { // TODO(bulach): implement me. NOTIMPLEMENTED(); return ERR_NOT_IMPLEMENTED; diff --git a/net/socket/ssl_client_socket_openssl.cc b/net/socket/ssl_client_socket_openssl.cc index 92abf46..3e25e2b 100644 --- a/net/socket/ssl_client_socket_openssl.cc +++ b/net/socket/ssl_client_socket_openssl.cc @@ -1094,6 +1094,22 @@ bool SSLClientSocketOpenSSL::UsingTCPFastOpen() const { return false; } +int64 SSLClientSocketOpenSSL::NumBytesRead() const { + if (transport_.get() && transport_->socket()) + return transport_->socket()->NumBytesRead(); + + NOTREACHED(); + return -1; +} + +base::TimeDelta SSLClientSocketOpenSSL::GetConnectTimeMicros() const { + if (transport_.get() && transport_->socket()) + return transport_->socket()->GetConnectTimeMicros(); + + NOTREACHED(); + return base::TimeDelta::FromMicroseconds(-1); +} + // Socket methods int SSLClientSocketOpenSSL::Read(IOBuffer* buf, diff --git a/net/socket/ssl_client_socket_openssl.h b/net/socket/ssl_client_socket_openssl.h index a3e6db9..1dcfe0080 100644 --- a/net/socket/ssl_client_socket_openssl.h +++ b/net/socket/ssl_client_socket_openssl.h @@ -69,6 +69,8 @@ class SSLClientSocketOpenSSL : public SSLClientSocket { virtual void SetOmniboxSpeculation(); virtual bool WasEverUsed() const; virtual bool UsingTCPFastOpen() const; + virtual int64 NumBytesRead() const; + virtual base::TimeDelta GetConnectTimeMicros() const; // Socket methods: virtual int Read(IOBuffer* buf, int buf_len, CompletionCallback* callback); |