Add a comment to document that we don't know if a nonblocking

connect will ever return 0, and therefore we don't know if the
event object will be signaled in that case.

R=rvargas
http://crbug.com/9258
TEST=N/A
Review URL: http://codereview.chromium.org/113474

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16171 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 11 insertions, 0 deletions

diff --git a/net/base/tcp_client_socket_win.cc b/net/base/tcp_client_socket_win.cc
index a3c0d03..7151aca 100644
--- a/net/base/tcp_client_socket_win.cc
+++ b/net/base/tcp_client_socket_win.cc
@@ -250,6 +250,17 @@ int TCPClientSocketWin::Connect(CompletionCallback* callback) {
 
   if (!connect(socket_, ai->ai_addr, static_cast<int>(ai->ai_addrlen))) {
     // Connected without waiting!
+    //
+    // The MSDN page for connect says:
+    //   With a nonblocking socket, the connection attempt cannot be completed
+    //   immediately. In this case, connect will return SOCKET_ERROR, and
+    //   WSAGetLastError will return WSAEWOULDBLOCK.
+    // which implies that for a nonblocking socket, connect never returns 0.
+    // It's not documented whether the event object will be signaled or not
+    // if connect does return 0.  So the code below is essentially dead code
+    // and we don't know if it's correct.
+    NOTREACHED();
+
     if (ResetEventIfSignaled(core_->read_overlapped_.hEvent)) {
       TRACE_EVENT_END("socket.connect", this, "");
       return OK;