Disable NetworkChangeNotifierMac's helper thread.

This is so I can determine if r38052 caused the mac startup test regression.
This will disable the Mac implementation of NetworkChangeNotifier, which was implemented in January and is used by the ClientSocketPool to flush idle sockets on a network change.
r38052 added it to the HostResolver to flush the HostCache on a network change, which required instantiating NetworkChangeNotifierMac earlier in startup.
This change will prevent the initialization of the helper thread, which will turn off network change notifications on OS X.  This is a relatively new feature, so it's fine to turn this off.  I'll let this change sit overnight and check on the startup graphs tomorrow.
BUG=34926

Review URL: http://codereview.chromium.org/583015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38418 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 8 insertions, 6 deletions

diff --git a/net/base/network_change_notifier_mac.cc b/net/base/network_change_notifier_mac.cc
index 5606210..f0583db 100644
--- a/net/base/network_change_notifier_mac.cc
+++ b/net/base/network_change_notifier_mac.cc
@@ -218,12 +218,14 @@ void NetworkChangeNotifierThread::Init() {
 }  // namespace
 
 NetworkChangeNotifierMac::NetworkChangeNotifierMac()
-    : notifier_thread_(
-          new NetworkChangeNotifierThread(MessageLoop::current(), this)) {
-  base::Thread::Options thread_options;
-  thread_options.message_loop_type = MessageLoop::TYPE_UI;
-  notifier_thread_->StartWithOptions(thread_options);
-}
+// http://crbug.com/34926: This might be slowing down Mac startup.  Disable the
+// helper thread to see if that improves mac startup times.
+//    : notifier_thread_(
+//          new NetworkChangeNotifierThread(MessageLoop::current(), this)) {
+//  base::Thread::Options thread_options;
+//  thread_options.message_loop_type = MessageLoop::TYPE_UI;
+//  notifier_thread_->StartWithOptions(thread_options);
+      : notifier_thread_(NULL) {}
 
 NetworkChangeNotifierMac::~NetworkChangeNotifierMac() {}