diff options
author | agl@chromium.org <agl@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-15 17:27:11 +0000 |
---|---|---|
committer | agl@chromium.org <agl@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-15 17:27:11 +0000 |
commit | 7e7989bdf42a6fc3dad7348e2a39a96dfcb6b929 (patch) | |
tree | 7aa13c602c8ec1c81190477a80b696993f2bc6c1 /net | |
parent | 5097dc8cf47eb60b3284db2ccf3c1e645c6d8b7b (diff) | |
download | chromium_src-7e7989bdf42a6fc3dad7348e2a39a96dfcb6b929.zip chromium_src-7e7989bdf42a6fc3dad7348e2a39a96dfcb6b929.tar.gz chromium_src-7e7989bdf42a6fc3dad7348e2a39a96dfcb6b929.tar.bz2 |
net: add comments
This is a follow up change to add some requested comments from r52079's review.
TEST=none
BUG=27507
http://codereview.chromium.org/2943001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52497 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net')
-rw-r--r-- | net/base/ssl_connection_status_flags.h | 6 | ||||
-rw-r--r-- | net/base/ssl_info.h | 6 |
2 files changed, 9 insertions, 3 deletions
diff --git a/net/base/ssl_connection_status_flags.h b/net/base/ssl_connection_status_flags.h index 2618f57..9c2d56a 100644 --- a/net/base/ssl_connection_status_flags.h +++ b/net/base/ssl_connection_status_flags.h @@ -19,7 +19,11 @@ enum { // We fell back to SSLv3 for this connection. SSL_CONNECTION_SSL3_FALLBACK = 1 << 18, - // The server doesn't support the renegotiation_info extension. + + // The server doesn't support the renegotiation_info extension. If this bit + // is not set then either the extension isn't supported, or we don't have any + // knowledge either way. (The latter case will occur when we use an SSL + // library that doesn't report it, like SChannel.) SSL_CONNECTION_NO_RENEGOTIATION_EXTENSION = 1 << 19, // 1 << 31 (the sign bit) is reserved so that the SSL connection status will diff --git a/net/base/ssl_info.h b/net/base/ssl_info.h index 280b497..7c14163 100644 --- a/net/base/ssl_info.h +++ b/net/base/ssl_info.h @@ -45,8 +45,10 @@ class SSLInfo { // -1 means the security strength is unknown. int security_bits; - // Bitmask of information about the SSL connection itself. See - // ssl_connection_status_flags.h for values. + // Information about the SSL connection itself. See + // ssl_connection_status_flags.h for values. The ciphersuite and compression + // in use are encoded within. + // TODO(agl): also encode the protocol version used. int connection_status; }; |