diff options
| author | wtc@chromium.org <wtc@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-02-11 01:01:29 +0000 |
|---|---|---|
| committer | wtc@chromium.org <wtc@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-02-11 01:01:29 +0000 |
| commit | 3f62ae997ad4ca5c6b8e4b797e8814cab74b0349 (patch) | |
| tree | 9dd1e3f48e0aa31a2848428a347fa91c92a0fe3f /net | |
| parent | 0f44f96056935ebe5c79920c48be70ada5d15166 (diff) | |
| download | chromium_src-3f62ae997ad4ca5c6b8e4b797e8814cab74b0349.zip chromium_src-3f62ae997ad4ca5c6b8e4b797e8814cab74b0349.tar.gz chromium_src-3f62ae997ad4ca5c6b8e4b797e8814cab74b0349.tar.bz2 | |
Fix Coverity PASS_BY_VALUE defect in SdchManager::Dictionary::CanSet.
R=jar
CID=14718
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6493001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74539 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net')
| -rw-r--r-- | net/base/sdch_manager.cc | 2 | ||||
| -rw-r--r-- | net/base/sdch_manager.h | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/net/base/sdch_manager.cc b/net/base/sdch_manager.cc index 354f87d..4d99426 100644 --- a/net/base/sdch_manager.cc +++ b/net/base/sdch_manager.cc @@ -80,7 +80,7 @@ bool SdchManager::Dictionary::CanAdvertise(const GURL& target_url) { // static bool SdchManager::Dictionary::CanSet(const std::string& domain, const std::string& path, - const std::set<int> ports, + const std::set<int>& ports, const GURL& dictionary_url) { if (!SdchManager::Global()->IsInSupportedDomain(dictionary_url)) return false; diff --git a/net/base/sdch_manager.h b/net/base/sdch_manager.h index a07ab9d..b37e4ad 100644 --- a/net/base/sdch_manager.h +++ b/net/base/sdch_manager.h @@ -194,7 +194,7 @@ class SdchManager { // Security methods to check if we can establish a new dictionary with the // given data, that arrived in response to get of dictionary_url. static bool CanSet(const std::string& domain, const std::string& path, - const std::set<int> ports, const GURL& dictionary_url); + const std::set<int>& ports, const GURL& dictionary_url); // Security method to check if we can use a dictionary to decompress a // target that arrived with a reference to this dictionary. |