diff options
| author | chase@chromium.org <chase@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-11 05:07:59 +0000 |
|---|---|---|
| committer | chase@chromium.org <chase@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-11 05:07:59 +0000 |
| commit | 7e922f33d88905196067d901a14910a62c48ac21 (patch) | |
| tree | f0c61469ce9207f3582779c191bc8b880103a22f /net | |
| parent | a210fefe3ce45708ec4cb66fa8f96d250602a9d9 (diff) | |
| download | chromium_src-7e922f33d88905196067d901a14910a62c48ac21.zip chromium_src-7e922f33d88905196067d901a14910a62c48ac21.tar.gz chromium_src-7e922f33d88905196067d901a14910a62c48ac21.tar.bz2 | |
Add a NOTREACHED() to catch users of pre-release NSS.
Catch a crash for debug build users who followed the
Linux 64bit instructions.
BUG=21454
TEST=debug chrome crashes at NOTREACHED in error
condition using old NSS, skips past in new NSS and
under both conditions in release builds.
Review URL: http://codereview.chromium.org/201086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25969 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net')
| -rw-r--r-- | net/base/x509_certificate_nss.cc | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/net/base/x509_certificate_nss.cc b/net/base/x509_certificate_nss.cc index fd52608..a018dc0 100644 --- a/net/base/x509_certificate_nss.cc +++ b/net/base/x509_certificate_nss.cc @@ -178,6 +178,11 @@ int MapCertErrorToCertStatus(int err) { // contain the root CA certificate. void GetCertChainInfo(CERTCertList* cert_list, CertVerifyResult* verify_result) { + // NOTE: Using a NSS library before 3.12.3.1 will crash below. To see the + // NSS version currently in use: + // 1. use ldd on the chrome executable for NSS's location (ie. libnss3.so*) + // 2. use ident libnss3.so* for the library's version + DCHECK(cert_list); int i = 0; for (CERTCertListNode* node = CERT_LIST_HEAD(cert_list); !CERT_LIST_END(node, cert_list); |