diff options
| author | cbentzel@chromium.org <cbentzel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-14 18:47:17 +0000 |
|---|---|---|
| committer | cbentzel@chromium.org <cbentzel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-14 18:47:17 +0000 |
| commit | 87d81e7a460bad6a4430eae5a9ccc44b9303447d (patch) | |
| tree | e07153ed5f55242776106be10c3c8c52f80a464b /net | |
| parent | d4b7202da6d6813152bfa905531297d330409a58 (diff) | |
| download | chromium_src-87d81e7a460bad6a4430eae5a9ccc44b9303447d.zip chromium_src-87d81e7a460bad6a4430eae5a9ccc44b9303447d.tar.gz chromium_src-87d81e7a460bad6a4430eae5a9ccc44b9303447d.tar.bz2 | |
Make Run methods non-virtual on RRResolverWorker.
The goal is to turn on -Wnon-virtual-dtor warning for gcc. In this case, the virtual Run()'s do not appear necessary,
especially since they are private. If intended to be derived from, there is a "delete this" in the base class which would
point to requiring a virtual destructor.
BUG=45135
TEST=Target builds, validated that there are no derived classes of RRResolverWorker.
Review URL: http://codereview.chromium.org/3824002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62605 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net')
| -rw-r--r-- | net/base/dnsrr_resolver.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/base/dnsrr_resolver.cc b/net/base/dnsrr_resolver.cc index 448ed9d..b4c361f 100644 --- a/net/base/dnsrr_resolver.cc +++ b/net/base/dnsrr_resolver.cc @@ -160,7 +160,7 @@ class RRResolverWorker { #if defined(OS_POSIX) - virtual void Run() { + void Run() { // Runs on a worker thread. if (HandleTestCases()) { @@ -235,7 +235,7 @@ class RRResolverWorker { #else // OS_WIN - virtual void Run() { + void Run() { if (HandleTestCases()) { Finish(); return; |