diff options
| author | yusukes@google.com <yusukes@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-17 03:14:12 +0000 |
|---|---|---|
| committer | yusukes@google.com <yusukes@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-17 03:14:12 +0000 |
| commit | a87e9acee988e8136b3ff74a8d5dda7047565308 (patch) | |
| tree | d0350b0b1e3de0e2597f5e3aba751a256514d03e /net | |
| parent | 1ff3c23680621228ea756e1acde0ede0f5baabbb (diff) | |
| download | chromium_src-a87e9acee988e8136b3ff74a8d5dda7047565308.zip chromium_src-a87e9acee988e8136b3ff74a8d5dda7047565308.tar.gz chromium_src-a87e9acee988e8136b3ff74a8d5dda7047565308.tar.bz2 | |
Do not write a profile path on a BookmarkDragData object since a dragged url (javascript:...) on a web page does not belong to (the profile's) bookmark model.
Currently the following function returns DRAG_NONE and thus the drop operation is not accepted. The reason for the return value is because ops becomes DragDropTypes::DRAG_MOVE (since data.profile_path_ is not empty()) but event.GetSourceOperations() returns DragDropTypes::DRAG_COPY | DragDropTypes::DRAG_LINK.
int BookmarkBarView::CalculateDropOperation(const DropTargetEvent& event,
...
int ops = data.GetFirstNode(profile_)
? DragDropTypes::DRAG_MOVE
: DragDropTypes::DRAG_COPY | DragDropTypes::DRAG_LINK;
return bookmark_utils::PreferredDropOperation(event.GetSourceOperations(),
ops);
BUG=12290
TEST=Open http://delicious.com/help/bookmarklets page and drag the "Bookmark on Delicious" link on "Google Chrome" section to the bookmark bar.
Review URL: http://codereview.chromium.org/125111
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18584 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net')
0 files changed, 0 insertions, 0 deletions