diff options
| author | mmenke@chromium.org <mmenke@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-12 17:38:16 +0000 |
|---|---|---|
| committer | mmenke@chromium.org <mmenke@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-12 17:38:16 +0000 |
| commit | d2cbfbecea747a8f122acddda8075bcf7ba9b53e (patch) | |
| tree | afc07994409290f7ca0436130999af32481a518e /net | |
| parent | 10987f444135ee7a7eb014972f305f6cde90ac97 (diff) | |
| download | chromium_src-d2cbfbecea747a8f122acddda8075bcf7ba9b53e.zip chromium_src-d2cbfbecea747a8f122acddda8075bcf7ba9b53e.tar.gz chromium_src-d2cbfbecea747a8f122acddda8075bcf7ba9b53e.tar.bz2 | |
Net-internal's Javascript code no longer requires all enties have a unique source id. It will assign entries with a source type of NONE their own unique negative id, which will never be displayed.
Also, the id column in the Requests tab is now right-aligned.
BUG= 48806
TEST= Run chromium while your ip address changes.
Alternatively, add the following code to
ConnectJob::LogConnectStart(), or somewhere else
that looks promising:
net_log().net_log()->AddEntry(net::NetLog::TYPE_NETWORK_IP_ADDRESSSES_CHANGED,
base::TimeTicks::Now(),
net::NetLog::Source(),
net::NetLog::PHASE_NONE,
NULL);
Review URL: http://codereview.chromium.org/2883061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55900 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net')
| -rw-r--r-- | net/base/forwarding_net_log.cc | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/net/base/forwarding_net_log.cc b/net/base/forwarding_net_log.cc index 6cea529..dfc8700 100644 --- a/net/base/forwarding_net_log.cc +++ b/net/base/forwarding_net_log.cc @@ -56,12 +56,7 @@ class ForwardingNetLog::Core DCHECK_EQ(MessageLoop::current(), loop_); - // TODO(eroman): This shouldn't be necessary. See crbug.com/48806. - NetLog::Source effective_source = source; - if (effective_source.id == NetLog::Source::kInvalidId) - effective_source.id = impl_->NextID(); - - impl_->AddEntry(type, time, effective_source, phase, params); + impl_->AddEntry(type, time, source, phase, params); } Lock lock_; |