diff options
| author | kinaba@chromium.org <kinaba@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-07-05 11:36:20 +0000 |
|---|---|---|
| committer | kinaba@chromium.org <kinaba@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-07-05 11:36:20 +0000 |
| commit | dfbd0183d65fcc671ff87baad45e365403ee3cec (patch) | |
| tree | ff650560a08cfca4287a4776392d40d287d7d901 /net | |
| parent | 9fb47a8c6dd8d83401d6d4095a6bad36e368a957 (diff) | |
| download | chromium_src-dfbd0183d65fcc671ff87baad45e365403ee3cec.zip chromium_src-dfbd0183d65fcc671ff87baad45e365403ee3cec.tar.gz chromium_src-dfbd0183d65fcc671ff87baad45e365403ee3cec.tar.bz2 | |
Tiny comment fix for removing ambiguity.
This is an after care patch for https://codereview.chromium.org/18033003/#msg9.
BUG=256109
TBR=wtc@chromium.org
Review URL: https://chromiumcodereview.appspot.com/18743002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210293 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net')
| -rw-r--r-- | net/url_request/url_fetcher_core.cc | 15 |
1 files changed, 8 insertions, 7 deletions
diff --git a/net/url_request/url_fetcher_core.cc b/net/url_request/url_fetcher_core.cc index 87cce4f..8f0e28d 100644 --- a/net/url_request/url_fetcher_core.cc +++ b/net/url_request/url_fetcher_core.cc @@ -358,14 +358,15 @@ bool URLFetcherCore::GetResponseAsFilePath(bool take_ownership, *out_response_path = file_writer_->file_path(); if (take_ownership) { - // Intentionally calling file_writer_ method directly without posting the - // task to network_task_runner_. + // Intentionally calling a file_writer_ method directly without posting + // the task to network_task_runner_. // - // This is for correctly handling the case when DisownFile() is soon - // followed by Stop(). We have to make sure that DisownFile takes effect - // before Stop is executed and thus file_writer_ is deleted. - // This should be thread-safe since file_writer_->DisownFile itself does no - // file operation, it just flips the state to be referred in destruction. + // This is for correctly handling the case when file_writer_->DisownFile() + // is soon followed by URLFetcherCore::Stop(). We have to make sure that + // DisownFile takes effect before Stop deletes file_writer_. + // + // This direct call should be thread-safe, since DisownFile itself does no + // file operation. It just flips the state to be referred in destruction. file_writer_->DisownFile(); } return true; |