diff options
author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-08-07 16:53:01 +0000 |
---|---|---|
committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-08-07 16:53:01 +0000 |
commit | b7a95ad6f584b029954c3b398993f49f1d69265e (patch) | |
tree | b347103c4e6a38c47f3e393cb86a987339b57e3e /net | |
parent | 9f2bf3cadda3d432bafbf7eeb20fbcda22ad596d (diff) | |
download | chromium_src-b7a95ad6f584b029954c3b398993f49f1d69265e.zip chromium_src-b7a95ad6f584b029954c3b398993f49f1d69265e.tar.gz chromium_src-b7a95ad6f584b029954c3b398993f49f1d69265e.tar.bz2 |
Remove wstring file path helpers from test_file_util.
These were only used by one test file, so I moved the implementation there. I
considered updating the test, but the way the test uses wstrings seems
reasonable.
R=rvargas@chromium.org, rvargas
Review URL: https://codereview.chromium.org/448763003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288084 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net')
-rw-r--r-- | net/base/filename_util_unittest.cc | 25 |
1 files changed, 20 insertions, 5 deletions
diff --git a/net/base/filename_util_unittest.cc b/net/base/filename_util_unittest.cc index 0bd2250..bc726a2 100644 --- a/net/base/filename_util_unittest.cc +++ b/net/base/filename_util_unittest.cc @@ -32,14 +32,29 @@ struct GenerateFilenameCase { const wchar_t* expected_filename; }; +// The expected filenames are coded as wchar_t for convenience. +std::wstring FilePathAsWString(const base::FilePath& path) { +#if defined(OS_WIN) + return path.value(); +#else + return base::UTF8ToWide(path.value()); +#endif +} +base::FilePath WStringAsFilePath(const std::wstring& str) { +#if defined(OS_WIN) + return base::FilePath(str); +#else + return base::FilePath(base::WideToUTF8(str)); +#endif +} + void RunGenerateFileNameTestCase(const GenerateFilenameCase* test_case) { std::string default_filename(base::WideToUTF8(test_case->default_filename)); base::FilePath file_path = GenerateFileName( GURL(test_case->url), test_case->content_disp_header, test_case->referrer_charset, test_case->suggested_filename, test_case->mime_type, default_filename); - EXPECT_EQ(test_case->expected_filename, - file_util::FilePathAsWString(file_path)) + EXPECT_EQ(test_case->expected_filename, FilePathAsWString(file_path)) << "test case at line number: " << test_case->lineno; } @@ -171,12 +186,12 @@ TEST(FilenameUtilTest, FileURLConversion) { for (size_t i = 0; i < ARRAYSIZE_UNSAFE(round_trip_cases); i++) { // convert to the file URL GURL file_url(FilePathToFileURL( - file_util::WStringAsFilePath(round_trip_cases[i].file))); + WStringAsFilePath(round_trip_cases[i].file))); EXPECT_EQ(round_trip_cases[i].url, file_url.spec()); // Back to the filename. EXPECT_TRUE(FileURLToFilePath(file_url, &output)); - EXPECT_EQ(round_trip_cases[i].file, file_util::FilePathAsWString(output)); + EXPECT_EQ(round_trip_cases[i].file, FilePathAsWString(output)); } // Test that various file: URLs get decoded into the correct file type @@ -215,7 +230,7 @@ TEST(FilenameUtilTest, FileURLConversion) { }; for (size_t i = 0; i < ARRAYSIZE_UNSAFE(url_cases); i++) { FileURLToFilePath(GURL(url_cases[i].url), &output); - EXPECT_EQ(url_cases[i].file, file_util::FilePathAsWString(output)); + EXPECT_EQ(url_cases[i].file, FilePathAsWString(output)); } // Unfortunately, UTF8ToWide discards invalid UTF8 input. |