summaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorrsleevi@chromium.org <rsleevi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-11-04 20:35:00 +0000
committerrsleevi@chromium.org <rsleevi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-11-04 20:35:00 +0000
commit3c2a5995a7617e76c029a6fb4bf0a4821ffe86c7 (patch)
treef8470c69a880e8ccfd90bed3674d2c4c3c176188 /net
parent0ba9f7fca7a6627014954f95afdc6f5df0a6e03f (diff)
downloadchromium_src-3c2a5995a7617e76c029a6fb4bf0a4821ffe86c7.zip
chromium_src-3c2a5995a7617e76c029a6fb4bf0a4821ffe86c7.tar.gz
chromium_src-3c2a5995a7617e76c029a6fb4bf0a4821ffe86c7.tar.bz2
Log more descriptive certificate error messages on Mac.
BUG=none Review URL: http://codereview.chromium.org/8351092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108702 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net')
-rw-r--r--net/base/x509_certificate_mac.cc15
1 files changed, 12 insertions, 3 deletions
diff --git a/net/base/x509_certificate_mac.cc b/net/base/x509_certificate_mac.cc
index 93bf74b..1db5a3b 100644
--- a/net/base/x509_certificate_mac.cc
+++ b/net/base/x509_certificate_mac.cc
@@ -50,9 +50,14 @@ int NetErrorFromOSStatus(OSStatus status) {
return ERR_NOT_IMPLEMENTED;
case errSecAuthFailed:
return ERR_ACCESS_DENIED;
- default:
- LOG(ERROR) << "Unknown error " << status << " mapped to ERR_FAILED";
+ default: {
+ base::mac::ScopedCFTypeRef<CFStringRef> error_string(
+ SecCopyErrorMessageString(status, NULL));
+ LOG(ERROR) << "Unknown error " << status
+ << " (" << base::SysCFStringRefToUTF8(error_string) << ")"
+ << " mapped to ERR_FAILED";
return ERR_FAILED;
+ }
}
}
@@ -110,13 +115,17 @@ CertStatus CertStatusFromOSStatus(OSStatus status) {
case CSSMERR_APPLETP_IDP_FAIL:
return CERT_STATUS_INVALID;
- default:
+ default: {
// Failure was due to something Chromium doesn't define a
// specific status for (such as basic constraints violation, or
// unknown critical extension)
+ base::mac::ScopedCFTypeRef<CFStringRef> error_string(
+ SecCopyErrorMessageString(status, NULL));
LOG(WARNING) << "Unknown error " << status
+ << " (" << base::SysCFStringRefToUTF8(error_string) << ")"
<< " mapped to CERT_STATUS_INVALID";
return CERT_STATUS_INVALID;
+ }
}
}