diff options
author | dcheng <dcheng@chromium.org> | 2014-10-27 14:47:29 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-10-27 21:48:18 +0000 |
commit | 67be2b1f8dbb8fe664365ce33cd6ccf2832e0663 (patch) | |
tree | 463de616ca38e98329059fff1709f9f0b8aa5a80 /net | |
parent | acfeaee6661ddd4cb0309a6faed1f4aeb8d24853 (diff) | |
download | chromium_src-67be2b1f8dbb8fe664365ce33cd6ccf2832e0663.zip chromium_src-67be2b1f8dbb8fe664365ce33cd6ccf2832e0663.tar.gz chromium_src-67be2b1f8dbb8fe664365ce33cd6ccf2832e0663.tar.bz2 |
Standardize usage of virtual/override/final specifiers.
The Google C++ style guide states:
Explicitly annotate overrides of virtual functions or virtual
destructors with an override or (less frequently) final specifier.
Older (pre-C++11) code will use the virtual keyword as an inferior
alternative annotation. For clarity, use exactly one of override,
final, or virtual when declaring an override.
To better conform to these guidelines, the following constructs have
been rewritten:
- if a base class has a virtual destructor, then:
virtual ~Foo(); -> ~Foo() override;
- virtual void Foo() override; -> void Foo() override;
- virtual void Foo() override final; -> void Foo() final;
This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.
BUG=417463
R=pauljensen@chromium.org
Review URL: https://codereview.chromium.org/663043004
Cr-Commit-Position: refs/heads/master@{#301452}
Diffstat (limited to 'net')
117 files changed, 393 insertions, 446 deletions
diff --git a/net/base/address_tracker_linux.h b/net/base/address_tracker_linux.h index 2574fc7..a960287 100644 --- a/net/base/address_tracker_linux.h +++ b/net/base/address_tracker_linux.h @@ -47,7 +47,7 @@ class NET_EXPORT_PRIVATE AddressTrackerLinux : AddressTrackerLinux(const base::Closure& address_callback, const base::Closure& link_callback, const base::Closure& tunnel_callback); - virtual ~AddressTrackerLinux(); + ~AddressTrackerLinux() override; // In tracking mode, it starts watching the system configuration for // changes. The current thread must have a MessageLoopForIO. In @@ -108,8 +108,8 @@ class NET_EXPORT_PRIVATE AddressTrackerLinux : void AbortAndForceOnline(); // MessageLoopForIO::Watcher: - virtual void OnFileCanReadWithoutBlocking(int fd) override; - virtual void OnFileCanWriteWithoutBlocking(int /* fd */) override; + void OnFileCanReadWithoutBlocking(int fd) override; + void OnFileCanWriteWithoutBlocking(int /* fd */) override; // Close |netlink_fd_| void CloseSocket(); diff --git a/net/base/directory_lister_unittest.cc b/net/base/directory_lister_unittest.cc index 98ecbbd..869e4f6 100644 --- a/net/base/directory_lister_unittest.cc +++ b/net/base/directory_lister_unittest.cc @@ -91,8 +91,7 @@ class ListerDelegate : public DirectoryLister::DirectoryListerDelegate { class DirectoryListerTest : public PlatformTest { public: - - virtual void SetUp() override { + void SetUp() override { const int kMaxDepth = 3; const int kBranchingFactor = 4; const int kFilesPerDirectory = 5; diff --git a/net/base/dns_reloader.cc b/net/base/dns_reloader.cc index 3a92418..e0e0b76 100644 --- a/net/base/dns_reloader.cc +++ b/net/base/dns_reloader.cc @@ -46,7 +46,7 @@ class DnsReloader : public net::NetworkChangeNotifier::DNSObserver { }; // NetworkChangeNotifier::DNSObserver: - virtual void OnDNSChanged() override { + void OnDNSChanged() override { DCHECK(base::MessageLoopForIO::IsCurrent()); base::AutoLock l(lock_); resolver_generation_++; @@ -84,7 +84,7 @@ class DnsReloader : public net::NetworkChangeNotifier::DNSObserver { net::NetworkChangeNotifier::AddDNSObserver(this); } - virtual ~DnsReloader() { + ~DnsReloader() override { NOTREACHED(); // LeakyLazyInstance is not destructed. } diff --git a/net/base/elements_upload_data_stream_unittest.cc b/net/base/elements_upload_data_stream_unittest.cc index 91c390c..1882e9a 100644 --- a/net/base/elements_upload_data_stream_unittest.cc +++ b/net/base/elements_upload_data_stream_unittest.cc @@ -125,11 +125,11 @@ class MockUploadElementReader : public UploadElementReader { class ElementsUploadDataStreamTest : public PlatformTest { public: - virtual void SetUp() { + void SetUp() override { PlatformTest::SetUp(); ASSERT_TRUE(temp_dir_.CreateUniqueTempDir()); } - virtual ~ElementsUploadDataStreamTest() { + ~ElementsUploadDataStreamTest() override { element_readers_.clear(); base::RunLoop().RunUntilIdle(); } diff --git a/net/base/file_stream_unittest.cc b/net/base/file_stream_unittest.cc index 883421b..fc9257e 100644 --- a/net/base/file_stream_unittest.cc +++ b/net/base/file_stream_unittest.cc @@ -46,13 +46,13 @@ IOBufferWithSize* CreateTestDataBuffer() { class FileStreamTest : public PlatformTest { public: - virtual void SetUp() { + void SetUp() override { PlatformTest::SetUp(); base::CreateTemporaryFile(&temp_file_path_); base::WriteFile(temp_file_path_, kTestData, kTestDataSize); } - virtual void TearDown() { + void TearDown() override { // FileStreamContexts must be asynchronously closed on the file task runner // before they can be deleted. Pump the RunLoop to avoid leaks. base::RunLoop().RunUntilIdle(); diff --git a/net/base/ip_endpoint_unittest.cc b/net/base/ip_endpoint_unittest.cc index 5698cc4..5d70911 100644 --- a/net/base/ip_endpoint_unittest.cc +++ b/net/base/ip_endpoint_unittest.cc @@ -33,7 +33,7 @@ int test_count = arraysize(tests); class IPEndPointTest : public PlatformTest { public: - virtual void SetUp() { + void SetUp() override { // This is where we populate the TestData. for (int index = 0; index < test_count; ++index) { EXPECT_TRUE(ParseIPLiteralToNumber(tests[index].host, diff --git a/net/base/keygen_handler_unittest.cc b/net/base/keygen_handler_unittest.cc index af4e01d..2357328 100644 --- a/net/base/keygen_handler_unittest.cc +++ b/net/base/keygen_handler_unittest.cc @@ -32,13 +32,13 @@ class StubCryptoModuleDelegate : public crypto::NSSCryptoModuleDelegate { explicit StubCryptoModuleDelegate(crypto::ScopedPK11Slot slot) : slot_(slot.Pass()) {} - virtual std::string RequestPassword(const std::string& slot_name, - bool retry, - bool* cancelled) override{ + std::string RequestPassword(const std::string& slot_name, + bool retry, + bool* cancelled) override { return std::string(); } - virtual crypto::ScopedPK11Slot RequestSlot() override { + crypto::ScopedPK11Slot RequestSlot() override { return crypto::ScopedPK11Slot(PK11_ReferenceSlot(slot_.get())); } @@ -50,7 +50,7 @@ class StubCryptoModuleDelegate : public crypto::NSSCryptoModuleDelegate { class KeygenHandlerTest : public ::testing::Test { public: KeygenHandlerTest() {} - virtual ~KeygenHandlerTest() {} + ~KeygenHandlerTest() override {} scoped_ptr<KeygenHandler> CreateKeygenHandler() { scoped_ptr<KeygenHandler> handler(new KeygenHandler( diff --git a/net/base/net_log_logger_unittest.cc b/net/base/net_log_logger_unittest.cc index 2f63b8d..a8df205 100644 --- a/net/base/net_log_logger_unittest.cc +++ b/net/base/net_log_logger_unittest.cc @@ -18,7 +18,7 @@ namespace { class NetLogLoggerTest : public testing::Test { public: - virtual void SetUp() { + void SetUp() override { ASSERT_TRUE(temp_dir_.CreateUniqueTempDir()); log_path_ = temp_dir_.path().AppendASCII("NetLogFile"); } diff --git a/net/base/network_change_notifier_linux.cc b/net/base/network_change_notifier_linux.cc index b10f8a8..f77025a 100644 --- a/net/base/network_change_notifier_linux.cc +++ b/net/base/network_change_notifier_linux.cc @@ -15,7 +15,7 @@ namespace net { class NetworkChangeNotifierLinux::Thread : public base::Thread { public: Thread(); - virtual ~Thread(); + ~Thread() override; // Plumbing for NetworkChangeNotifier::GetCurrentConnectionType. // Safe to call from any thread. @@ -29,8 +29,8 @@ class NetworkChangeNotifierLinux::Thread : public base::Thread { protected: // base::Thread - virtual void Init() override; - virtual void CleanUp() override; + void Init() override; + void CleanUp() override; private: scoped_ptr<DnsConfigService> dns_config_service_; diff --git a/net/base/network_change_notifier_linux.h b/net/base/network_change_notifier_linux.h index 1e8a7eb..5a0f6df 100644 --- a/net/base/network_change_notifier_linux.h +++ b/net/base/network_change_notifier_linux.h @@ -22,14 +22,14 @@ class NET_EXPORT_PRIVATE NetworkChangeNotifierLinux class Thread; NetworkChangeNotifierLinux(); - virtual ~NetworkChangeNotifierLinux(); + ~NetworkChangeNotifierLinux() override; static NetworkChangeCalculatorParams NetworkChangeCalculatorParamsLinux(); // NetworkChangeNotifier: - virtual ConnectionType GetCurrentConnectionType() const override; + ConnectionType GetCurrentConnectionType() const override; - virtual const internal::AddressTrackerLinux* - GetAddressTrackerInternal() const override; + const internal::AddressTrackerLinux* GetAddressTrackerInternal() + const override; // The thread used to listen for notifications. This relays the notification // to the registered observers without posting back to the thread the object diff --git a/net/base/priority_queue_unittest.cc b/net/base/priority_queue_unittest.cc index 87a8299..3e68acf 100644 --- a/net/base/priority_queue_unittest.cc +++ b/net/base/priority_queue_unittest.cc @@ -25,7 +25,7 @@ class PriorityQueueTest : public testing::Test { protected: PriorityQueueTest() : queue_(kNumPriorities) {} - virtual void SetUp() override { + void SetUp() override { CheckEmpty(); for (size_t i = 0; i < kNumElements; ++i) { EXPECT_EQ(i, queue_.size()); diff --git a/net/base/registry_controlled_domains/registry_controlled_domain_unittest.cc b/net/base/registry_controlled_domains/registry_controlled_domain_unittest.cc index 7a4a528..22bd963 100644 --- a/net/base/registry_controlled_domains/registry_controlled_domain_unittest.cc +++ b/net/base/registry_controlled_domains/registry_controlled_domain_unittest.cc @@ -82,7 +82,7 @@ class RegistryControlledDomainTest : public testing::Test { SetFindDomainGraph(graph, sizeof(Graph)); } - virtual void TearDown() { SetFindDomainGraph(); } + void TearDown() override { SetFindDomainGraph(); } }; TEST_F(RegistryControlledDomainTest, TestGetDomainAndRegistry) { diff --git a/net/base/sdch_dictionary_fetcher_unittest.cc b/net/base/sdch_dictionary_fetcher_unittest.cc index af66681..a8b814e 100644 --- a/net/base/sdch_dictionary_fetcher_unittest.cc +++ b/net/base/sdch_dictionary_fetcher_unittest.cc @@ -105,7 +105,7 @@ class SdchDictionaryFetcherTest : public ::testing::Test { public: SdchDictionaryFetcherTest() {} - virtual void SetUp() override { + void SetUp() override { DCHECK(!fetcher_.get()); URLRequestSpecifiedResponseJob::AddUrlHandler(); @@ -115,7 +115,7 @@ class SdchDictionaryFetcherTest : public ::testing::Test { fetcher_delegate_.get(), context_.get())); } - virtual void TearDown() override { + void TearDown() override { URLRequestSpecifiedResponseJob::RemoveUrlHandler(); fetcher_.reset(); context_.reset(); diff --git a/net/base/sdch_manager_unittest.cc b/net/base/sdch_manager_unittest.cc index f1b39e7..c1a25da 100644 --- a/net/base/sdch_manager_unittest.cc +++ b/net/base/sdch_manager_unittest.cc @@ -34,7 +34,7 @@ class SdchManagerTest : public testing::Test { SdchManager* sdch_manager() { return sdch_manager_.get(); } // Reset globals back to default state. - virtual void TearDown() { + void TearDown() override { SdchManager::EnableSdchSupport(default_support_); SdchManager::EnableSecureSchemeSupport(default_https_support_); } diff --git a/net/base/trace_net_log_observer_unittest.cc b/net/base/trace_net_log_observer_unittest.cc index 2e20707..5256bac 100644 --- a/net/base/trace_net_log_observer_unittest.cc +++ b/net/base/trace_net_log_observer_unittest.cc @@ -60,7 +60,7 @@ class TraceNetLogObserverTest : public testing::Test { trace_events_.reset(new base::ListValue()); } - virtual ~TraceNetLogObserverTest() { + ~TraceNetLogObserverTest() override { DCHECK(!TraceLog::GetInstance()->IsEnabled()); } diff --git a/net/base/upload_bytes_element_reader_unittest.cc b/net/base/upload_bytes_element_reader_unittest.cc index e15bbcf..1d2f52f 100644 --- a/net/base/upload_bytes_element_reader_unittest.cc +++ b/net/base/upload_bytes_element_reader_unittest.cc @@ -15,7 +15,7 @@ namespace net { class UploadBytesElementReaderTest : public PlatformTest { protected: - virtual void SetUp() override { + void SetUp() override { const char kData[] = "123abc"; bytes_.assign(kData, kData + arraysize(kData)); reader_.reset(new UploadBytesElementReader(&bytes_[0], bytes_.size())); diff --git a/net/base/upload_file_element_reader_unittest.cc b/net/base/upload_file_element_reader_unittest.cc index 2069fa0..b0374ac 100644 --- a/net/base/upload_file_element_reader_unittest.cc +++ b/net/base/upload_file_element_reader_unittest.cc @@ -18,7 +18,7 @@ namespace net { class UploadFileElementReaderTest : public PlatformTest { protected: - virtual void SetUp() { + void SetUp() override { PlatformTest::SetUp(); // Some tests (*.ReadPartially) rely on bytes_.size() being even. const char kData[] = "123456789abcdefghi"; @@ -46,7 +46,7 @@ class UploadFileElementReaderTest : public PlatformTest { EXPECT_FALSE(reader_->IsInMemory()); } - virtual ~UploadFileElementReaderTest() { + ~UploadFileElementReaderTest() override { reader_.reset(); base::RunLoop().RunUntilIdle(); } diff --git a/net/cert/cert_verify_proc_nss.h b/net/cert/cert_verify_proc_nss.h index e3eb11f..395facf 100644 --- a/net/cert/cert_verify_proc_nss.h +++ b/net/cert/cert_verify_proc_nss.h @@ -17,10 +17,10 @@ class NET_EXPORT_PRIVATE CertVerifyProcNSS : public CertVerifyProc { public: CertVerifyProcNSS(); - virtual bool SupportsAdditionalTrustAnchors() const override; + bool SupportsAdditionalTrustAnchors() const override; protected: - virtual ~CertVerifyProcNSS(); + ~CertVerifyProcNSS() override; // Like VerifyInternal, but adds a |chain_verify_callback| to override trust // decisions. See the documentation for CERTChainVerifyCallback and @@ -34,12 +34,12 @@ class NET_EXPORT_PRIVATE CertVerifyProcNSS : public CertVerifyProc { CertVerifyResult* verify_result); private: - virtual int VerifyInternal(X509Certificate* cert, - const std::string& hostname, - int flags, - CRLSet* crl_set, - const CertificateList& additional_trust_anchors, - CertVerifyResult* verify_result) override; + int VerifyInternal(X509Certificate* cert, + const std::string& hostname, + int flags, + CRLSet* crl_set, + const CertificateList& additional_trust_anchors, + CertVerifyResult* verify_result) override; }; } // namespace net diff --git a/net/cert/cert_verify_proc_unittest.cc b/net/cert/cert_verify_proc_unittest.cc index 4031eac..10a880b 100644 --- a/net/cert/cert_verify_proc_unittest.cc +++ b/net/cert/cert_verify_proc_unittest.cc @@ -114,7 +114,7 @@ class CertVerifyProcTest : public testing::Test { CertVerifyProcTest() : verify_proc_(CertVerifyProc::CreateDefault()) { } - virtual ~CertVerifyProcTest() {} + ~CertVerifyProcTest() override {} protected: bool SupportsAdditionalTrustAnchors() { diff --git a/net/cert/ct_log_verifier_unittest.cc b/net/cert/ct_log_verifier_unittest.cc index e2918c9..373f69e 100644 --- a/net/cert/ct_log_verifier_unittest.cc +++ b/net/cert/ct_log_verifier_unittest.cc @@ -18,7 +18,7 @@ class CTLogVerifierTest : public ::testing::Test { public: CTLogVerifierTest() {} - virtual void SetUp() override { + void SetUp() override { log_ = CTLogVerifier::Create(ct::GetTestPublicKey(), "testlog").Pass(); ASSERT_TRUE(log_); diff --git a/net/cert/ct_objects_extractor_unittest.cc b/net/cert/ct_objects_extractor_unittest.cc index ac46755..90f01f7 100644 --- a/net/cert/ct_objects_extractor_unittest.cc +++ b/net/cert/ct_objects_extractor_unittest.cc @@ -20,7 +20,7 @@ namespace ct { class CTObjectsExtractorTest : public ::testing::Test { public: - virtual void SetUp() override { + void SetUp() override { precert_chain_ = CreateCertificateListFromFile(GetTestCertsDirectory(), "ct-test-embedded-cert.pem", diff --git a/net/cert/ct_serialization_unittest.cc b/net/cert/ct_serialization_unittest.cc index ccf2d20..f908681 100644 --- a/net/cert/ct_serialization_unittest.cc +++ b/net/cert/ct_serialization_unittest.cc @@ -20,7 +20,7 @@ namespace net { class CtSerializationTest : public ::testing::Test { public: - virtual void SetUp() override { + void SetUp() override { test_digitally_signed_ = ct::GetTestDigitallySigned(); } diff --git a/net/cert/ev_root_ca_metadata_unittest.cc b/net/cert/ev_root_ca_metadata_unittest.cc index 90f4fa1..e26603c 100644 --- a/net/cert/ev_root_ca_metadata_unittest.cc +++ b/net/cert/ev_root_ca_metadata_unittest.cc @@ -94,9 +94,7 @@ bool EVOidData::Init() { class EVRootCAMetadataTest : public testing::Test { protected: - virtual void SetUp() override { - ASSERT_TRUE(ev_oid_data.Init()); - } + void SetUp() override { ASSERT_TRUE(ev_oid_data.Init()); } EVOidData ev_oid_data; }; diff --git a/net/cert/multi_log_ct_verifier_unittest.cc b/net/cert/multi_log_ct_verifier_unittest.cc index 17a670c..433901b 100644 --- a/net/cert/multi_log_ct_verifier_unittest.cc +++ b/net/cert/multi_log_ct_verifier_unittest.cc @@ -37,7 +37,7 @@ const char kSCTCountHistogram[] = class MultiLogCTVerifierTest : public ::testing::Test { public: - virtual void SetUp() override { + void SetUp() override { scoped_ptr<CTLogVerifier> log( CTLogVerifier::Create(ct::GetTestPublicKey(), kLogDescription)); ASSERT_TRUE(log); diff --git a/net/cert/multi_threaded_cert_verifier_unittest.cc b/net/cert/multi_threaded_cert_verifier_unittest.cc index bac47b0..a3464e0 100644 --- a/net/cert/multi_threaded_cert_verifier_unittest.cc +++ b/net/cert/multi_threaded_cert_verifier_unittest.cc @@ -67,7 +67,7 @@ class MockCertTrustAnchorProvider : public CertTrustAnchorProvider { class MultiThreadedCertVerifierTest : public ::testing::Test { public: MultiThreadedCertVerifierTest() : verifier_(new MockCertVerifyProc()) {} - virtual ~MultiThreadedCertVerifierTest() {} + ~MultiThreadedCertVerifierTest() override {} protected: MultiThreadedCertVerifier verifier_; diff --git a/net/cert/nss_cert_database.cc b/net/cert/nss_cert_database.cc index 2c40e15..8e9c692d 100644 --- a/net/cert/nss_cert_database.cc +++ b/net/cert/nss_cert_database.cc @@ -48,18 +48,18 @@ class CertNotificationForwarder : public NSSCertDatabase::Observer { explicit CertNotificationForwarder(CertDatabase* cert_db) : cert_db_(cert_db) {} - virtual ~CertNotificationForwarder() {} + ~CertNotificationForwarder() override {} // NSSCertDatabase::Observer implementation: - virtual void OnCertAdded(const X509Certificate* cert) override { + void OnCertAdded(const X509Certificate* cert) override { cert_db_->NotifyObserversOfCertAdded(cert); } - virtual void OnCertRemoved(const X509Certificate* cert) override { + void OnCertRemoved(const X509Certificate* cert) override { cert_db_->NotifyObserversOfCertRemoved(cert); } - virtual void OnCACertChanged(const X509Certificate* cert) override { + void OnCACertChanged(const X509Certificate* cert) override { cert_db_->NotifyObserversOfCACertChanged(cert); } diff --git a/net/cert/nss_cert_database_unittest.cc b/net/cert/nss_cert_database_unittest.cc index 6007452..c5f05b5 100644 --- a/net/cert/nss_cert_database_unittest.cc +++ b/net/cert/nss_cert_database_unittest.cc @@ -55,7 +55,7 @@ void SwapCertList(CertificateList* destination, class CertDatabaseNSSTest : public testing::Test { public: - virtual void SetUp() { + void SetUp() override { ASSERT_TRUE(test_nssdb_.is_open()); cert_db_.reset(new NSSCertDatabase( crypto::ScopedPK11Slot( @@ -68,7 +68,7 @@ class CertDatabaseNSSTest : public testing::Test { EXPECT_EQ(0U, ListCerts().size()); } - virtual void TearDown() { + void TearDown() override { // Run the message loop to process any observer callbacks (e.g. for the // ClientSocketFactory singleton) so that the scoped ref ptrs created in // NSSCertDatabase::NotifyObservers* get released. diff --git a/net/cert/signed_certificate_timestamp_unittest.cc b/net/cert/signed_certificate_timestamp_unittest.cc index dc60a27..393725d 100644 --- a/net/cert/signed_certificate_timestamp_unittest.cc +++ b/net/cert/signed_certificate_timestamp_unittest.cc @@ -20,7 +20,7 @@ const char kLogDescription[] = "somelog"; class SignedCertificateTimestampTest : public ::testing::Test { public: - virtual void SetUp() override { + void SetUp() override { GetX509CertSCT(&sample_sct_); sample_sct_->origin = SignedCertificateTimestamp::SCT_FROM_OCSP_RESPONSE; sample_sct_->log_description = kLogDescription; diff --git a/net/cert/x509_cert_types_unittest.cc b/net/cert/x509_cert_types_unittest.cc index 38fd3e9..a6645c0 100644 --- a/net/cert/x509_cert_types_unittest.cc +++ b/net/cert/x509_cert_types_unittest.cc @@ -210,9 +210,7 @@ void PrintTo(const CertDateTestData& data, std::ostream* os) { class X509CertTypesDateTest : public testing::TestWithParam<CertDateTestData> { public: virtual ~X509CertTypesDateTest() {} - virtual void SetUp() { - test_data_ = GetParam(); - } + void SetUp() override { test_data_ = GetParam(); } protected: CertDateTestData test_data_; diff --git a/net/cert/x509_certificate_unittest.cc b/net/cert/x509_certificate_unittest.cc index 3398510..652a5fb 100644 --- a/net/cert/x509_certificate_unittest.cc +++ b/net/cert/x509_certificate_unittest.cc @@ -867,10 +867,8 @@ class X509CertificateParseTest : public testing::TestWithParam<CertificateFormatTestData> { public: virtual ~X509CertificateParseTest() {} - virtual void SetUp() { - test_data_ = GetParam(); - } - virtual void TearDown() {} + void SetUp() override { test_data_ = GetParam(); } + void TearDown() override {} protected: CertificateFormatTestData test_data_; diff --git a/net/cookies/cookie_monster.h b/net/cookies/cookie_monster.h index 90acd9d..a41c391 100644 --- a/net/cookies/cookie_monster.h +++ b/net/cookies/cookie_monster.h @@ -315,7 +315,7 @@ class NET_EXPORT CookieMonster : public CookieStore { // See comment on keys before the CookieMap typedef. std::string GetKey(const std::string& domain) const; - virtual scoped_ptr<CookieChangedSubscription> AddCallbackForCookie( + scoped_ptr<CookieChangedSubscription> AddCallbackForCookie( const GURL& url, const std::string& name, const CookieChangedCallback& callback) override; diff --git a/net/cookies/cookie_monster_unittest.cc b/net/cookies/cookie_monster_unittest.cc index 5c31281..127e594 100644 --- a/net/cookies/cookie_monster_unittest.cc +++ b/net/cookies/cookie_monster_unittest.cc @@ -2745,7 +2745,7 @@ class CookieMonsterNotificationTest : public CookieMonsterTest { store_(new MockPersistentCookieStore), monster_(new CookieMonster(store_.get(), NULL)) {} - virtual ~CookieMonsterNotificationTest() {} + ~CookieMonsterNotificationTest() override {} CookieMonster* monster() { return monster_.get(); } diff --git a/net/disk_cache/cache_util_unittest.cc b/net/disk_cache/cache_util_unittest.cc index b755815..073c152 100644 --- a/net/disk_cache/cache_util_unittest.cc +++ b/net/disk_cache/cache_util_unittest.cc @@ -12,7 +12,7 @@ namespace disk_cache { class CacheUtilTest : public PlatformTest { public: - virtual void SetUp() { + void SetUp() override { PlatformTest::SetUp(); ASSERT_TRUE(tmp_dir_.CreateUniqueTempDir()); cache_dir_ = tmp_dir_.path().Append(FILE_PATH_LITERAL("Cache")); diff --git a/net/disk_cache/disk_cache_test_base.h b/net/disk_cache/disk_cache_test_base.h index ce36f92..ef136f4 100644 --- a/net/disk_cache/disk_cache_test_base.h +++ b/net/disk_cache/disk_cache_test_base.h @@ -38,7 +38,7 @@ class SimpleBackendImpl; class DiskCacheTest : public PlatformTest { protected: DiskCacheTest(); - virtual ~DiskCacheTest(); + ~DiskCacheTest() override; // Copies a set of cache files from the data folder to the test folder. bool CopyTestCache(const std::string& name); @@ -46,7 +46,7 @@ class DiskCacheTest : public PlatformTest { // Deletes the contents of |cache_path_|. bool CleanupCacheDir(); - virtual void TearDown() override; + void TearDown() override; base::FilePath cache_path_; @@ -70,7 +70,7 @@ class DiskCacheTestWithCache : public DiskCacheTest { }; DiskCacheTestWithCache(); - virtual ~DiskCacheTestWithCache(); + ~DiskCacheTestWithCache() override; void CreateBackend(uint32 flags, base::Thread* thread); @@ -154,7 +154,7 @@ class DiskCacheTestWithCache : public DiskCacheTest { void AddDelay(); // DiskCacheTest: - virtual void TearDown() override; + void TearDown() override; // cache_ will always have a valid object, regardless of how the cache was // initialized. The implementation pointers can be NULL. diff --git a/net/disk_cache/simple/simple_index_unittest.cc b/net/disk_cache/simple/simple_index_unittest.cc index dc63989..e5d0830 100644 --- a/net/disk_cache/simple/simple_index_unittest.cc +++ b/net/disk_cache/simple/simple_index_unittest.cc @@ -101,7 +101,7 @@ class SimpleIndexTest : public testing::Test, public SimpleIndexDelegate { base::StringPrintf("key%d", static_cast<int>(hash_index))); } - virtual void SetUp() override { + void SetUp() override { scoped_ptr<MockSimpleIndexFile> index_file(new MockSimpleIndexFile()); index_file_ = index_file->AsWeakPtr(); index_.reset( diff --git a/net/dns/dns_config_service_unittest.cc b/net/dns/dns_config_service_unittest.cc index 74020c8..45a803d 100644 --- a/net/dns/dns_config_service_unittest.cc +++ b/net/dns/dns_config_service_unittest.cc @@ -176,7 +176,7 @@ class DnsConfigServiceTest : public testing::Test { return hosts; } - virtual void SetUp() override { + void SetUp() override { quit_on_config_ = false; service_.reset(new TestDnsConfigService()); diff --git a/net/dns/dns_transaction_unittest.cc b/net/dns/dns_transaction_unittest.cc index 5581f22..f22478c 100644 --- a/net/dns/dns_transaction_unittest.cc +++ b/net/dns/dns_transaction_unittest.cc @@ -441,7 +441,7 @@ class DnsTransactionTest : public testing::Test { } } - virtual void SetUp() override { + void SetUp() override { // By default set one server, ConfigureNumServers(1); // and no retransmissions, @@ -451,7 +451,7 @@ class DnsTransactionTest : public testing::Test { ConfigureFactory(); } - virtual void TearDown() override { + void TearDown() override { // Check that all socket data was at least written to. for (size_t i = 0; i < socket_data_.size(); ++i) { EXPECT_TRUE(socket_data_[i]->was_written()) << i; diff --git a/net/dns/host_resolver_impl_unittest.cc b/net/dns/host_resolver_impl_unittest.cc index 017625f..7b6a391 100644 --- a/net/dns/host_resolver_impl_unittest.cc +++ b/net/dns/host_resolver_impl_unittest.cc @@ -460,11 +460,9 @@ class HostResolverImplTest : public testing::Test { }; // testing::Test implementation: - virtual void SetUp() override { - CreateResolver(); - } + void SetUp() override { CreateResolver(); } - virtual void TearDown() override { + void TearDown() override { if (resolver_.get()) EXPECT_EQ(0u, resolver_->num_running_dispatcher_jobs_for_tests()); EXPECT_FALSE(proc_->HasBlockedRequests()); @@ -1339,7 +1337,7 @@ class HostResolverImplDnsTest : public HostResolverImplTest { protected: // testing::Test implementation: - virtual void SetUp() override { + void SetUp() override { AddDnsRule("nx", dns_protocol::kTypeA, MockDnsClientRule::FAIL, false); AddDnsRule("nx", dns_protocol::kTypeAAAA, MockDnsClientRule::FAIL, false); AddDnsRule("ok", dns_protocol::kTypeA, MockDnsClientRule::OK, false); diff --git a/net/dns/mdns_client_impl.h b/net/dns/mdns_client_impl.h index b6f8b93..0dfedf9 100644 --- a/net/dns/mdns_client_impl.h +++ b/net/dns/mdns_client_impl.h @@ -26,10 +26,9 @@ namespace net { class MDnsSocketFactoryImpl : public MDnsSocketFactory { public: MDnsSocketFactoryImpl() {}; - virtual ~MDnsSocketFactoryImpl() {}; + ~MDnsSocketFactoryImpl() override{}; - virtual void CreateSockets( - ScopedVector<DatagramServerSocket>* sockets) override; + void CreateSockets(ScopedVector<DatagramServerSocket>* sockets) override; private: DISALLOW_COPY_AND_ASSIGN(MDnsSocketFactoryImpl); @@ -111,7 +110,7 @@ class NET_EXPORT_PRIVATE MDnsClientImpl : public MDnsClient { class Core : public base::SupportsWeakPtr<Core>, MDnsConnection::Delegate { public: explicit Core(MDnsClientImpl* client); - virtual ~Core(); + ~Core() override; // Initialize the core. Returns true on success. bool Init(MDnsSocketFactory* socket_factory); @@ -128,9 +127,9 @@ class NET_EXPORT_PRIVATE MDnsClientImpl : public MDnsClient { std::vector<const RecordParsed*>* records) const; // Parse the response and alert relevant listeners. - virtual void HandlePacket(DnsResponse* response, int bytes_read) override; + void HandlePacket(DnsResponse* response, int bytes_read) override; - virtual void OnConnectionError(int error) override; + void OnConnectionError(int error) override; private: typedef std::pair<std::string, uint16> ListenerKey; @@ -170,23 +169,23 @@ class NET_EXPORT_PRIVATE MDnsClientImpl : public MDnsClient { }; MDnsClientImpl(); - virtual ~MDnsClientImpl(); + ~MDnsClientImpl() override; // MDnsClient implementation: - virtual scoped_ptr<MDnsListener> CreateListener( + scoped_ptr<MDnsListener> CreateListener( uint16 rrtype, const std::string& name, MDnsListener::Delegate* delegate) override; - virtual scoped_ptr<MDnsTransaction> CreateTransaction( + scoped_ptr<MDnsTransaction> CreateTransaction( uint16 rrtype, const std::string& name, int flags, const MDnsTransaction::ResultCallback& callback) override; - virtual bool StartListening(MDnsSocketFactory* socket_factory) override; - virtual void StopListening() override; - virtual bool IsListening() const override; + bool StartListening(MDnsSocketFactory* socket_factory) override; + void StopListening() override; + bool IsListening() const override; Core* core() { return core_.get(); } @@ -204,17 +203,17 @@ class MDnsListenerImpl : public MDnsListener, MDnsListener::Delegate* delegate, MDnsClientImpl* client); - virtual ~MDnsListenerImpl(); + ~MDnsListenerImpl() override; // MDnsListener implementation: - virtual bool Start() override; + bool Start() override; // Actively refresh any received records. - virtual void SetActiveRefresh(bool active_refresh) override; + void SetActiveRefresh(bool active_refresh) override; - virtual const std::string& GetName() const override; + const std::string& GetName() const override; - virtual uint16 GetType() const override; + uint16 GetType() const override; MDnsListener::Delegate* delegate() { return delegate_; } @@ -252,20 +251,20 @@ class MDnsTransactionImpl : public base::SupportsWeakPtr<MDnsTransactionImpl>, int flags, const MDnsTransaction::ResultCallback& callback, MDnsClientImpl* client); - virtual ~MDnsTransactionImpl(); + ~MDnsTransactionImpl() override; // MDnsTransaction implementation: - virtual bool Start() override; + bool Start() override; - virtual const std::string& GetName() const override; - virtual uint16 GetType() const override; + const std::string& GetName() const override; + uint16 GetType() const override; // MDnsListener::Delegate implementation: - virtual void OnRecordUpdate(MDnsListener::UpdateType update, - const RecordParsed* record) override; - virtual void OnNsecRecord(const std::string& name, unsigned type) override; + void OnRecordUpdate(MDnsListener::UpdateType update, + const RecordParsed* record) override; + void OnNsecRecord(const std::string& name, unsigned type) override; - virtual void OnCachePurged() override; + void OnCachePurged() override; private: bool is_active() { return !callback_.is_null(); } diff --git a/net/dns/mdns_client_unittest.cc b/net/dns/mdns_client_unittest.cc index 4b2e7d5..ba03082 100644 --- a/net/dns/mdns_client_unittest.cc +++ b/net/dns/mdns_client_unittest.cc @@ -1056,8 +1056,7 @@ TEST_F(MDnsTest, RefreshQuery) { // This is a simplifying assumption based on the way the code works now. class SimpleMockSocketFactory : public MDnsSocketFactory { public: - virtual void CreateSockets( - ScopedVector<DatagramServerSocket>* sockets) override { + void CreateSockets(ScopedVector<DatagramServerSocket>* sockets) override { sockets->clear(); sockets->swap(sockets_); } @@ -1160,7 +1159,7 @@ TEST_F(MDnsConnectionTest, Error) { class MDnsConnectionSendTest : public MDnsConnectionTest { protected: - virtual void SetUp() override { + void SetUp() override { MDnsConnectionTest::SetUp(); EXPECT_CALL(*socket_ipv4_, RecvFrom(_, _, _, _)) .WillOnce(Return(ERR_IO_PENDING)); diff --git a/net/dns/record_rdata.h b/net/dns/record_rdata.h index 09a082f..47ba177b 100644 --- a/net/dns/record_rdata.h +++ b/net/dns/record_rdata.h @@ -44,12 +44,12 @@ class NET_EXPORT_PRIVATE SrvRecordRdata : public RecordRdata { public: static const uint16 kType = dns_protocol::kTypeSRV; - virtual ~SrvRecordRdata(); + ~SrvRecordRdata() override; static scoped_ptr<SrvRecordRdata> Create(const base::StringPiece& data, const DnsRecordParser& parser); - virtual bool IsEqual(const RecordRdata* other) const override; - virtual uint16 Type() const override; + bool IsEqual(const RecordRdata* other) const override; + uint16 Type() const override; uint16 priority() const { return priority_; } uint16 weight() const { return weight_; } @@ -75,11 +75,11 @@ class NET_EXPORT_PRIVATE ARecordRdata : public RecordRdata { public: static const uint16 kType = dns_protocol::kTypeA; - virtual ~ARecordRdata(); + ~ARecordRdata() override; static scoped_ptr<ARecordRdata> Create(const base::StringPiece& data, const DnsRecordParser& parser); - virtual bool IsEqual(const RecordRdata* other) const override; - virtual uint16 Type() const override; + bool IsEqual(const RecordRdata* other) const override; + uint16 Type() const override; const IPAddressNumber& address() const { return address_; } @@ -97,11 +97,11 @@ class NET_EXPORT_PRIVATE AAAARecordRdata : public RecordRdata { public: static const uint16 kType = dns_protocol::kTypeAAAA; - virtual ~AAAARecordRdata(); + ~AAAARecordRdata() override; static scoped_ptr<AAAARecordRdata> Create(const base::StringPiece& data, const DnsRecordParser& parser); - virtual bool IsEqual(const RecordRdata* other) const override; - virtual uint16 Type() const override; + bool IsEqual(const RecordRdata* other) const override; + uint16 Type() const override; const IPAddressNumber& address() const { return address_; } @@ -119,11 +119,11 @@ class NET_EXPORT_PRIVATE CnameRecordRdata : public RecordRdata { public: static const uint16 kType = dns_protocol::kTypeCNAME; - virtual ~CnameRecordRdata(); + ~CnameRecordRdata() override; static scoped_ptr<CnameRecordRdata> Create(const base::StringPiece& data, const DnsRecordParser& parser); - virtual bool IsEqual(const RecordRdata* other) const override; - virtual uint16 Type() const override; + bool IsEqual(const RecordRdata* other) const override; + uint16 Type() const override; std::string cname() const { return cname_; } @@ -141,11 +141,11 @@ class NET_EXPORT_PRIVATE PtrRecordRdata : public RecordRdata { public: static const uint16 kType = dns_protocol::kTypePTR; - virtual ~PtrRecordRdata(); + ~PtrRecordRdata() override; static scoped_ptr<PtrRecordRdata> Create(const base::StringPiece& data, const DnsRecordParser& parser); - virtual bool IsEqual(const RecordRdata* other) const override; - virtual uint16 Type() const override; + bool IsEqual(const RecordRdata* other) const override; + uint16 Type() const override; std::string ptrdomain() const { return ptrdomain_; } @@ -164,11 +164,11 @@ class NET_EXPORT_PRIVATE TxtRecordRdata : public RecordRdata { public: static const uint16 kType = dns_protocol::kTypeTXT; - virtual ~TxtRecordRdata(); + ~TxtRecordRdata() override; static scoped_ptr<TxtRecordRdata> Create(const base::StringPiece& data, const DnsRecordParser& parser); - virtual bool IsEqual(const RecordRdata* other) const override; - virtual uint16 Type() const override; + bool IsEqual(const RecordRdata* other) const override; + uint16 Type() const override; const std::vector<std::string>& texts() const { return texts_; } @@ -188,11 +188,11 @@ class NET_EXPORT_PRIVATE NsecRecordRdata : public RecordRdata { public: static const uint16 kType = dns_protocol::kTypeNSEC; - virtual ~NsecRecordRdata(); + ~NsecRecordRdata() override; static scoped_ptr<NsecRecordRdata> Create(const base::StringPiece& data, const DnsRecordParser& parser); - virtual bool IsEqual(const RecordRdata* other) const override; - virtual uint16 Type() const override; + bool IsEqual(const RecordRdata* other) const override; + uint16 Type() const override; // Length of the bitmap in bits. unsigned bitmap_length() const { return bitmap_.size() * 8; } diff --git a/net/dns/serial_worker_unittest.cc b/net/dns/serial_worker_unittest.cc index 8e30e28..18b5464 100644 --- a/net/dns/serial_worker_unittest.cc +++ b/net/dns/serial_worker_unittest.cc @@ -96,12 +96,12 @@ class SerialWorkerTest : public testing::Test { } // test::Test methods - virtual void SetUp() override { + void SetUp() override { message_loop_ = base::MessageLoop::current(); worker_ = new TestSerialWorker(this); } - virtual void TearDown() override { + void TearDown() override { // Cancel the worker to catch if it makes a late DoWork call. worker_->Cancel(); // Check if OnWork is stalled. diff --git a/net/extras/sqlite/sqlite_channel_id_store_unittest.cc b/net/extras/sqlite/sqlite_channel_id_store_unittest.cc index 92d77e9..17024f4 100644 --- a/net/extras/sqlite/sqlite_channel_id_store_unittest.cc +++ b/net/extras/sqlite/sqlite_channel_id_store_unittest.cc @@ -73,7 +73,7 @@ class SQLiteChannelIDStoreTest : public testing::Test { return base::Time::FromUTCExploded(exploded_time); } - virtual void SetUp() { + void SetUp() override { ASSERT_TRUE(temp_dir_.CreateUniqueTempDir()); store_ = new SQLiteChannelIDStore( temp_dir_.path().Append(kTestChannelIDFilename), diff --git a/net/filter/gzip_filter_unittest.cc b/net/filter/gzip_filter_unittest.cc index f3f9111..2f11e28a 100644 --- a/net/filter/gzip_filter_unittest.cc +++ b/net/filter/gzip_filter_unittest.cc @@ -49,7 +49,7 @@ namespace net { // Mac, so this needs to be a PlatformTest. class GZipUnitTest : public PlatformTest { protected: - virtual void SetUp() { + void SetUp() override { PlatformTest::SetUp(); deflate_encode_buffer_ = NULL; @@ -89,7 +89,7 @@ class GZipUnitTest : public PlatformTest { ASSERT_TRUE(gzip_encode_len_ <= kDefaultBufferSize); } - virtual void TearDown() { + void TearDown() override { delete[] deflate_encode_buffer_; deflate_encode_buffer_ = NULL; diff --git a/net/http/http_auth_handler_negotiate_unittest.cc b/net/http/http_auth_handler_negotiate_unittest.cc index 64521a6..233597d 100644 --- a/net/http/http_auth_handler_negotiate_unittest.cc +++ b/net/http/http_auth_handler_negotiate_unittest.cc @@ -29,7 +29,7 @@ namespace net { class HttpAuthHandlerNegotiateTest : public PlatformTest { public: - virtual void SetUp() { + void SetUp() override { auth_library_ = new MockAuthLibrary(); resolver_.reset(new MockHostResolver()); resolver_->rules()->AddIPLiteralRule("alias", "10.0.0.2", diff --git a/net/http/http_network_layer_unittest.cc b/net/http/http_network_layer_unittest.cc index 7225001..ca04829 100644 --- a/net/http/http_network_layer_unittest.cc +++ b/net/http/http_network_layer_unittest.cc @@ -28,7 +28,7 @@ class HttpNetworkLayerTest : public PlatformTest { protected: HttpNetworkLayerTest() : ssl_config_service_(new SSLConfigServiceDefaults) {} - virtual void SetUp() { + void SetUp() override { ConfigureTestDependencies(ProxyService::CreateDirect()); } diff --git a/net/http/http_network_transaction_ssl_unittest.cc b/net/http/http_network_transaction_ssl_unittest.cc index a84076e..ec52c35 100644 --- a/net/http/http_network_transaction_ssl_unittest.cc +++ b/net/http/http_network_transaction_ssl_unittest.cc @@ -58,7 +58,7 @@ class TLS11SSLConfigService : public SSLConfigService { class HttpNetworkTransactionSSLTest : public testing::Test { protected: - virtual void SetUp() { + void SetUp() override { ssl_config_service_ = new TLS10SSLConfigService; session_params_.ssl_config_service = ssl_config_service_.get(); diff --git a/net/http/http_network_transaction_unittest.cc b/net/http/http_network_transaction_unittest.cc index e4a75b9..be94493 100644 --- a/net/http/http_network_transaction_unittest.cc +++ b/net/http/http_network_transaction_unittest.cc @@ -253,12 +253,12 @@ class HttpNetworkTransactionTest LoadTimingInfo load_timing_info; }; - virtual void SetUp() { + void SetUp() override { NetworkChangeNotifier::NotifyObserversOfIPAddressChangeForTests(); base::MessageLoop::current()->RunUntilIdle(); } - virtual void TearDown() { + void TearDown() override { NetworkChangeNotifier::NotifyObserversOfIPAddressChangeForTests(); base::MessageLoop::current()->RunUntilIdle(); // Empty the current queue. diff --git a/net/http/http_response_body_drainer_unittest.cc b/net/http/http_response_body_drainer_unittest.cc index cb2f1a9..371e9a7 100644 --- a/net/http/http_response_body_drainer_unittest.cc +++ b/net/http/http_response_body_drainer_unittest.cc @@ -213,7 +213,7 @@ class HttpResponseBodyDrainerTest : public testing::Test { mock_stream_(new MockHttpStream(&result_waiter_)), drainer_(new HttpResponseBodyDrainer(mock_stream_)) {} - virtual ~HttpResponseBodyDrainerTest() {} + ~HttpResponseBodyDrainerTest() override {} HttpNetworkSession* CreateNetworkSession() const { HttpNetworkSession::Params params; diff --git a/net/http/http_server_properties_manager_unittest.cc b/net/http/http_server_properties_manager_unittest.cc index fcc253e..db58c92 100644 --- a/net/http/http_server_properties_manager_unittest.cc +++ b/net/http/http_server_properties_manager_unittest.cc @@ -87,7 +87,7 @@ class HttpServerPropertiesManagerTest : public testing::Test { protected: HttpServerPropertiesManagerTest() {} - virtual void SetUp() override { + void SetUp() override { pref_service_.registry()->RegisterDictionaryPref(kTestHttpServerProperties); http_server_props_manager_.reset( new StrictMock<TestingHttpServerPropertiesManager>( @@ -98,7 +98,7 @@ class HttpServerPropertiesManagerTest : public testing::Test { base::RunLoop().RunUntilIdle(); } - virtual void TearDown() override { + void TearDown() override { if (http_server_props_manager_.get()) http_server_props_manager_->ShutdownOnPrefThread(); base::RunLoop().RunUntilIdle(); diff --git a/net/http/transport_security_persister_unittest.cc b/net/http/transport_security_persister_unittest.cc index b8dad5a..7bb2e99 100644 --- a/net/http/transport_security_persister_unittest.cc +++ b/net/http/transport_security_persister_unittest.cc @@ -23,11 +23,11 @@ class TransportSecurityPersisterTest : public testing::Test { TransportSecurityPersisterTest() { } - virtual ~TransportSecurityPersisterTest() { + ~TransportSecurityPersisterTest() override { base::MessageLoopForIO::current()->RunUntilIdle(); } - virtual void SetUp() override { + void SetUp() override { ASSERT_TRUE(temp_dir_.CreateUniqueTempDir()); persister_.reset(new TransportSecurityPersister( &state_, diff --git a/net/http/transport_security_state_unittest.cc b/net/http/transport_security_state_unittest.cc index 8a2ebe8..eb72050 100644 --- a/net/http/transport_security_state_unittest.cc +++ b/net/http/transport_security_state_unittest.cc @@ -39,7 +39,7 @@ namespace net { class TransportSecurityStateTest : public testing::Test { public: - virtual void SetUp() { + void SetUp() override { #if defined(USE_OPENSSL) crypto::EnsureOpenSSLInit(); #else diff --git a/net/ocsp/nss_ocsp.cc b/net/ocsp/nss_ocsp.cc index 02eb2c7..61c65ee 100644 --- a/net/ocsp/nss_ocsp.cc +++ b/net/ocsp/nss_ocsp.cc @@ -283,9 +283,9 @@ class OCSPRequestSession return data_; } - virtual void OnReceivedRedirect(URLRequest* request, - const RedirectInfo& redirect_info, - bool* defer_redirect) override { + void OnReceivedRedirect(URLRequest* request, + const RedirectInfo& redirect_info, + bool* defer_redirect) override { DCHECK_EQ(request_.get(), request); DCHECK_EQ(base::MessageLoopForIO::current(), io_loop_); @@ -296,7 +296,7 @@ class OCSPRequestSession } } - virtual void OnResponseStarted(URLRequest* request) override { + void OnResponseStarted(URLRequest* request) override { DCHECK_EQ(request_.get(), request); DCHECK_EQ(base::MessageLoopForIO::current(), io_loop_); @@ -310,8 +310,7 @@ class OCSPRequestSession OnReadCompleted(request_.get(), bytes_read); } - virtual void OnReadCompleted(URLRequest* request, - int bytes_read) override { + void OnReadCompleted(URLRequest* request, int bytes_read) override { DCHECK_EQ(request_.get(), request); DCHECK_EQ(base::MessageLoopForIO::current(), io_loop_); @@ -359,7 +358,7 @@ class OCSPRequestSession private: friend class base::RefCountedThreadSafe<OCSPRequestSession>; - virtual ~OCSPRequestSession() { + ~OCSPRequestSession() override { // When this destructor is called, there should be only one thread that has // a reference to this object, and so that thread doesn't need to lock // |lock_| here. diff --git a/net/ocsp/nss_ocsp_unittest.cc b/net/ocsp/nss_ocsp_unittest.cc index acbb785..745741e 100644 --- a/net/ocsp/nss_ocsp_unittest.cc +++ b/net/ocsp/nss_ocsp_unittest.cc @@ -44,10 +44,10 @@ class AiaResponseHandler : public net::URLRequestInterceptor { public: AiaResponseHandler(const std::string& headers, const std::string& cert_data) : headers_(headers), cert_data_(cert_data), request_count_(0) {} - virtual ~AiaResponseHandler() {} + ~AiaResponseHandler() override {} // net::URLRequestInterceptor implementation: - virtual net::URLRequestJob* MaybeInterceptRequest( + net::URLRequestJob* MaybeInterceptRequest( net::URLRequest* request, net::NetworkDelegate* network_delegate) const override { ++const_cast<AiaResponseHandler*>(this)->request_count_; @@ -75,9 +75,9 @@ class NssHttpTest : public ::testing::Test { handler_(NULL), verify_proc_(new CertVerifyProcNSS), verifier_(new MultiThreadedCertVerifier(verify_proc_.get())) {} - virtual ~NssHttpTest() {} + ~NssHttpTest() override {} - virtual void SetUp() { + void SetUp() override { std::string file_contents; ASSERT_TRUE(base::ReadFileToString( GetTestCertsDirectory().AppendASCII("aia-intermediate.der"), @@ -97,7 +97,7 @@ class NssHttpTest : public ::testing::Test { EnsureNSSHttpIOInit(); } - virtual void TearDown() { + void TearDown() override { ShutdownNSSHttpIO(); if (handler_) diff --git a/net/proxy/proxy_config_service_linux.cc b/net/proxy/proxy_config_service_linux.cc index 145312e..e0a9372 100644 --- a/net/proxy/proxy_config_service_linux.cc +++ b/net/proxy/proxy_config_service_linux.cc @@ -206,7 +206,7 @@ class SettingGetterImplGConf : public ProxyConfigServiceLinux::SettingGetter { notify_delegate_(NULL) { } - virtual ~SettingGetterImplGConf() { + ~SettingGetterImplGConf() override { // client_ should have been released before now, from // Delegate::OnDestroy(), while running on the UI thread. However // on exiting the process, it may happen that Delegate::OnDestroy() @@ -232,9 +232,8 @@ class SettingGetterImplGConf : public ProxyConfigServiceLinux::SettingGetter { DCHECK(!client_); } - virtual bool Init( - const scoped_refptr<base::SingleThreadTaskRunner>& glib_task_runner, - const scoped_refptr<base::SingleThreadTaskRunner>& file_task_runner) + bool Init(const scoped_refptr<base::SingleThreadTaskRunner>& glib_task_runner, + const scoped_refptr<base::SingleThreadTaskRunner>& file_task_runner) override { DCHECK(glib_task_runner->BelongsToCurrentThread()); DCHECK(!client_); @@ -273,7 +272,7 @@ class SettingGetterImplGConf : public ProxyConfigServiceLinux::SettingGetter { return true; } - virtual void ShutDown() override { + void ShutDown() override { if (client_) { DCHECK(task_runner_->BelongsToCurrentThread()); // We must explicitly disable gconf notifications here, because the gconf @@ -290,7 +289,7 @@ class SettingGetterImplGConf : public ProxyConfigServiceLinux::SettingGetter { } } - virtual bool SetUpNotifications( + bool SetUpNotifications( ProxyConfigServiceLinux::Delegate* delegate) override { DCHECK(client_); DCHECK(task_runner_->BelongsToCurrentThread()); @@ -320,16 +319,16 @@ class SettingGetterImplGConf : public ProxyConfigServiceLinux::SettingGetter { return true; } - virtual const scoped_refptr<base::SingleThreadTaskRunner>& - GetNotificationTaskRunner() override { + const scoped_refptr<base::SingleThreadTaskRunner>& GetNotificationTaskRunner() + override { return task_runner_; } - virtual ProxyConfigSource GetConfigSource() override { + ProxyConfigSource GetConfigSource() override { return PROXY_CONFIG_SOURCE_GCONF; } - virtual bool GetString(StringSetting key, std::string* result) override { + bool GetString(StringSetting key, std::string* result) override { switch (key) { case PROXY_MODE: return GetStringByPath("/system/proxy/mode", result); @@ -346,7 +345,7 @@ class SettingGetterImplGConf : public ProxyConfigServiceLinux::SettingGetter { } return false; // Placate compiler. } - virtual bool GetBool(BoolSetting key, bool* result) override { + bool GetBool(BoolSetting key, bool* result) override { switch (key) { case PROXY_USE_HTTP_PROXY: return GetBoolByPath("/system/http_proxy/use_http_proxy", result); @@ -357,7 +356,7 @@ class SettingGetterImplGConf : public ProxyConfigServiceLinux::SettingGetter { } return false; // Placate compiler. } - virtual bool GetInt(IntSetting key, int* result) override { + bool GetInt(IntSetting key, int* result) override { switch (key) { case PROXY_HTTP_PORT: return GetIntByPath("/system/http_proxy/port", result); @@ -370,8 +369,8 @@ class SettingGetterImplGConf : public ProxyConfigServiceLinux::SettingGetter { } return false; // Placate compiler. } - virtual bool GetStringList(StringListSetting key, - std::vector<std::string>* result) override { + bool GetStringList(StringListSetting key, + std::vector<std::string>* result) override { switch (key) { case PROXY_IGNORE_HOSTS: return GetStringListByPath("/system/http_proxy/ignore_hosts", result); @@ -379,14 +378,12 @@ class SettingGetterImplGConf : public ProxyConfigServiceLinux::SettingGetter { return false; // Placate compiler. } - virtual bool BypassListIsReversed() override { + bool BypassListIsReversed() override { // This is a KDE-specific setting. return false; } - virtual bool MatchHostsUsingSuffixMatching() override { - return false; - } + bool MatchHostsUsingSuffixMatching() override { return false; } private: bool GetStringByPath(const char* key, std::string* result) { @@ -529,7 +526,7 @@ class SettingGetterImplGSettings notify_delegate_(NULL) { } - virtual ~SettingGetterImplGSettings() { + ~SettingGetterImplGSettings() override { // client_ should have been released before now, from // Delegate::OnDestroy(), while running on the UI thread. However // on exiting the process, it may happen that @@ -565,9 +562,8 @@ class SettingGetterImplGSettings // LoadAndCheckVersion() must be called *before* Init()! bool LoadAndCheckVersion(base::Environment* env); - virtual bool Init( - const scoped_refptr<base::SingleThreadTaskRunner>& glib_task_runner, - const scoped_refptr<base::SingleThreadTaskRunner>& file_task_runner) + bool Init(const scoped_refptr<base::SingleThreadTaskRunner>& glib_task_runner, + const scoped_refptr<base::SingleThreadTaskRunner>& file_task_runner) override { DCHECK(glib_task_runner->BelongsToCurrentThread()); DCHECK(!client_); @@ -589,7 +585,7 @@ class SettingGetterImplGSettings return true; } - virtual void ShutDown() override { + void ShutDown() override { if (client_) { DCHECK(task_runner_->BelongsToCurrentThread()); // This also disables gsettings notifications. @@ -604,7 +600,7 @@ class SettingGetterImplGSettings } } - virtual bool SetUpNotifications( + bool SetUpNotifications( ProxyConfigServiceLinux::Delegate* delegate) override { DCHECK(client_); DCHECK(task_runner_->BelongsToCurrentThread()); @@ -627,16 +623,16 @@ class SettingGetterImplGSettings return true; } - virtual const scoped_refptr<base::SingleThreadTaskRunner>& - GetNotificationTaskRunner() override { + const scoped_refptr<base::SingleThreadTaskRunner>& GetNotificationTaskRunner() + override { return task_runner_; } - virtual ProxyConfigSource GetConfigSource() override { + ProxyConfigSource GetConfigSource() override { return PROXY_CONFIG_SOURCE_GSETTINGS; } - virtual bool GetString(StringSetting key, std::string* result) override { + bool GetString(StringSetting key, std::string* result) override { DCHECK(client_); switch (key) { case PROXY_MODE: @@ -654,7 +650,7 @@ class SettingGetterImplGSettings } return false; // Placate compiler. } - virtual bool GetBool(BoolSetting key, bool* result) override { + bool GetBool(BoolSetting key, bool* result) override { DCHECK(client_); switch (key) { case PROXY_USE_HTTP_PROXY: @@ -672,7 +668,7 @@ class SettingGetterImplGSettings } return false; // Placate compiler. } - virtual bool GetInt(IntSetting key, int* result) override { + bool GetInt(IntSetting key, int* result) override { DCHECK(client_); switch (key) { case PROXY_HTTP_PORT: @@ -686,8 +682,8 @@ class SettingGetterImplGSettings } return false; // Placate compiler. } - virtual bool GetStringList(StringListSetting key, - std::vector<std::string>* result) override { + bool GetStringList(StringListSetting key, + std::vector<std::string>* result) override { DCHECK(client_); switch (key) { case PROXY_IGNORE_HOSTS: @@ -696,14 +692,12 @@ class SettingGetterImplGSettings return false; // Placate compiler. } - virtual bool BypassListIsReversed() override { + bool BypassListIsReversed() override { // This is a KDE-specific setting. return false; } - virtual bool MatchHostsUsingSuffixMatching() override { - return false; - } + bool MatchHostsUsingSuffixMatching() override { return false; } private: bool GetStringByPath(GSettings* client, const char* key, @@ -916,7 +910,7 @@ class SettingGetterImplKDE : public ProxyConfigServiceLinux::SettingGetter, } } - virtual ~SettingGetterImplKDE() { + ~SettingGetterImplKDE() override { // inotify_fd_ should have been closed before now, from // Delegate::OnDestroy(), while running on the file thread. However // on exiting the process, it may happen that Delegate::OnDestroy() @@ -929,9 +923,8 @@ class SettingGetterImplKDE : public ProxyConfigServiceLinux::SettingGetter, DCHECK(inotify_fd_ < 0); } - virtual bool Init( - const scoped_refptr<base::SingleThreadTaskRunner>& glib_task_runner, - const scoped_refptr<base::SingleThreadTaskRunner>& file_task_runner) + bool Init(const scoped_refptr<base::SingleThreadTaskRunner>& glib_task_runner, + const scoped_refptr<base::SingleThreadTaskRunner>& file_task_runner) override { // This has to be called on the UI thread (http://crbug.com/69057). base::ThreadRestrictions::ScopedAllowIO allow_io; @@ -956,7 +949,7 @@ class SettingGetterImplKDE : public ProxyConfigServiceLinux::SettingGetter, return true; } - virtual void ShutDown() override { + void ShutDown() override { if (inotify_fd_ >= 0) { ResetCachedSettings(); inotify_watcher_.StopWatchingFileDescriptor(); @@ -965,7 +958,7 @@ class SettingGetterImplKDE : public ProxyConfigServiceLinux::SettingGetter, } } - virtual bool SetUpNotifications( + bool SetUpNotifications( ProxyConfigServiceLinux::Delegate* delegate) override { DCHECK(inotify_fd_ >= 0); DCHECK(file_task_runner_->BelongsToCurrentThread()); @@ -989,42 +982,40 @@ class SettingGetterImplKDE : public ProxyConfigServiceLinux::SettingGetter, return true; } - virtual const scoped_refptr<base::SingleThreadTaskRunner>& - GetNotificationTaskRunner() override { + const scoped_refptr<base::SingleThreadTaskRunner>& GetNotificationTaskRunner() + override { return file_task_runner_; } // Implement base::MessagePumpLibevent::Watcher. - virtual void OnFileCanReadWithoutBlocking(int fd) override { + void OnFileCanReadWithoutBlocking(int fd) override { DCHECK_EQ(fd, inotify_fd_); DCHECK(file_task_runner_->BelongsToCurrentThread()); OnChangeNotification(); } - virtual void OnFileCanWriteWithoutBlocking(int fd) override { - NOTREACHED(); - } + void OnFileCanWriteWithoutBlocking(int fd) override { NOTREACHED(); } - virtual ProxyConfigSource GetConfigSource() override { + ProxyConfigSource GetConfigSource() override { return PROXY_CONFIG_SOURCE_KDE; } - virtual bool GetString(StringSetting key, std::string* result) override { + bool GetString(StringSetting key, std::string* result) override { string_map_type::iterator it = string_table_.find(key); if (it == string_table_.end()) return false; *result = it->second; return true; } - virtual bool GetBool(BoolSetting key, bool* result) override { + bool GetBool(BoolSetting key, bool* result) override { // We don't ever have any booleans. return false; } - virtual bool GetInt(IntSetting key, int* result) override { + bool GetInt(IntSetting key, int* result) override { // We don't ever have any integers. (See AddProxy() below about ports.) return false; } - virtual bool GetStringList(StringListSetting key, - std::vector<std::string>* result) override { + bool GetStringList(StringListSetting key, + std::vector<std::string>* result) override { strings_map_type::iterator it = strings_table_.find(key); if (it == strings_table_.end()) return false; @@ -1032,13 +1023,9 @@ class SettingGetterImplKDE : public ProxyConfigServiceLinux::SettingGetter, return true; } - virtual bool BypassListIsReversed() override { - return reversed_bypass_list_; - } + bool BypassListIsReversed() override { return reversed_bypass_list_; } - virtual bool MatchHostsUsingSuffixMatching() override { - return true; - } + bool MatchHostsUsingSuffixMatching() override { return true; } private: void ResetCachedSettings() { diff --git a/net/proxy/proxy_config_service_linux.h b/net/proxy/proxy_config_service_linux.h index a8438c2..3d05898 100644 --- a/net/proxy/proxy_config_service_linux.h +++ b/net/proxy/proxy_config_service_linux.h @@ -280,7 +280,7 @@ class NET_EXPORT_PRIVATE ProxyConfigServiceLinux : public ProxyConfigService { ProxyConfigServiceLinux(base::Environment* env_var_getter, SettingGetter* setting_getter); - virtual ~ProxyConfigServiceLinux(); + ~ProxyConfigServiceLinux() override; void SetupAndFetchInitialConfig( const scoped_refptr<base::SingleThreadTaskRunner>& glib_task_runner, @@ -296,9 +296,9 @@ class NET_EXPORT_PRIVATE ProxyConfigServiceLinux : public ProxyConfigService { // ProxyConfigService methods: // Called from IO thread. - virtual void AddObserver(Observer* observer) override; - virtual void RemoveObserver(Observer* observer) override; - virtual ProxyConfigService::ConfigAvailability GetLatestProxyConfig( + void AddObserver(Observer* observer) override; + void RemoveObserver(Observer* observer) override; + ProxyConfigService::ConfigAvailability GetLatestProxyConfig( ProxyConfig* config) override; private: diff --git a/net/proxy/proxy_config_service_linux_unittest.cc b/net/proxy/proxy_config_service_linux_unittest.cc index 3e6b966..2c1995c 100644 --- a/net/proxy/proxy_config_service_linux_unittest.cc +++ b/net/proxy/proxy_config_service_linux_unittest.cc @@ -107,7 +107,7 @@ class MockEnvironment : public base::Environment { } // Begin base::Environment implementation. - virtual bool GetVar(const char* variable_name, std::string* result) override { + bool GetVar(const char* variable_name, std::string* result) override { std::map<std::string, const char**>::iterator it = table.find(variable_name); if (it != table.end() && *(it->second) != NULL) { @@ -118,13 +118,13 @@ class MockEnvironment : public base::Environment { return false; } - virtual bool SetVar(const char* variable_name, const std::string& new_value) - override { + bool SetVar(const char* variable_name, + const std::string& new_value) override { ADD_FAILURE(); return false; } - virtual bool UnSetVar(const char* variable_name) override { + bool UnSetVar(const char* variable_name) override { ADD_FAILURE(); return false; } @@ -175,31 +175,30 @@ class MockSettingGetter values = zero_values; } - virtual bool Init( - const scoped_refptr<base::SingleThreadTaskRunner>& glib_task_runner, - const scoped_refptr<base::SingleThreadTaskRunner>& file_task_runner) + bool Init(const scoped_refptr<base::SingleThreadTaskRunner>& glib_task_runner, + const scoped_refptr<base::SingleThreadTaskRunner>& file_task_runner) override { task_runner_ = glib_task_runner; return true; } - virtual void ShutDown() override {} + void ShutDown() override {} - virtual bool SetUpNotifications(ProxyConfigServiceLinux::Delegate* delegate) - override { + bool SetUpNotifications( + ProxyConfigServiceLinux::Delegate* delegate) override { return true; } - virtual const scoped_refptr<base::SingleThreadTaskRunner>& - GetNotificationTaskRunner() override { + const scoped_refptr<base::SingleThreadTaskRunner>& GetNotificationTaskRunner() + override { return task_runner_; } - virtual ProxyConfigSource GetConfigSource() override { + ProxyConfigSource GetConfigSource() override { return PROXY_CONFIG_SOURCE_TEST; } - virtual bool GetString(StringSetting key, std::string* result) override { + bool GetString(StringSetting key, std::string* result) override { const char* value = strings_table.Get(key); if (value) { *result = value; @@ -208,7 +207,7 @@ class MockSettingGetter return false; } - virtual bool GetBool(BoolSetting key, bool* result) override { + bool GetBool(BoolSetting key, bool* result) override { BoolSettingValue value = bools_table.Get(key); switch (value) { case UNSET: @@ -222,26 +221,22 @@ class MockSettingGetter return true; } - virtual bool GetInt(IntSetting key, int* result) override { + bool GetInt(IntSetting key, int* result) override { // We don't bother to distinguish unset keys from 0 values. *result = ints_table.Get(key); return true; } - virtual bool GetStringList(StringListSetting key, - std::vector<std::string>* result) override { + bool GetStringList(StringListSetting key, + std::vector<std::string>* result) override { *result = string_lists_table.Get(key); // We don't bother to distinguish unset keys from empty lists. return !result->empty(); } - virtual bool BypassListIsReversed() override { - return false; - } + bool BypassListIsReversed() override { return false; } - virtual bool MatchHostsUsingSuffixMatching() override { - return false; - } + bool MatchHostsUsingSuffixMatching() override { return false; } // Intentionally public, for convenience when setting up a test. GConfValues values; @@ -355,7 +350,7 @@ namespace net { // must use the same test fixture class (also "ProxyConfigServiceLinuxTest"). class ProxyConfigServiceLinuxTest : public PlatformTest { protected: - virtual void SetUp() override { + void SetUp() override { PlatformTest::SetUp(); // Set up a temporary KDE home directory. std::string prefix("ProxyConfigServiceLinuxTest_user_home"); @@ -372,7 +367,7 @@ class ProxyConfigServiceLinuxTest : public PlatformTest { kioslaverc4_ = kde4_config_.Append(FILE_PATH_LITERAL("kioslaverc")); } - virtual void TearDown() override { + void TearDown() override { // Delete the temporary KDE home directory. base::DeleteFile(user_home_, true); PlatformTest::TearDown(); diff --git a/net/proxy/proxy_resolver_v8_tracing_unittest.cc b/net/proxy/proxy_resolver_v8_tracing_unittest.cc index 0c16a1a..31188ca 100644 --- a/net/proxy/proxy_resolver_v8_tracing_unittest.cc +++ b/net/proxy/proxy_resolver_v8_tracing_unittest.cc @@ -31,7 +31,7 @@ namespace { class ProxyResolverV8TracingTest : public testing::Test { public: - virtual void TearDown() override { + void TearDown() override { // Drain any pending messages, which may be left over from cancellation. // This way they get reliably run as part of the current test, rather than // spilling into the next test's execution. diff --git a/net/proxy/proxy_script_decider_unittest.cc b/net/proxy/proxy_script_decider_unittest.cc index ee2958c..8914f5b 100644 --- a/net/proxy/proxy_script_decider_unittest.cc +++ b/net/proxy/proxy_script_decider_unittest.cc @@ -310,7 +310,7 @@ class ProxyScriptDeciderQuickCheckTest : public ::testing::Test { : rule_(rules_.AddSuccessRule("http://wpad/wpad.dat")), fetcher_(&rules_) { } - virtual void SetUp() override { + void SetUp() override { request_context_.set_host_resolver(&resolver_); fetcher_.SetRequestContext(&request_context_); config_.set_auto_detect(true); diff --git a/net/proxy/proxy_service_unittest.cc b/net/proxy/proxy_service_unittest.cc index aab3de3..cfaaccf 100644 --- a/net/proxy/proxy_service_unittest.cc +++ b/net/proxy/proxy_service_unittest.cc @@ -98,13 +98,13 @@ class ImmediateAfterActivityPollPolicy : public ProxyService::PacPollPolicy { // are careful to avoid timing problems. class ProxyServiceTest : public testing::Test { protected: - virtual void SetUp() override { + void SetUp() override { testing::Test::SetUp(); previous_policy_ = ProxyService::set_pac_script_poll_policy(&never_poll_policy_); } - virtual void TearDown() override { + void TearDown() override { // Restore the original policy. ProxyService::set_pac_script_poll_policy(previous_policy_); testing::Test::TearDown(); diff --git a/net/quic/congestion_control/hybrid_slow_start_test.cc b/net/quic/congestion_control/hybrid_slow_start_test.cc index bea5840..dd74933 100644 --- a/net/quic/congestion_control/hybrid_slow_start_test.cc +++ b/net/quic/congestion_control/hybrid_slow_start_test.cc @@ -17,9 +17,7 @@ class HybridSlowStartTest : public ::testing::Test { : one_ms_(QuicTime::Delta::FromMilliseconds(1)), rtt_(QuicTime::Delta::FromMilliseconds(60)) { } - virtual void SetUp() { - slow_start_.reset(new HybridSlowStart(&clock_)); - } + void SetUp() override { slow_start_.reset(new HybridSlowStart(&clock_)); } const QuicTime::Delta one_ms_; const QuicTime::Delta rtt_; MockClock clock_; diff --git a/net/quic/congestion_control/leaky_bucket_test.cc b/net/quic/congestion_control/leaky_bucket_test.cc index 977ef94..8387ada 100644 --- a/net/quic/congestion_control/leaky_bucket_test.cc +++ b/net/quic/congestion_control/leaky_bucket_test.cc @@ -13,7 +13,7 @@ namespace test { class LeakyBucketTest : public ::testing::Test { protected: - virtual void SetUp() { + void SetUp() override { leaky_bucket_.reset(new LeakyBucket(QuicBandwidth::Zero())); } MockClock clock_; diff --git a/net/quic/congestion_control/pacing_sender_test.cc b/net/quic/congestion_control/pacing_sender_test.cc index 0be0b0a..a7838b9 100644 --- a/net/quic/congestion_control/pacing_sender_test.cc +++ b/net/quic/congestion_control/pacing_sender_test.cc @@ -35,7 +35,7 @@ class PacingSenderTest : public ::testing::Test { clock_.AdvanceTime(QuicTime::Delta::FromMilliseconds(9)); } - virtual ~PacingSenderTest() {} + ~PacingSenderTest() override {} void CheckPacketIsSentImmediately() { // In order for the packet to be sendable, the underlying sender must diff --git a/net/quic/congestion_control/tcp_receiver_test.cc b/net/quic/congestion_control/tcp_receiver_test.cc index e074fdf..833631e 100644 --- a/net/quic/congestion_control/tcp_receiver_test.cc +++ b/net/quic/congestion_control/tcp_receiver_test.cc @@ -13,9 +13,7 @@ namespace test { class QuicTcpReceiverTest : public ::testing::Test { protected: - virtual void SetUp() { - receiver_.reset(new TcpReceiver()); - } + void SetUp() override { receiver_.reset(new TcpReceiver()); } scoped_ptr<TcpReceiver> receiver_; }; diff --git a/net/quic/crypto/aes_128_gcm_12_decrypter.h b/net/quic/crypto/aes_128_gcm_12_decrypter.h index 3de537e..0f7f1d1 100644 --- a/net/quic/crypto/aes_128_gcm_12_decrypter.h +++ b/net/quic/crypto/aes_128_gcm_12_decrypter.h @@ -28,10 +28,10 @@ class NET_EXPORT_PRIVATE Aes128Gcm12Decrypter : public AeadBaseDecrypter { #if !defined(USE_OPENSSL) protected: // AeadBaseDecrypter methods: - virtual void FillAeadParams(base::StringPiece nonce, - base::StringPiece associated_data, - size_t auth_tag_size, - AeadParams* aead_params) const override; + void FillAeadParams(base::StringPiece nonce, + base::StringPiece associated_data, + size_t auth_tag_size, + AeadParams* aead_params) const override; #endif private: diff --git a/net/quic/crypto/aes_128_gcm_12_encrypter.h b/net/quic/crypto/aes_128_gcm_12_encrypter.h index bff3ec5..2b432fb 100644 --- a/net/quic/crypto/aes_128_gcm_12_encrypter.h +++ b/net/quic/crypto/aes_128_gcm_12_encrypter.h @@ -28,10 +28,10 @@ class NET_EXPORT_PRIVATE Aes128Gcm12Encrypter : public AeadBaseEncrypter { #if !defined(USE_OPENSSL) protected: // AeadBaseEncrypter methods: - virtual void FillAeadParams(base::StringPiece nonce, - base::StringPiece associated_data, - size_t auth_tag_size, - AeadParams* aead_params) const override; + void FillAeadParams(base::StringPiece nonce, + base::StringPiece associated_data, + size_t auth_tag_size, + AeadParams* aead_params) const override; #endif private: diff --git a/net/quic/crypto/chacha20_poly1305_decrypter.h b/net/quic/crypto/chacha20_poly1305_decrypter.h index 04f5341..7d81d70 100644 --- a/net/quic/crypto/chacha20_poly1305_decrypter.h +++ b/net/quic/crypto/chacha20_poly1305_decrypter.h @@ -32,10 +32,10 @@ class NET_EXPORT_PRIVATE ChaCha20Poly1305Decrypter : public AeadBaseDecrypter { #if !defined(USE_OPENSSL) protected: // AeadBaseDecrypter methods: - virtual void FillAeadParams(base::StringPiece nonce, - base::StringPiece associated_data, - size_t auth_tag_size, - AeadParams* aead_params) const override; + void FillAeadParams(base::StringPiece nonce, + base::StringPiece associated_data, + size_t auth_tag_size, + AeadParams* aead_params) const override; #endif private: diff --git a/net/quic/crypto/chacha20_poly1305_encrypter.h b/net/quic/crypto/chacha20_poly1305_encrypter.h index 1dcfd7c..6504970 100644 --- a/net/quic/crypto/chacha20_poly1305_encrypter.h +++ b/net/quic/crypto/chacha20_poly1305_encrypter.h @@ -32,10 +32,10 @@ class NET_EXPORT_PRIVATE ChaCha20Poly1305Encrypter : public AeadBaseEncrypter { #if !defined(USE_OPENSSL) protected: // AeadBaseEncrypter methods: - virtual void FillAeadParams(base::StringPiece nonce, - base::StringPiece associated_data, - size_t auth_tag_size, - AeadParams* aead_params) const override; + void FillAeadParams(base::StringPiece nonce, + base::StringPiece associated_data, + size_t auth_tag_size, + AeadParams* aead_params) const override; #endif private: diff --git a/net/quic/crypto/crypto_server_test.cc b/net/quic/crypto/crypto_server_test.cc index 1905109..74a3666 100644 --- a/net/quic/crypto/crypto_server_test.cc +++ b/net/quic/crypto/crypto_server_test.cc @@ -92,7 +92,7 @@ class CryptoServerTest : public ::testing::TestWithParam<TestParams> { GetParam().send_quic_crypto_reject_reason; } - virtual void SetUp() { + void SetUp() override { scoped_ptr<CryptoHandshakeMessage> msg( config_.AddDefaultConfig(rand_, &clock_, config_options_)); @@ -640,7 +640,7 @@ TEST(CryptoServerConfigGenerationTest, SCIDIsHashOfServerConfig) { class CryptoServerTestNoConfig : public CryptoServerTest { public: - virtual void SetUp() { + void SetUp() override { // Deliberately don't add a config so that we can test this situation. } }; @@ -662,7 +662,7 @@ class AsyncStrikeServerVerificationTest : public CryptoServerTest { AsyncStrikeServerVerificationTest() { } - virtual void SetUp() { + void SetUp() override { const string kOrbit = "12345678"; config_options_.orbit = kOrbit; strike_register_client_ = new DelayedVerifyStrikeRegisterClient( diff --git a/net/quic/crypto/local_strike_register_client_test.cc b/net/quic/crypto/local_strike_register_client_test.cc index a2c3ce2..b713c10 100644 --- a/net/quic/crypto/local_strike_register_client_test.cc +++ b/net/quic/crypto/local_strike_register_client_test.cc @@ -60,7 +60,7 @@ class LocalStrikeRegisterClientTest : public ::testing::Test { LocalStrikeRegisterClientTest() { } - virtual void SetUp() { + void SetUp() override { strike_register_.reset(new LocalStrikeRegisterClient( kMaxEntries, kCurrentTimeExternalSecs, kWindowSecs, kOrbit, net::StrikeRegister::NO_STARTUP_PERIOD_NEEDED)); diff --git a/net/quic/crypto/quic_crypto_server_config_test.cc b/net/quic/crypto/quic_crypto_server_config_test.cc index 0743a18..1e91dfc0 100644 --- a/net/quic/crypto/quic_crypto_server_config_test.cc +++ b/net/quic/crypto/quic_crypto_server_config_test.cc @@ -402,7 +402,7 @@ class CryptoServerConfigsTest : public ::testing::Test { config_(QuicCryptoServerConfig::TESTING, rand_), test_peer_(&config_) {} - virtual void SetUp() { + void SetUp() override { clock_.AdvanceTime(QuicTime::Delta::FromSeconds(1000)); } diff --git a/net/quic/quic_ack_notifier_test.cc b/net/quic/quic_ack_notifier_test.cc index 63bc254..fbc7e37 100644 --- a/net/quic/quic_ack_notifier_test.cc +++ b/net/quic/quic_ack_notifier_test.cc @@ -18,7 +18,7 @@ class QuicAckNotifierTest : public ::testing::Test { protected: QuicAckNotifierTest() : zero_(QuicTime::Delta::Zero()) {} - virtual void SetUp() { + void SetUp() override { delegate_ = new MockAckNotifierDelegate; notifier_.reset(new QuicAckNotifier(delegate_)); diff --git a/net/quic/quic_client_session_test.cc b/net/quic/quic_client_session_test.cc index b1cfe3d..cae2220 100644 --- a/net/quic/quic_client_session_test.cc +++ b/net/quic/quic_client_session_test.cc @@ -53,9 +53,7 @@ class QuicClientSessionTest : public ::testing::TestWithParam<QuicVersion> { &crypto_config_, nullptr); } - virtual void TearDown() override { - session_.CloseSessionOnError(ERR_ABORTED); - } + void TearDown() override { session_.CloseSessionOnError(ERR_ABORTED); } scoped_ptr<DatagramClientSocket> GetSocket() { socket_factory_.AddSocketDataProvider(&socket_data_); diff --git a/net/quic/quic_end_to_end_unittest.cc b/net/quic/quic_end_to_end_unittest.cc index 96833af..a3fa12b 100644 --- a/net/quic/quic_end_to_end_unittest.cc +++ b/net/quic/quic_end_to_end_unittest.cc @@ -49,21 +49,18 @@ class TestTransactionFactory : public HttpTransactionFactory { TestTransactionFactory(const HttpNetworkSession::Params& params) : session_(new HttpNetworkSession(params)) {} - virtual ~TestTransactionFactory() { - } + ~TestTransactionFactory() override {} // HttpTransactionFactory methods - virtual int CreateTransaction(RequestPriority priority, - scoped_ptr<HttpTransaction>* trans) override { + int CreateTransaction(RequestPriority priority, + scoped_ptr<HttpTransaction>* trans) override { trans->reset(new HttpNetworkTransaction(priority, session_.get())); return OK; } - virtual HttpCache* GetCache() override { - return nullptr; - } + HttpCache* GetCache() override { return nullptr; } - virtual HttpNetworkSession* GetSession() override { return session_.get(); }; + HttpNetworkSession* GetSession() override { return session_.get(); }; private: scoped_refptr<HttpNetworkSession> session_; @@ -105,7 +102,7 @@ class QuicEndToEndTest : public PlatformTest { return resolver; } - virtual void SetUp() { + void SetUp() override { QuicInMemoryCachePeer::ResetForTests(); StartServer(); @@ -123,7 +120,7 @@ class QuicEndToEndTest : public PlatformTest { transaction_factory_.reset(new TestTransactionFactory(params_)); } - virtual void TearDown() { + void TearDown() override { StopServer(); QuicInMemoryCachePeer::ResetForTests(); } diff --git a/net/quic/quic_network_transaction_unittest.cc b/net/quic/quic_network_transaction_unittest.cc index 9d12a01..ab698f3 100644 --- a/net/quic/quic_network_transaction_unittest.cc +++ b/net/quic/quic_network_transaction_unittest.cc @@ -121,12 +121,12 @@ class QuicNetworkTransactionTest clock_->AdvanceTime(QuicTime::Delta::FromMilliseconds(20)); } - virtual void SetUp() { + void SetUp() override { NetworkChangeNotifier::NotifyObserversOfIPAddressChangeForTests(); base::MessageLoop::current()->RunUntilIdle(); } - virtual void TearDown() { + void TearDown() override { NetworkChangeNotifier::NotifyObserversOfIPAddressChangeForTests(); // Empty the current queue. base::MessageLoop::current()->RunUntilIdle(); diff --git a/net/quic/test_tools/crypto_test_utils_nss.cc b/net/quic/test_tools/crypto_test_utils_nss.cc index 96fdd31..f427750 100644 --- a/net/quic/test_tools/crypto_test_utils_nss.cc +++ b/net/quic/test_tools/crypto_test_utils_nss.cc @@ -20,13 +20,11 @@ namespace test { class TestChannelIDSource : public ChannelIDSource { public: - virtual ~TestChannelIDSource() { - STLDeleteValues(&hostname_to_key_); - } + ~TestChannelIDSource() override { STLDeleteValues(&hostname_to_key_); } // ChannelIDSource implementation. - virtual QuicAsyncStatus GetChannelIDKey( + QuicAsyncStatus GetChannelIDKey( const string& hostname, scoped_ptr<ChannelIDKey>* channel_id_key, ChannelIDSourceCallback* /*callback*/) override { diff --git a/net/server/http_server_unittest.cc b/net/server/http_server_unittest.cc index 5da2c0f..c25c03e 100644 --- a/net/server/http_server_unittest.cc +++ b/net/server/http_server_unittest.cc @@ -181,7 +181,7 @@ class HttpServerTest : public testing::Test, public: HttpServerTest() : quit_after_request_count_(0) {} - virtual void SetUp() override { + void SetUp() override { scoped_ptr<ServerSocket> server_socket( new TCPServerSocket(NULL, net::NetLog::Source())); server_socket->ListenWithAddressAndPort("127.0.0.1", 0, 1); diff --git a/net/socket/client_socket_pool_base_unittest.cc b/net/socket/client_socket_pool_base_unittest.cc index e2666fb..c4a2845 100644 --- a/net/socket/client_socket_pool_base_unittest.cc +++ b/net/socket/client_socket_pool_base_unittest.cc @@ -667,7 +667,7 @@ class ClientSocketPoolBaseTest : public testing::Test { internal::ClientSocketPoolBaseHelper::cleanup_timer_enabled(); } - virtual ~ClientSocketPoolBaseTest() { + ~ClientSocketPoolBaseTest() override { internal::ClientSocketPoolBaseHelper::set_connect_backup_jobs_enabled( connect_backup_jobs_enabled_); internal::ClientSocketPoolBaseHelper::set_cleanup_timer_enabled( diff --git a/net/socket/deterministic_socket_data_unittest.cc b/net/socket/deterministic_socket_data_unittest.cc index 9a2d833..bdeba2b 100644 --- a/net/socket/deterministic_socket_data_unittest.cc +++ b/net/socket/deterministic_socket_data_unittest.cc @@ -29,7 +29,7 @@ class DeterministicSocketDataTest : public PlatformTest { public: DeterministicSocketDataTest(); - virtual void TearDown(); + void TearDown() override; void ReentrantReadCallback(int len, int rv); void ReentrantWriteCallback(const char* data, int len, int rv); diff --git a/net/socket/socks5_client_socket_unittest.cc b/net/socket/socks5_client_socket_unittest.cc index 78f2ac4..c474a0b 100644 --- a/net/socket/socks5_client_socket_unittest.cc +++ b/net/socket/socks5_client_socket_unittest.cc @@ -40,7 +40,7 @@ class SOCKS5ClientSocketTest : public PlatformTest { int port, NetLog* net_log); - virtual void SetUp(); + void SetUp() override; protected: const uint16 kNwPort; diff --git a/net/socket/socks_client_socket_pool_unittest.cc b/net/socket/socks_client_socket_pool_unittest.cc index ec2230c..391d31b 100644 --- a/net/socket/socks_client_socket_pool_unittest.cc +++ b/net/socket/socks_client_socket_pool_unittest.cc @@ -103,7 +103,7 @@ class SOCKSClientSocketPoolTest : public testing::Test { NULL) { } - virtual ~SOCKSClientSocketPoolTest() {} + ~SOCKSClientSocketPoolTest() override {} int StartRequestV5(const std::string& group_name, RequestPriority priority) { return test_base_.StartRequestUsingPool( diff --git a/net/socket/socks_client_socket_unittest.cc b/net/socket/socks_client_socket_unittest.cc index ced7d9e4..fbb84f8 100644 --- a/net/socket/socks_client_socket_unittest.cc +++ b/net/socket/socks_client_socket_unittest.cc @@ -35,7 +35,7 @@ class SOCKSClientSocketTest : public PlatformTest { HostResolver* host_resolver, const std::string& hostname, int port, NetLog* net_log); - virtual void SetUp(); + void SetUp() override; protected: scoped_ptr<SOCKSClientSocket> user_sock_; diff --git a/net/socket/ssl_client_socket_nss.h b/net/socket/ssl_client_socket_nss.h index ccdbb81..0693ee8 100644 --- a/net/socket/ssl_client_socket_nss.h +++ b/net/socket/ssl_client_socket_nss.h @@ -65,53 +65,51 @@ class SSLClientSocketNSS : public SSLClientSocket { const HostPortPair& host_and_port, const SSLConfig& ssl_config, const SSLClientSocketContext& context); - virtual ~SSLClientSocketNSS(); + ~SSLClientSocketNSS() override; // SSLClientSocket implementation. - virtual std::string GetSessionCacheKey() const override; - virtual bool InSessionCache() const override; - virtual void SetHandshakeCompletionCallback( - const base::Closure& callback) override; - virtual void GetSSLCertRequestInfo( - SSLCertRequestInfo* cert_request_info) override; - virtual NextProtoStatus GetNextProto(std::string* proto) override; + std::string GetSessionCacheKey() const override; + bool InSessionCache() const override; + void SetHandshakeCompletionCallback(const base::Closure& callback) override; + void GetSSLCertRequestInfo(SSLCertRequestInfo* cert_request_info) override; + NextProtoStatus GetNextProto(std::string* proto) override; // SSLSocket implementation. - virtual int ExportKeyingMaterial(const base::StringPiece& label, - bool has_context, - const base::StringPiece& context, - unsigned char* out, - unsigned int outlen) override; - virtual int GetTLSUniqueChannelBinding(std::string* out) override; + int ExportKeyingMaterial(const base::StringPiece& label, + bool has_context, + const base::StringPiece& context, + unsigned char* out, + unsigned int outlen) override; + int GetTLSUniqueChannelBinding(std::string* out) override; // StreamSocket implementation. - virtual int Connect(const CompletionCallback& callback) override; - virtual void Disconnect() override; - virtual bool IsConnected() const override; - virtual bool IsConnectedAndIdle() const override; - virtual int GetPeerAddress(IPEndPoint* address) const override; - virtual int GetLocalAddress(IPEndPoint* address) const override; - virtual const BoundNetLog& NetLog() const override; - virtual void SetSubresourceSpeculation() override; - virtual void SetOmniboxSpeculation() override; - virtual bool WasEverUsed() const override; - virtual bool UsingTCPFastOpen() const override; - virtual bool GetSSLInfo(SSLInfo* ssl_info) override; + int Connect(const CompletionCallback& callback) override; + void Disconnect() override; + bool IsConnected() const override; + bool IsConnectedAndIdle() const override; + int GetPeerAddress(IPEndPoint* address) const override; + int GetLocalAddress(IPEndPoint* address) const override; + const BoundNetLog& NetLog() const override; + void SetSubresourceSpeculation() override; + void SetOmniboxSpeculation() override; + bool WasEverUsed() const override; + bool UsingTCPFastOpen() const override; + bool GetSSLInfo(SSLInfo* ssl_info) override; // Socket implementation. - virtual int Read(IOBuffer* buf, - int buf_len, - const CompletionCallback& callback) override; - virtual int Write(IOBuffer* buf, - int buf_len, - const CompletionCallback& callback) override; - virtual int SetReceiveBufferSize(int32 size) override; - virtual int SetSendBufferSize(int32 size) override; - virtual ChannelIDService* GetChannelIDService() const override; + int Read(IOBuffer* buf, + int buf_len, + const CompletionCallback& callback) override; + int Write(IOBuffer* buf, + int buf_len, + const CompletionCallback& callback) override; + int SetReceiveBufferSize(int32 size) override; + int SetSendBufferSize(int32 size) override; + ChannelIDService* GetChannelIDService() const override; protected: // SSLClientSocket implementation. - virtual scoped_refptr<X509Certificate> GetUnverifiedServerCertificateChain() + scoped_refptr<X509Certificate> GetUnverifiedServerCertificateChain() const override; private: diff --git a/net/socket/ssl_server_socket_nss.h b/net/socket/ssl_server_socket_nss.h index eddb543..d40b0965 100644 --- a/net/socket/ssl_server_socket_nss.h +++ b/net/socket/ssl_server_socket_nss.h @@ -28,42 +28,44 @@ class SSLServerSocketNSS : public SSLServerSocket { scoped_refptr<X509Certificate> certificate, crypto::RSAPrivateKey* key, const SSLConfig& ssl_config); - virtual ~SSLServerSocketNSS(); + ~SSLServerSocketNSS() override; // SSLServerSocket interface. - virtual int Handshake(const CompletionCallback& callback) override; + int Handshake(const CompletionCallback& callback) override; // SSLSocket interface. - virtual int ExportKeyingMaterial(const base::StringPiece& label, - bool has_context, - const base::StringPiece& context, - unsigned char* out, - unsigned int outlen) override; - virtual int GetTLSUniqueChannelBinding(std::string* out) override; + int ExportKeyingMaterial(const base::StringPiece& label, + bool has_context, + const base::StringPiece& context, + unsigned char* out, + unsigned int outlen) override; + int GetTLSUniqueChannelBinding(std::string* out) override; // Socket interface (via StreamSocket). - virtual int Read(IOBuffer* buf, int buf_len, - const CompletionCallback& callback) override; - virtual int Write(IOBuffer* buf, int buf_len, - const CompletionCallback& callback) override; - virtual int SetReceiveBufferSize(int32 size) override; - virtual int SetSendBufferSize(int32 size) override; + int Read(IOBuffer* buf, + int buf_len, + const CompletionCallback& callback) override; + int Write(IOBuffer* buf, + int buf_len, + const CompletionCallback& callback) override; + int SetReceiveBufferSize(int32 size) override; + int SetSendBufferSize(int32 size) override; // StreamSocket implementation. - virtual int Connect(const CompletionCallback& callback) override; - virtual void Disconnect() override; - virtual bool IsConnected() const override; - virtual bool IsConnectedAndIdle() const override; - virtual int GetPeerAddress(IPEndPoint* address) const override; - virtual int GetLocalAddress(IPEndPoint* address) const override; - virtual const BoundNetLog& NetLog() const override; - virtual void SetSubresourceSpeculation() override; - virtual void SetOmniboxSpeculation() override; - virtual bool WasEverUsed() const override; - virtual bool UsingTCPFastOpen() const override; - virtual bool WasNpnNegotiated() const override; - virtual NextProto GetNegotiatedProtocol() const override; - virtual bool GetSSLInfo(SSLInfo* ssl_info) override; + int Connect(const CompletionCallback& callback) override; + void Disconnect() override; + bool IsConnected() const override; + bool IsConnectedAndIdle() const override; + int GetPeerAddress(IPEndPoint* address) const override; + int GetLocalAddress(IPEndPoint* address) const override; + const BoundNetLog& NetLog() const override; + void SetSubresourceSpeculation() override; + void SetOmniboxSpeculation() override; + bool WasEverUsed() const override; + bool UsingTCPFastOpen() const override; + bool WasNpnNegotiated() const override; + NextProto GetNegotiatedProtocol() const override; + bool GetSSLInfo(SSLInfo* ssl_info) override; private: enum State { diff --git a/net/socket/tcp_listen_socket_unittest.cc b/net/socket/tcp_listen_socket_unittest.cc index 41c41f8..b586426 100644 --- a/net/socket/tcp_listen_socket_unittest.cc +++ b/net/socket/tcp_listen_socket_unittest.cc @@ -275,13 +275,13 @@ class TCPListenSocketTest : public PlatformTest { tester_ = NULL; } - virtual void SetUp() { + void SetUp() override { PlatformTest::SetUp(); tester_ = new TCPListenSocketTester(); tester_->SetUp(); } - virtual void TearDown() { + void TearDown() override { PlatformTest::TearDown(); tester_->TearDown(); tester_ = NULL; diff --git a/net/socket/transport_client_socket_pool_unittest.cc b/net/socket/transport_client_socket_pool_unittest.cc index e3e9873..c0687ef 100644 --- a/net/socket/transport_client_socket_pool_unittest.cc +++ b/net/socket/transport_client_socket_pool_unittest.cc @@ -57,7 +57,7 @@ class TransportClientSocketPoolTest : public testing::Test { NULL) { } - virtual ~TransportClientSocketPoolTest() { + ~TransportClientSocketPoolTest() override { internal::ClientSocketPoolBaseHelper::set_connect_backup_jobs_enabled( connect_backup_jobs_enabled_); } diff --git a/net/socket/transport_client_socket_unittest.cc b/net/socket/transport_client_socket_unittest.cc index ed68bf1..d01cbad 100644 --- a/net/socket/transport_client_socket_unittest.cc +++ b/net/socket/transport_client_socket_unittest.cc @@ -62,7 +62,7 @@ class TransportClientSocketTest void DidClose(StreamListenSocket* sock) override {} // Testcase hooks - virtual void SetUp(); + void SetUp() override; void CloseServerSocket() { // delete the connected_sock_, which will close it. diff --git a/net/socket/unix_domain_listen_socket_posix.h b/net/socket/unix_domain_listen_socket_posix.h index b8f428d..82ec342 100644 --- a/net/socket/unix_domain_listen_socket_posix.h +++ b/net/socket/unix_domain_listen_socket_posix.h @@ -103,10 +103,10 @@ class NET_EXPORT UnixDomainListenSocketWithAbstractNamespaceFactory const std::string& path, const std::string& fallback_path, const UnixDomainListenSocket::AuthCallback& auth_callback); - virtual ~UnixDomainListenSocketWithAbstractNamespaceFactory(); + ~UnixDomainListenSocketWithAbstractNamespaceFactory() override; // UnixDomainListenSocketFactory: - virtual scoped_ptr<StreamListenSocket> CreateAndListen( + scoped_ptr<StreamListenSocket> CreateAndListen( StreamListenSocket::Delegate* delegate) const override; private: diff --git a/net/socket/unix_domain_listen_socket_posix_unittest.cc b/net/socket/unix_domain_listen_socket_posix_unittest.cc index bfa9200..aaf3623 100644 --- a/net/socket/unix_domain_listen_socket_posix_unittest.cc +++ b/net/socket/unix_domain_listen_socket_posix_unittest.cc @@ -167,12 +167,12 @@ class UnixDomainListenSocketTestHelper : public testing::Test { return temp_dir_.path().Append(socket_name); } - virtual void SetUp() override { + void SetUp() override { event_manager_ = new EventManager(); socket_delegate_.reset(new TestListenSocketDelegate(event_manager_)); } - virtual void TearDown() override { + void TearDown() override { socket_.reset(); socket_delegate_.reset(); event_manager_ = NULL; diff --git a/net/socket/websocket_endpoint_lock_manager_unittest.cc b/net/socket/websocket_endpoint_lock_manager_unittest.cc index 01c9dbc..1626aa9 100644 --- a/net/socket/websocket_endpoint_lock_manager_unittest.cc +++ b/net/socket/websocket_endpoint_lock_manager_unittest.cc @@ -93,7 +93,7 @@ class WebSocketEndpointLockManagerTest : public ::testing::Test { protected: WebSocketEndpointLockManagerTest() : instance_(WebSocketEndpointLockManager::GetInstance()) {} - virtual ~WebSocketEndpointLockManagerTest() { + ~WebSocketEndpointLockManagerTest() override { // If this check fails then subsequent tests may fail. CHECK(instance_->IsEmpty()); } diff --git a/net/socket/websocket_transport_client_socket_pool_unittest.cc b/net/socket/websocket_transport_client_socket_pool_unittest.cc index 4d04c10..2189181 100644 --- a/net/socket/websocket_transport_client_socket_pool_unittest.cc +++ b/net/socket/websocket_transport_client_socket_pool_unittest.cc @@ -67,7 +67,7 @@ class WebSocketTransportClientSocketPoolTest : public testing::Test { &client_socket_factory_, NULL) {} - virtual ~WebSocketTransportClientSocketPoolTest() { + ~WebSocketTransportClientSocketPoolTest() override { ReleaseAllConnections(ClientSocketPoolTest::NO_KEEP_ALIVE); EXPECT_TRUE(WebSocketEndpointLockManager::GetInstance()->IsEmpty()); } diff --git a/net/socket_stream/socket_stream_unittest.cc b/net/socket_stream/socket_stream_unittest.cc index 6d47086..b5ee002 100644 --- a/net/socket_stream/socket_stream_unittest.cc +++ b/net/socket_stream/socket_stream_unittest.cc @@ -269,15 +269,13 @@ class TestSocketStreamNetworkDelegate : public TestNetworkDelegate { class SocketStreamTest : public PlatformTest { public: - virtual ~SocketStreamTest() {} - virtual void SetUp() { + ~SocketStreamTest() override {} + void SetUp() override { mock_socket_factory_.reset(); handshake_request_ = kWebSocketHandshakeRequest; handshake_response_ = kWebSocketHandshakeResponse; } - virtual void TearDown() { - mock_socket_factory_.reset(); - } + void TearDown() override { mock_socket_factory_.reset(); } virtual void SetWebSocketHandshakeMessage( const char* request, const char* response) { diff --git a/net/spdy/hpack_encoder_test.cc b/net/spdy/hpack_encoder_test.cc index 96bbadd..adeebd4 100644 --- a/net/spdy/hpack_encoder_test.cc +++ b/net/spdy/hpack_encoder_test.cc @@ -101,7 +101,7 @@ class HpackEncoderTest : public ::testing::Test { peer_(&encoder_), static_(peer_.table()->GetByIndex(1)) {} - virtual void SetUp() { + void SetUp() override { // Populate dynamic entries into the table fixture. For simplicity each // entry has name.size() + value.size() == 10. key_1_ = peer_.table()->TryAddEntry("key1", "value1"); diff --git a/net/spdy/hpack_input_stream_test.cc b/net/spdy/hpack_input_stream_test.cc index c5fef63..a88acb2 100644 --- a/net/spdy/hpack_input_stream_test.cc +++ b/net/spdy/hpack_input_stream_test.cc @@ -26,7 +26,7 @@ const size_t kLiteralBound = 1024; class HpackInputStreamTest : public ::testing::Test { public: - virtual void SetUp() { + void SetUp() override { std::vector<HpackHuffmanSymbol> code = HpackHuffmanCode(); EXPECT_TRUE(huffman_table_.Initialize(&code[0], code.size())); } diff --git a/net/spdy/hpack_round_trip_test.cc b/net/spdy/hpack_round_trip_test.cc index f5667b5..aae7584 100644 --- a/net/spdy/hpack_round_trip_test.cc +++ b/net/spdy/hpack_round_trip_test.cc @@ -28,7 +28,7 @@ class HpackRoundTripTest : public ::testing::Test { : encoder_(ObtainHpackHuffmanTable()), decoder_(ObtainHpackHuffmanTable()) {} - virtual void SetUp() { + void SetUp() override { // Use a small table size to tickle eviction handling. encoder_.ApplyHeaderTableSizeSetting(256); decoder_.ApplyHeaderTableSizeSetting(256); diff --git a/net/spdy/spdy_frame_builder_test.cc b/net/spdy/spdy_frame_builder_test.cc index 73cad24..3854558 100644 --- a/net/spdy/spdy_frame_builder_test.cc +++ b/net/spdy/spdy_frame_builder_test.cc @@ -12,9 +12,7 @@ namespace net { class SpdyFrameBuilderTest : public ::testing::TestWithParam<SpdyMajorVersion> { protected: - virtual void SetUp() { - spdy_version_ = GetParam(); - } + void SetUp() override { spdy_version_ = GetParam(); } // Major version of SPDY protocol to be used. SpdyMajorVersion spdy_version_; diff --git a/net/spdy/spdy_framer_test.cc b/net/spdy/spdy_framer_test.cc index d55e072..e7eb092 100644 --- a/net/spdy/spdy_framer_test.cc +++ b/net/spdy/spdy_framer_test.cc @@ -610,7 +610,7 @@ namespace net { class SpdyFramerTest : public ::testing::TestWithParam<SpdyMajorVersion> { protected: - virtual void SetUp() { + void SetUp() override { spdy_version_ = GetParam(); spdy_version_ch_ = static_cast<unsigned char>( SpdyConstants::SerializeMajorVersion(spdy_version_)); diff --git a/net/spdy/spdy_headers_block_parser_test.cc b/net/spdy/spdy_headers_block_parser_test.cc index c1d48de..d8cbe31 100644 --- a/net/spdy/spdy_headers_block_parser_test.cc +++ b/net/spdy/spdy_headers_block_parser_test.cc @@ -38,7 +38,7 @@ class SpdyHeadersBlockParserTest : virtual ~SpdyHeadersBlockParserTest() {} protected: - virtual void SetUp() { + void SetUp() override { // Create a parser using the mock handler. spdy_version_ = GetParam(); parser_.reset(new SpdyHeadersBlockParser(spdy_version_, &handler_)); diff --git a/net/spdy/spdy_http_stream_unittest.cc b/net/spdy/spdy_http_stream_unittest.cc index f1c1de2..0e8fdb0 100644 --- a/net/spdy/spdy_http_stream_unittest.cc +++ b/net/spdy/spdy_http_stream_unittest.cc @@ -79,7 +79,7 @@ class SpdyHttpStreamTest : public testing::Test, OrderedSocketData* data() { return data_.get(); } protected: - virtual void TearDown() override { + void TearDown() override { crypto::ECSignatureCreator::SetFactoryForTesting(NULL); base::MessageLoop::current()->RunUntilIdle(); } diff --git a/net/spdy/spdy_network_transaction_unittest.cc b/net/spdy/spdy_network_transaction_unittest.cc index 58dc73b..a68615f 100644 --- a/net/spdy/spdy_network_transaction_unittest.cc +++ b/net/spdy/spdy_network_transaction_unittest.cc @@ -127,7 +127,7 @@ class SpdyNetworkTransactionTest base::RunLoop().RunUntilIdle(); } - virtual void SetUp() { + void SetUp() override { google_get_request_initialized_ = false; google_post_request_initialized_ = false; google_chunked_post_request_initialized_ = false; diff --git a/net/spdy/spdy_protocol_test.cc b/net/spdy/spdy_protocol_test.cc index 0e49207..486a772 100644 --- a/net/spdy/spdy_protocol_test.cc +++ b/net/spdy/spdy_protocol_test.cc @@ -27,7 +27,7 @@ namespace net { class SpdyProtocolTest : public ::testing::TestWithParam<SpdyProtocolTestTypes> { protected: - virtual void SetUp() { + void SetUp() override { spdy_version_ = static_cast<SpdyMajorVersion>(GetParam()); } diff --git a/net/spdy/spdy_proxy_client_socket_unittest.cc b/net/spdy/spdy_proxy_client_socket_unittest.cc index 26785c6..92e446e 100644 --- a/net/spdy/spdy_proxy_client_socket_unittest.cc +++ b/net/spdy/spdy_proxy_client_socket_unittest.cc @@ -66,7 +66,7 @@ class SpdyProxyClientSocketTest public: SpdyProxyClientSocketTest(); - virtual void TearDown(); + void TearDown() override; protected: void Initialize(MockRead* reads, size_t reads_count, MockWrite* writes, diff --git a/net/spdy/spdy_session_unittest.cc b/net/spdy/spdy_session_unittest.cc index e56d9ef..c6447bf 100644 --- a/net/spdy/spdy_session_unittest.cc +++ b/net/spdy/spdy_session_unittest.cc @@ -121,9 +121,7 @@ class SpdySessionTest : public PlatformTest, HttpNetworkSession::NORMAL_SOCKET_POOL, old_max_group_sockets_); } - virtual void SetUp() override { - g_time_delta = base::TimeDelta(); - } + void SetUp() override { g_time_delta = base::TimeDelta(); } void CreateDeterministicNetworkSession() { http_session_ = diff --git a/net/spdy/spdy_stream_unittest.cc b/net/spdy/spdy_stream_unittest.cc index f754be6..a6926ab 100644 --- a/net/spdy/spdy_stream_unittest.cc +++ b/net/spdy/spdy_stream_unittest.cc @@ -57,9 +57,7 @@ class SpdyStreamTest : public ::testing::Test, return CreateInsecureSpdySession(session_, key, BoundNetLog()); } - virtual void TearDown() { - base::MessageLoop::current()->RunUntilIdle(); - } + void TearDown() override { base::MessageLoop::current()->RunUntilIdle(); } void RunResumeAfterUnstallRequestResponseTest( const UnstallFunction& unstall_function); diff --git a/net/spdy/spdy_websocket_stream_unittest.cc b/net/spdy/spdy_websocket_stream_unittest.cc index fd94969..fc54884 100644 --- a/net/spdy/spdy_websocket_stream_unittest.cc +++ b/net/spdy/spdy_websocket_stream_unittest.cc @@ -196,7 +196,7 @@ class SpdyWebSocketStreamTest created_stream_id_(0) {} virtual ~SpdyWebSocketStreamTest() {} - virtual void SetUp() { + void SetUp() override { host_port_pair_.set_host("example.com"); host_port_pair_.set_port(80); spdy_session_key_ = SpdySessionKey(host_port_pair_, @@ -208,9 +208,7 @@ class SpdyWebSocketStreamTest SETTINGS_FLAG_PERSISTED, spdy_settings_value_to_set_); } - virtual void TearDown() { - base::MessageLoop::current()->RunUntilIdle(); - } + void TearDown() override { base::MessageLoop::current()->RunUntilIdle(); } void Prepare(SpdyStreamId stream_id) { stream_id_ = stream_id; diff --git a/net/ssl/client_cert_store_nss.h b/net/ssl/client_cert_store_nss.h index 38895aa..f6d8099 100644 --- a/net/ssl/client_cert_store_nss.h +++ b/net/ssl/client_cert_store_nss.h @@ -27,12 +27,12 @@ class NET_EXPORT ClientCertStoreNSS : public ClientCertStore { explicit ClientCertStoreNSS( const PasswordDelegateFactory& password_delegate_factory); - virtual ~ClientCertStoreNSS(); + ~ClientCertStoreNSS() override; // ClientCertStore: - virtual void GetClientCerts(const SSLCertRequestInfo& cert_request_info, - CertificateList* selected_certs, - const base::Closure& callback) override; + void GetClientCerts(const SSLCertRequestInfo& cert_request_info, + CertificateList* selected_certs, + const base::Closure& callback) override; protected: // Examines the certificates in |cert_list| to find all certificates that diff --git a/net/test/embedded_test_server/embedded_test_server_unittest.cc b/net/test/embedded_test_server/embedded_test_server_unittest.cc index bbe321b..e102117 100644 --- a/net/test/embedded_test_server/embedded_test_server_unittest.cc +++ b/net/test/embedded_test_server/embedded_test_server_unittest.cc @@ -49,7 +49,7 @@ class EmbeddedTestServerTest: public testing::Test, io_thread_("io_thread") { } - virtual void SetUp() override { + void SetUp() override { base::Thread::Options thread_options; thread_options.message_loop_type = base::MessageLoop::TYPE_IO; ASSERT_TRUE(io_thread_.StartWithOptions(thread_options)); @@ -61,7 +61,7 @@ class EmbeddedTestServerTest: public testing::Test, ASSERT_TRUE(server_->InitializeAndWaitUntilReady()); } - virtual void TearDown() override { + void TearDown() override { ASSERT_TRUE(server_->ShutdownAndWaitUntilComplete()); } diff --git a/net/url_request/url_fetcher_impl_unittest.cc b/net/url_request/url_fetcher_impl_unittest.cc index cf52773..9b36621 100644 --- a/net/url_request/url_fetcher_impl_unittest.cc +++ b/net/url_request/url_fetcher_impl_unittest.cc @@ -108,7 +108,7 @@ class URLFetcherTest : public testing::Test, protected: // testing::Test: - virtual void SetUp() override { + void SetUp() override { testing::Test::SetUp(); context_.reset(new ThrottlingTestURLRequestContext()); @@ -120,7 +120,7 @@ class URLFetcherTest : public testing::Test, #endif } - virtual void TearDown() override { + void TearDown() override { #if defined(USE_NSS) || defined(OS_IOS) ShutdownNSSHttpIO(); #endif @@ -141,7 +141,7 @@ class URLFetcherTest : public testing::Test, class URLFetcherMockDnsTest : public URLFetcherTest { public: // testing::Test: - virtual void SetUp() override; + void SetUp() override; // URLFetcherTest: void CreateFetcher(const GURL& url) override; @@ -347,7 +347,7 @@ class URLFetcherSocketAddressTest : public URLFetcherTest { class URLFetcherStopOnRedirectTest : public URLFetcherTest { public: URLFetcherStopOnRedirectTest(); - virtual ~URLFetcherStopOnRedirectTest(); + ~URLFetcherStopOnRedirectTest() override; // URLFetcherTest: void CreateFetcher(const GURL& url) override; diff --git a/net/url_request/url_fetcher_response_writer_unittest.cc b/net/url_request/url_fetcher_response_writer_unittest.cc index 71cb671..e9f9380 100644 --- a/net/url_request/url_fetcher_response_writer_unittest.cc +++ b/net/url_request/url_fetcher_response_writer_unittest.cc @@ -23,7 +23,7 @@ const char kData[] = "Hello!"; class URLFetcherStringWriterTest : public PlatformTest { protected: - virtual void SetUp() override { + void SetUp() override { writer_.reset(new URLFetcherStringWriter); buf_ = new StringIOBuffer(kData); } @@ -54,7 +54,7 @@ TEST_F(URLFetcherStringWriterTest, Basic) { class URLFetcherFileWriterTest : public PlatformTest { protected: - virtual void SetUp() override { + void SetUp() override { ASSERT_TRUE(temp_dir_.CreateUniqueTempDir()); file_path_ = temp_dir_.path().AppendASCII("test.txt"); writer_.reset(new URLFetcherFileWriter( @@ -144,7 +144,7 @@ TEST_F(URLFetcherFileWriterTest, DisownFile) { class URLFetcherFileWriterTemporaryFileTest : public PlatformTest { protected: - virtual void SetUp() override { + void SetUp() override { writer_.reset(new URLFetcherFileWriter( base::MessageLoopProxy::current(), base::FilePath())); buf_ = new StringIOBuffer(kData); diff --git a/net/url_request/url_request_ftp_job_unittest.cc b/net/url_request/url_request_ftp_job_unittest.cc index 5f41edc..fa11d55 100644 --- a/net/url_request/url_request_ftp_job_unittest.cc +++ b/net/url_request/url_request_ftp_job_unittest.cc @@ -217,7 +217,7 @@ class URLRequestFtpJobTest : public testing::Test { &ftp_transaction_factory_) { } - virtual ~URLRequestFtpJobTest() { + ~URLRequestFtpJobTest() override { // Clean up any remaining tasks that mess up unrelated tests. base::RunLoop run_loop; run_loop.RunUntilIdle(); diff --git a/net/url_request/url_request_throttler_unittest.cc b/net/url_request/url_request_throttler_unittest.cc index 5a309b9..1cda5a6 100644 --- a/net/url_request/url_request_throttler_unittest.cc +++ b/net/url_request/url_request_throttler_unittest.cc @@ -172,7 +172,7 @@ class URLRequestThrottlerEntryTest : public testing::Test { : request_(context_.CreateRequest(GURL(), DEFAULT_PRIORITY, NULL, NULL)) { } - virtual void SetUp(); + void SetUp() override; TimeTicks now_; MockURLRequestThrottlerManager manager_; // Dummy object, not used. @@ -355,9 +355,7 @@ class URLRequestThrottlerManagerTest : public testing::Test { : request_(context_.CreateRequest(GURL(), DEFAULT_PRIORITY, NULL, NULL)) { } - virtual void SetUp() { - request_->SetLoadFlags(0); - } + void SetUp() override { request_->SetLoadFlags(0); } void ExpectEntryAllowsAllOnErrorIfOptedOut( URLRequestThrottlerEntryInterface* entry, diff --git a/net/url_request/url_request_unittest.cc b/net/url_request/url_request_unittest.cc index 700b070..d900069 100644 --- a/net/url_request/url_request_unittest.cc +++ b/net/url_request/url_request_unittest.cc @@ -615,7 +615,7 @@ class URLRequestTest : public PlatformTest { default_context_.set_job_factory(&job_factory_); default_context_.Init(); } - virtual ~URLRequestTest() { + ~URLRequestTest() override { // URLRequestJobs may post clean-up tasks on destruction. base::RunLoop().RunUntilIdle(); } @@ -6452,7 +6452,7 @@ class HTTPSRequestTest : public testing::Test { default_context_.set_network_delegate(&default_network_delegate_); default_context_.Init(); } - virtual ~HTTPSRequestTest() {} + ~HTTPSRequestTest() override {} protected: TestNetworkDelegate default_network_delegate_; // Must outlive URLRequest. @@ -7125,7 +7125,7 @@ class FallbackTestURLRequestContext : public TestURLRequestContext { class HTTPSFallbackTest : public testing::Test { public: HTTPSFallbackTest() : context_(true) {} - virtual ~HTTPSFallbackTest() {} + ~HTTPSFallbackTest() override {} protected: void DoFallbackTest(const SpawnedTestServer::SSLOptions& ssl_options) { @@ -7377,7 +7377,7 @@ class HTTPSSessionTest : public testing::Test { default_context_.set_cert_verifier(&cert_verifier_); default_context_.Init(); } - virtual ~HTTPSSessionTest() {} + ~HTTPSSessionTest() override {} protected: MockCertVerifier cert_verifier_; @@ -7476,7 +7476,7 @@ class HTTPSOCSPTest : public HTTPSRequestTest { kOCSPTestCertPolicy)) { } - virtual void SetUp() override { + void SetUp() override { SetupContext(&context_); context_.Init(); @@ -7513,7 +7513,7 @@ class HTTPSOCSPTest : public HTTPSRequestTest { *out_cert_status = r->ssl_info().cert_status; } - virtual ~HTTPSOCSPTest() { + ~HTTPSOCSPTest() override { #if defined(USE_NSS) || defined(OS_IOS) ShutdownNSSHttpIO(); #endif diff --git a/net/websockets/websocket_basic_stream_test.cc b/net/websockets/websocket_basic_stream_test.cc index 92b7d3f..2955ad6 100644 --- a/net/websockets/websocket_basic_stream_test.cc +++ b/net/websockets/websocket_basic_stream_test.cc @@ -110,7 +110,7 @@ class WebSocketBasicStreamSocketTest : public WebSocketBasicStreamTest { generator_(&GenerateNulMaskingKey), expect_all_io_to_complete_(true) {} - virtual ~WebSocketBasicStreamSocketTest() { + ~WebSocketBasicStreamSocketTest() override { // stream_ has a reference to socket_data_ (via MockTCPClientSocket) and so // should be destroyed first. stream_.reset(); @@ -237,7 +237,7 @@ class WebSocketBasicStreamSocketWriteTest protected: // All write tests use the same frame, so it is easiest to create it during // test creation. - virtual void SetUp() override { PrepareWriteFrame(); } + void SetUp() override { PrepareWriteFrame(); } // Creates a WebSocketFrame with a wire format matching kWriteFrame and adds // it to |frames_|. diff --git a/net/websockets/websocket_channel_test.cc b/net/websockets/websocket_channel_test.cc index 15163de..1ffe1e9 100644 --- a/net/websockets/websocket_channel_test.cc +++ b/net/websockets/websocket_channel_test.cc @@ -934,7 +934,7 @@ class WebSocketChannelEventInterfaceTest : public WebSocketChannelTest { .WillByDefault(Return(CHANNEL_DELETED)); } - virtual ~WebSocketChannelEventInterfaceTest() { + ~WebSocketChannelEventInterfaceTest() override { DefaultValue<ChannelState>::Clear(); } @@ -969,7 +969,7 @@ class WebSocketChannelStreamTest : public WebSocketChannelTest { class WebSocketChannelSendUtf8Test : public WebSocketChannelEventInterfaceTest { public: - virtual void SetUp() { + void SetUp() override { set_stream(make_scoped_ptr(new WriteableFakeWebSocketStream)); // For the purpose of the tests using this fixture, it doesn't matter // whether these methods are called or not. @@ -999,7 +999,7 @@ class WebSocketChannelFlowControlTest // mock WebSocketStream. class WebSocketChannelReceiveUtf8Test : public WebSocketChannelStreamTest { public: - virtual void SetUp() { + void SetUp() override { // For the purpose of the tests using this fixture, it doesn't matter // whether these methods are called or not. EXPECT_CALL(*mock_stream_, GetSubProtocol()).Times(AnyNumber()); diff --git a/net/websockets/websocket_deflate_stream_test.cc b/net/websockets/websocket_deflate_stream_test.cc index 1b0d123..c30ab32 100644 --- a/net/websockets/websocket_deflate_stream_test.cc +++ b/net/websockets/websocket_deflate_stream_test.cc @@ -212,9 +212,9 @@ class WebSocketDeflateStreamTest : public ::testing::Test { WebSocketDeflateStreamTest() : mock_stream_(NULL), predictor_(NULL) {} - virtual ~WebSocketDeflateStreamTest() {} + ~WebSocketDeflateStreamTest() override {} - virtual void SetUp() { + void SetUp() override { Initialize(WebSocketDeflater::TAKE_OVER_CONTEXT, kWindowBits); } @@ -245,9 +245,9 @@ class WebSocketDeflateStreamWithDoNotTakeOverContextTest : public WebSocketDeflateStreamTest { public: WebSocketDeflateStreamWithDoNotTakeOverContextTest() {} - virtual ~WebSocketDeflateStreamWithDoNotTakeOverContextTest() {} + ~WebSocketDeflateStreamWithDoNotTakeOverContextTest() override {} - virtual void SetUp() { + void SetUp() override { Initialize(WebSocketDeflater::DO_NOT_TAKE_OVER_CONTEXT, kWindowBits); } }; @@ -256,10 +256,10 @@ class WebSocketDeflateStreamWithClientWindowBitsTest : public WebSocketDeflateStreamTest { public: WebSocketDeflateStreamWithClientWindowBitsTest() {} - virtual ~WebSocketDeflateStreamWithClientWindowBitsTest() {} + ~WebSocketDeflateStreamWithClientWindowBitsTest() override {} // Overridden to postpone the call to Initialize(). - virtual void SetUp() {} + void SetUp() override {} // This needs to be called explicitly from the tests. void SetUpWithWindowBits(int window_bits) { diff --git a/net/websockets/websocket_job_test.cc b/net/websockets/websocket_job_test.cc index f78a081..c84af8f 100644 --- a/net/websockets/websocket_job_test.cc +++ b/net/websockets/websocket_job_test.cc @@ -391,12 +391,12 @@ class WebSocketJobTest : public PlatformTest, : spdy_util_(GetParam()), enable_websocket_over_spdy_(false) {} - virtual void SetUp() override { + void SetUp() override { stream_type_ = STREAM_INVALID; cookie_store_ = new MockCookieStore; context_.reset(new MockURLRequestContext(cookie_store_.get())); } - virtual void TearDown() override { + void TearDown() override { cookie_store_ = NULL; context_.reset(); websocket_ = NULL; diff --git a/net/websockets/websocket_stream_test.cc b/net/websockets/websocket_stream_test.cc index 5ce3331..801e84e 100644 --- a/net/websockets/websocket_stream_test.cc +++ b/net/websockets/websocket_stream_test.cc @@ -408,7 +408,7 @@ class WebSocketStreamCreateUMATest : public ::testing::Test { }; class StreamCreation : public WebSocketStreamCreateTest { - virtual void TestBody() override {} + void TestBody() override {} }; scoped_ptr<base::HistogramSamples> GetSamples(const std::string& name) { |