diff options
author | darin@chromium.org <darin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-12 06:20:58 +0000 |
---|---|---|
committer | darin@chromium.org <darin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-12 06:20:58 +0000 |
commit | 2727ca3555a20f982d136f1106a13b16de3c85d8 (patch) | |
tree | d9754af751def8007ad7df10703eeb3f4dada305 /net | |
parent | 8c797ef2f80f6280ab35ecedbc9dc4a1e4a2bfa2 (diff) | |
download | chromium_src-2727ca3555a20f982d136f1106a13b16de3c85d8.zip chromium_src-2727ca3555a20f982d136f1106a13b16de3c85d8.tar.gz chromium_src-2727ca3555a20f982d136f1106a13b16de3c85d8.tar.bz2 |
Rebaseline block-test* tests for Mac.
On Mac, when trying to connect to 255.255.255.255, we get an EACCES error. I
don't think it is correct for me to map that to ERR_ADDRESS_INVALID or
ERR_ADDRESS_UNREACHABLE, so I'm going to map it to ERR_ACCESS_DENIED. This
means that I need to rebaseline the chromium-mac results for these tests.
I think it is okay to have platform specific behavior here. I kind of prefer
that the error codes we show are more closely in sync with the operating
system. That way it may be easier for a sophisticated user to make sense of
our error codes.
R=wtc
BUG=18665
TEST=none
Review URL: http://codereview.chromium.org/164114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23176 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net')
-rw-r--r-- | net/socket/tcp_client_socket_libevent.cc | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/net/socket/tcp_client_socket_libevent.cc b/net/socket/tcp_client_socket_libevent.cc index c03473a..f417f80 100644 --- a/net/socket/tcp_client_socket_libevent.cc +++ b/net/socket/tcp_client_socket_libevent.cc @@ -43,6 +43,8 @@ int MapPosixError(int err) { case EWOULDBLOCK: #endif return ERR_IO_PENDING; + case EACCES: + return ERR_ACCESS_DENIED; case ENETDOWN: return ERR_INTERNET_DISCONNECTED; case ETIMEDOUT: |