diff options
| author | vandebo@chromium.org <vandebo@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-11 17:45:05 +0000 |
|---|---|---|
| committer | vandebo@chromium.org <vandebo@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-11 17:45:05 +0000 |
| commit | 417da1012059802341c47aa117c3d4ac402e5648 (patch) | |
| tree | cd19edb53307c94f501e0faac1c80a7243c3f126 /net | |
| parent | 3417cb70b33a94675796a9dd61a6ffe87c536be5 (diff) | |
| download | chromium_src-417da1012059802341c47aa117c3d4ac402e5648.zip chromium_src-417da1012059802341c47aa117c3d4ac402e5648.tar.gz chromium_src-417da1012059802341c47aa117c3d4ac402e5648.tar.bz2 | |
Coverity: Fix unnecessary call by values.
CID 13152, 14252
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/6665016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77826 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net')
| -rw-r--r-- | net/socket/client_socket_pool_base.cc | 2 | ||||
| -rw-r--r-- | net/socket/client_socket_pool_base.h | 2 | ||||
| -rw-r--r-- | net/url_request/url_request_redirect_job.cc | 2 | ||||
| -rw-r--r-- | net/url_request/url_request_redirect_job.h | 2 |
4 files changed, 4 insertions, 4 deletions
diff --git a/net/socket/client_socket_pool_base.cc b/net/socket/client_socket_pool_base.cc index b24b403..6d5e410 100644 --- a/net/socket/client_socket_pool_base.cc +++ b/net/socket/client_socket_pool_base.cc @@ -194,7 +194,7 @@ void ClientSocketPoolBaseHelper::InsertRequestIntoQueue( // static const ClientSocketPoolBaseHelper::Request* ClientSocketPoolBaseHelper::RemoveRequestFromQueue( - RequestQueue::iterator it, Group* group) { + const RequestQueue::iterator& it, Group* group) { const Request* req = *it; group->mutable_pending_requests()->erase(it); // If there are no more requests, we kill the backup timer. diff --git a/net/socket/client_socket_pool_base.h b/net/socket/client_socket_pool_base.h index 1047821..8fcb571 100644 --- a/net/socket/client_socket_pool_base.h +++ b/net/socket/client_socket_pool_base.h @@ -409,7 +409,7 @@ class ClientSocketPoolBaseHelper static void InsertRequestIntoQueue(const Request* r, RequestQueue* pending_requests); - static const Request* RemoveRequestFromQueue(RequestQueue::iterator it, + static const Request* RemoveRequestFromQueue(const RequestQueue::iterator& it, Group* group); Group* GetOrCreateGroup(const std::string& group_name); diff --git a/net/url_request/url_request_redirect_job.cc b/net/url_request/url_request_redirect_job.cc index 9c5605a..9a7350e 100644 --- a/net/url_request/url_request_redirect_job.cc +++ b/net/url_request/url_request_redirect_job.cc @@ -9,7 +9,7 @@ namespace net { URLRequestRedirectJob::URLRequestRedirectJob(URLRequest* request, - GURL redirect_destination) + const GURL& redirect_destination) : URLRequestJob(request), redirect_destination_(redirect_destination) { } diff --git a/net/url_request/url_request_redirect_job.h b/net/url_request/url_request_redirect_job.h index 425c70b..fab7973 100644 --- a/net/url_request/url_request_redirect_job.h +++ b/net/url_request/url_request_redirect_job.h @@ -18,7 +18,7 @@ namespace net { class URLRequestRedirectJob : public URLRequestJob { public: // Constructs a job that redirects to the specified URL. - URLRequestRedirectJob(URLRequest* request, GURL redirect_destination); + URLRequestRedirectJob(URLRequest* request, const GURL& redirect_destination); virtual void Start(); virtual bool IsRedirectResponse(GURL* location, int* http_status_code); |