diff options
| author | darin@google.com <darin@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-09-29 23:21:30 +0000 |
|---|---|---|
| committer | darin@google.com <darin@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-09-29 23:21:30 +0000 |
| commit | 7be5131b5e012054c7a162a95f3b3cc0793c5e34 (patch) | |
| tree | 4b8d0f99ff700142113cc0d9beaaf80f5eee431e /net | |
| parent | 05f9b688e319fcb092be0e06f7b72d39dd3113b3 (diff) | |
| download | chromium_src-7be5131b5e012054c7a162a95f3b3cc0793c5e34.zip chromium_src-7be5131b5e012054c7a162a95f3b3cc0793c5e34.tar.gz chromium_src-7be5131b5e012054c7a162a95f3b3cc0793c5e34.tar.bz2 | |
Add comments to explain the ERR_NAME_NOT_RESOLVED case.
TBR=wtc
Review URL: http://codereview.chromium.org/4343
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2701 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net')
| -rw-r--r-- | net/http/http_network_transaction.cc | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/net/http/http_network_transaction.cc b/net/http/http_network_transaction.cc index 6bca966..796eec9 100644 --- a/net/http/http_network_transaction.cc +++ b/net/http/http_network_transaction.cc @@ -931,6 +931,12 @@ int HttpNetworkTransaction::ReconsiderProxyAfterError(int error) { // A failure to resolve the hostname or any error related to establishing a // TCP connection could be grounds for trying a new proxy configuration. + // + // Why do this when a hostname cannot be resolved? Some URLs only make sense + // to proxy servers. The hostname in those URLs might fail to resolve if we + // are still using a non-proxy config. We need to check if a proxy config + // now exists that corresponds to a proxy server that could load the URL. + // switch (error) { case ERR_NAME_NOT_RESOLVED: case ERR_INTERNET_DISCONNECTED: |