summaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorjochen@chromium.org <jochen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-02-23 08:31:14 +0000
committerjochen@chromium.org <jochen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-02-23 08:31:14 +0000
commit8202d0cda0660d43f699160179df6c95058ab928 (patch)
tree0025c388d8e833fb1462eb84f94e63d38d1e353b /net
parent1a3b42b3b153860e59831e71d59cecaf36a2454e (diff)
downloadchromium_src-8202d0cda0660d43f699160179df6c95058ab928.zip
chromium_src-8202d0cda0660d43f699160179df6c95058ab928.tar.gz
chromium_src-8202d0cda0660d43f699160179df6c95058ab928.tar.bz2
Send fatal proxy errors to the network delegate.
BUG=60099 TEST=browser test Review URL: http://codereview.chromium.org/6541021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75726 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net')
-rw-r--r--net/http/http_network_delegate.h8
-rw-r--r--net/url_request/url_request.cc7
-rw-r--r--net/url_request/url_request_job.cc12
-rw-r--r--net/url_request/url_request_test_util.cc37
-rw-r--r--net/url_request/url_request_test_util.h24
-rw-r--r--net/url_request/url_request_unittest.cc60
6 files changed, 145 insertions, 3 deletions
diff --git a/net/http/http_network_delegate.h b/net/http/http_network_delegate.h
index 1533bc3..9a9300b 100644
--- a/net/http/http_network_delegate.h
+++ b/net/http/http_network_delegate.h
@@ -14,12 +14,18 @@ class URLRequest;
class HttpNetworkDelegate {
public:
// Called before a request is sent.
- virtual void OnBeforeURLRequest(net::URLRequest* request) = 0;
+ virtual void OnBeforeURLRequest(URLRequest* request) = 0;
// Called right before the HTTP headers are sent. Allows the delegate to
// read/write |headers| before they get sent out.
virtual void OnSendHttpRequest(HttpRequestHeaders* headers) = 0;
+ // This corresponds to URLRequestDelegate::OnResponseStarted.
+ virtual void OnResponseStarted(URLRequest* request) = 0;
+
+ // This corresponds to URLRequestDelegate::OnReadCompleted.
+ virtual void OnReadCompleted(URLRequest* request, int bytes_read) = 0;
+
protected:
virtual ~HttpNetworkDelegate() {}
};
diff --git a/net/url_request/url_request.cc b/net/url_request/url_request.cc
index 848b810..ca8aacb 100644
--- a/net/url_request/url_request.cc
+++ b/net/url_request/url_request.cc
@@ -492,8 +492,11 @@ void URLRequest::ResponseStarted() {
URLRequestJobManager::GetInstance()->MaybeInterceptResponse(this);
if (job) {
RestartWithJob(job);
- } else if (delegate_) {
- delegate_->OnResponseStarted(this);
+ } else {
+ if (context_ && context_->network_delegate())
+ context_->network_delegate()->OnResponseStarted(this);
+ if (delegate_)
+ delegate_->OnResponseStarted(this);
}
}
diff --git a/net/url_request/url_request_job.cc b/net/url_request/url_request_job.cc
index 12c8d2e..2aede15 100644
--- a/net/url_request/url_request_job.cc
+++ b/net/url_request/url_request_job.cc
@@ -14,8 +14,10 @@
#include "net/base/load_flags.h"
#include "net/base/mime_util.h"
#include "net/base/net_errors.h"
+#include "net/http/http_network_delegate.h"
#include "net/http/http_response_headers.h"
#include "net/url_request/url_request.h"
+#include "net/url_request/url_request_context.h"
#include "net/url_request/url_request_job_metrics.h"
#include "net/url_request/url_request_job_tracker.h"
@@ -535,10 +537,18 @@ void URLRequestJob::NotifyReadComplete(int bytes_read) {
int filter_bytes_read = 0;
if (ReadFilteredData(&filter_bytes_read)) {
postfilter_bytes_read_ += filter_bytes_read;
+ if (request_->context() && request_->context()->network_delegate()) {
+ request_->context()->network_delegate()->OnReadCompleted(
+ request_, filter_bytes_read);
+ }
request_->delegate()->OnReadCompleted(request_, filter_bytes_read);
}
} else {
postfilter_bytes_read_ += bytes_read;
+ if (request_->context() && request_->context()->network_delegate()) {
+ request_->context()->network_delegate()->OnReadCompleted(
+ request_, bytes_read);
+ }
request_->delegate()->OnReadCompleted(request_, bytes_read);
}
}
@@ -610,6 +620,8 @@ void URLRequestJob::CompleteNotifyDone() {
// OnResponseStarted yet.
if (has_handled_response_) {
// We signal the error by calling OnReadComplete with a bytes_read of -1.
+ if (request_->context() && request_->context()->network_delegate())
+ request_->context()->network_delegate()->OnReadCompleted(request_, -1);
request_->delegate()->OnReadCompleted(request_, -1);
} else {
has_handled_response_ = true;
diff --git a/net/url_request/url_request_test_util.cc b/net/url_request/url_request_test_util.cc
index b20cfc7..0302ce5 100644
--- a/net/url_request/url_request_test_util.cc
+++ b/net/url_request/url_request_test_util.cc
@@ -96,6 +96,15 @@ TestURLRequestContext::TestURLRequestContext(const std::string& proxy) {
Init();
}
+TestURLRequestContext::TestURLRequestContext(const std::string& proxy,
+ net::HostResolver* host_resolver) {
+ set_host_resolver(host_resolver);
+ net::ProxyConfig proxy_config;
+ proxy_config.proxy_rules().ParseFromString(proxy);
+ set_proxy_service(net::ProxyService::CreateFixed(proxy_config));
+ Init();
+}
+
TestURLRequestContext::~TestURLRequestContext() {
delete ftp_transaction_factory();
delete http_transaction_factory();
@@ -278,3 +287,31 @@ void TestDelegate::OnResponseCompleted(net::URLRequest* request) {
if (quit_on_complete_)
MessageLoop::current()->PostTask(FROM_HERE, new MessageLoop::QuitTask());
}
+
+TestHttpNetworkDelegate::TestHttpNetworkDelegate()
+ : last_os_error_(0),
+ error_count_(0) {
+}
+
+TestHttpNetworkDelegate::~TestHttpNetworkDelegate() {}
+
+void TestHttpNetworkDelegate::OnBeforeURLRequest(net::URLRequest* request) {
+}
+
+void TestHttpNetworkDelegate::OnSendHttpRequest(
+ net::HttpRequestHeaders* headers) {
+}
+
+void TestHttpNetworkDelegate::OnResponseStarted(net::URLRequest* request) {
+ if (request->status().status() == net::URLRequestStatus::FAILED) {
+ error_count_++;
+ last_os_error_ = request->status().os_error();
+ }
+}
+void TestHttpNetworkDelegate::OnReadCompleted(net::URLRequest* request,
+ int bytes_read) {
+ if (request->status().status() == net::URLRequestStatus::FAILED) {
+ error_count_++;
+ last_os_error_ = request->status().os_error();
+ }
+}
diff --git a/net/url_request/url_request_test_util.h b/net/url_request/url_request_test_util.h
index 3f8b4b4..1b75205 100644
--- a/net/url_request/url_request_test_util.h
+++ b/net/url_request/url_request_test_util.h
@@ -28,6 +28,7 @@
#include "net/ftp/ftp_network_layer.h"
#include "net/http/http_auth_handler_factory.h"
#include "net/http/http_cache.h"
+#include "net/http/http_network_delegate.h"
#include "net/http/http_network_layer.h"
#include "net/test/test_server.h"
#include "net/url_request/url_request.h"
@@ -75,6 +76,8 @@ class TestURLRequestContext : public net::URLRequestContext {
public:
TestURLRequestContext();
explicit TestURLRequestContext(const std::string& proxy);
+ TestURLRequestContext(const std::string& proxy,
+ net::HostResolver* host_resolver);
protected:
virtual ~TestURLRequestContext();
@@ -183,4 +186,25 @@ class TestDelegate : public net::URLRequest::Delegate {
scoped_refptr<net::IOBuffer> buf_;
};
+//-----------------------------------------------------------------------------
+
+class TestHttpNetworkDelegate : public net::HttpNetworkDelegate {
+ public:
+ TestHttpNetworkDelegate();
+ virtual ~TestHttpNetworkDelegate();
+
+ // net::HttpNetworkDelegate:
+ virtual void OnBeforeURLRequest(net::URLRequest* request);
+ virtual void OnSendHttpRequest(net::HttpRequestHeaders* headers);
+ virtual void OnResponseStarted(net::URLRequest* request);
+ virtual void OnReadCompleted(net::URLRequest* request, int bytes_read);
+
+ int last_os_error() const { return last_os_error_; }
+ int error_count() const { return error_count_; }
+
+ private:
+ int last_os_error_;
+ int error_count_;
+};
+
#endif // NET_URL_REQUEST_URL_REQUEST_TEST_UTIL_H_
diff --git a/net/url_request/url_request_unittest.cc b/net/url_request/url_request_unittest.cc
index 3192b39..c3b8e37 100644
--- a/net/url_request/url_request_unittest.cc
+++ b/net/url_request/url_request_unittest.cc
@@ -27,6 +27,7 @@
#include "net/base/cookie_monster.h"
#include "net/base/cookie_policy.h"
#include "net/base/load_flags.h"
+#include "net/base/mock_host_resolver.h"
#include "net/base/net_errors.h"
#include "net/base/net_log.h"
#include "net/base/net_log_unittest.h"
@@ -230,6 +231,37 @@ TEST_F(URLRequestTestHTTP, ProxyTunnelRedirectTest) {
}
}
+// This is the same as the previous test, but checks that the network delegate
+// registers the error.
+TEST_F(URLRequestTestHTTP, NetworkDelegateTunnelConnectionFailed) {
+ ASSERT_TRUE(test_server_.Start());
+
+ TestDelegate d;
+ {
+ net::URLRequest r(GURL("https://www.redirect.com/"), &d);
+ scoped_refptr<TestURLRequestContext> context(
+ new TestURLRequestContext(test_server_.host_port_pair().ToString()));
+ TestHttpNetworkDelegate network_delegate;
+ context->set_network_delegate(&network_delegate);
+ r.set_context(context);
+
+ r.Start();
+ EXPECT_TRUE(r.is_pending());
+
+ MessageLoop::current()->Run();
+
+ EXPECT_EQ(net::URLRequestStatus::FAILED, r.status().status());
+ EXPECT_EQ(net::ERR_TUNNEL_CONNECTION_FAILED, r.status().os_error());
+ EXPECT_EQ(1, d.response_started_count());
+ // We should not have followed the redirect.
+ EXPECT_EQ(0, d.received_redirect_count());
+
+ EXPECT_EQ(1, network_delegate.error_count());
+ EXPECT_EQ(net::ERR_TUNNEL_CONNECTION_FAILED,
+ network_delegate.last_os_error());
+ }
+}
+
// In this unit test, we're using the HTTPTestServer as a proxy server and
// issuing a CONNECT request with the magic host name "www.server-auth.com".
// The HTTPTestServer will return a 401 response, which we should balk at.
@@ -2366,6 +2398,34 @@ TEST_F(URLRequestTest, Identifiers) {
ASSERT_NE(req.identifier(), other_req.identifier());
}
+// Check that a failure to connect to the proxy is reported to the network
+// delegate.
+TEST_F(URLRequestTest, NetworkDelegateProxyError) {
+ TestDelegate d;
+ TestURLRequest req(GURL("http://example.com"), &d);
+ req.set_method("GET");
+
+ scoped_ptr<net::MockHostResolverBase> host_resolver(
+ new net::MockHostResolver);
+ host_resolver->rules()->AddSimulatedFailure("*");
+ scoped_refptr<TestURLRequestContext> context(
+ new TestURLRequestContext("myproxy:70", host_resolver.release()));
+ TestHttpNetworkDelegate network_delegate;
+ context->set_network_delegate(&network_delegate);
+ req.set_context(context);
+
+ req.Start();
+ MessageLoop::current()->Run();
+
+ // Check we see a failed request.
+ EXPECT_FALSE(req.status().is_success());
+ EXPECT_EQ(net::URLRequestStatus::FAILED, req.status().status());
+ EXPECT_EQ(net::ERR_PROXY_CONNECTION_FAILED, req.status().os_error());
+
+ EXPECT_EQ(1, network_delegate.error_count());
+ EXPECT_EQ(net::ERR_PROXY_CONNECTION_FAILED, network_delegate.last_os_error());
+}
+
class URLRequestTestFTP : public URLRequestTest {
public:
URLRequestTestFTP() : test_server_(net::TestServer::TYPE_FTP, FilePath()) {
generated by cgit v1.1 at 2025-03-03 12:17:11 +0000