diff options
| author | ziadh@chromium.org <ziadh@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-02 21:31:44 +0000 |
|---|---|---|
| committer | ziadh@chromium.org <ziadh@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-02 21:31:44 +0000 |
| commit | a764bf5e513ff576f538c34b9ece9df1570e999c (patch) | |
| tree | 44f5918c5015c1f86244aacf54c6ab90c03c358c /net | |
| parent | 79fed69d92dede3b92fd3a175b520ae6949f9233 (diff) | |
| download | chromium_src-a764bf5e513ff576f538c34b9ece9df1570e999c.zip chromium_src-a764bf5e513ff576f538c34b9ece9df1570e999c.tar.gz chromium_src-a764bf5e513ff576f538c34b9ece9df1570e999c.tar.bz2 | |
Refactored Histogram::FactoryGet() to be style-compliant
Currently, two (2) overloaded versions of Histogram::FactoryGet() exist. Google's C++ style guide discourages such implementations. I refactored the methods into Histogram::FactoryGet() (no name change), which takes 'Sample' types as arguments, and Histogram::FactoryTimeGet(), which takes base::TimeDelta types as arguments.
r = jar
Review URL: http://codereview.chromium.org/2423004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48766 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net')
| -rw-r--r-- | net/disk_cache/histogram_macros.h | 4 | ||||
| -rw-r--r-- | net/socket/client_socket_pool_histograms.cc | 6 |
2 files changed, 5 insertions, 5 deletions
diff --git a/net/disk_cache/histogram_macros.h b/net/disk_cache/histogram_macros.h index bbea303..361a9d6 100644 --- a/net/disk_cache/histogram_macros.h +++ b/net/disk_cache/histogram_macros.h @@ -36,8 +36,8 @@ do { \ static scoped_refptr<Histogram> counter; \ if (!counter || name != counter->histogram_name()) \ - counter = Histogram::FactoryGet(name, min, max, bucket_count, \ - Histogram::kUmaTargetedHistogramFlag); \ + counter = Histogram::FactoryTimeGet(name, min, max, bucket_count, \ + Histogram::kUmaTargetedHistogramFlag); \ counter->AddTime(sample); \ } while (0) diff --git a/net/socket/client_socket_pool_histograms.cc b/net/socket/client_socket_pool_histograms.cc index 769257b..e86543d 100644 --- a/net/socket/client_socket_pool_histograms.cc +++ b/net/socket/client_socket_pool_histograms.cc @@ -18,19 +18,19 @@ ClientSocketPoolHistograms::ClientSocketPoolHistograms( ClientSocketHandle::NUM_TYPES, ClientSocketHandle::NUM_TYPES + 1, Histogram::kUmaTargetedHistogramFlag); // UMA_HISTOGRAM_CUSTOM_TIMES - request_time_ = Histogram::FactoryGet( + request_time_ = Histogram::FactoryTimeGet( "Net.SocketRequestTime_" + pool_name, base::TimeDelta::FromMilliseconds(1), base::TimeDelta::FromMinutes(10), 100, Histogram::kUmaTargetedHistogramFlag); // UMA_HISTOGRAM_CUSTOM_TIMES - unused_idle_time_ = Histogram::FactoryGet( + unused_idle_time_ = Histogram::FactoryTimeGet( "Net.SocketIdleTimeBeforeNextUse_UnusedSocket_" + pool_name, base::TimeDelta::FromMilliseconds(1), base::TimeDelta::FromMinutes(6), 100, Histogram::kUmaTargetedHistogramFlag); // UMA_HISTOGRAM_CUSTOM_TIMES - reused_idle_time_ = Histogram::FactoryGet( + reused_idle_time_ = Histogram::FactoryTimeGet( "Net.SocketIdleTimeBeforeNextUse_ReusedSocket_" + pool_name, base::TimeDelta::FromMilliseconds(1), base::TimeDelta::FromMinutes(6), |