diff options
| author | wtc@chromium.org <wtc@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-02-11 00:03:27 +0000 |
|---|---|---|
| committer | wtc@chromium.org <wtc@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-02-11 00:03:27 +0000 |
| commit | f048412818da2d3742df4d9e3308e6876fb89b69 (patch) | |
| tree | 8314f2770c225f8e862e3c9663b3b309975c1425 /net | |
| parent | 9d99c66cf0356d25ed07cd9a509d6087765d597d (diff) | |
| download | chromium_src-f048412818da2d3742df4d9e3308e6876fb89b69.zip chromium_src-f048412818da2d3742df4d9e3308e6876fb89b69.tar.gz chromium_src-f048412818da2d3742df4d9e3308e6876fb89b69.tar.bz2 | |
Fix Coverity UNINIT_CTOR defect in the
DiskCacheBasedSSLHostInfo::CallbackImpl constructor.
Fix cpplint nits.
R=agl
CID=14184
BUG=none
TEST=No compilation errors.
Review URL: http://codereview.chromium.org/6474009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74527 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net')
| -rw-r--r-- | net/http/disk_cache_based_ssl_host_info.cc | 8 | ||||
| -rw-r--r-- | net/http/disk_cache_based_ssl_host_info.h | 10 |
2 files changed, 10 insertions, 8 deletions
diff --git a/net/http/disk_cache_based_ssl_host_info.cc b/net/http/disk_cache_based_ssl_host_info.cc index 15a77be..7021cfb 100644 --- a/net/http/disk_cache_based_ssl_host_info.cc +++ b/net/http/disk_cache_based_ssl_host_info.cc @@ -15,9 +15,11 @@ namespace net { DiskCacheBasedSSLHostInfo::CallbackImpl::CallbackImpl( const base::WeakPtr<DiskCacheBasedSSLHostInfo>& obj, - void (DiskCacheBasedSSLHostInfo::*meth) (int)) + void (DiskCacheBasedSSLHostInfo::*meth)(int)) : obj_(obj), - meth_(meth) { + meth_(meth), + backend_(NULL), + entry_(NULL) { } DiskCacheBasedSSLHostInfo::CallbackImpl::~CallbackImpl() {} @@ -266,4 +268,4 @@ bool DiskCacheBasedSSLHostInfo::IsCallbackPending() const { } } -} // namespace net +} // namespace net diff --git a/net/http/disk_cache_based_ssl_host_info.h b/net/http/disk_cache_based_ssl_host_info.h index 359397df..905a3a9 100644 --- a/net/http/disk_cache_based_ssl_host_info.h +++ b/net/http/disk_cache_based_ssl_host_info.h @@ -2,8 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#ifndef NET_HTTP_DISK_CACHE_BASED_SSL_HOST_INFO_H -#define NET_HTTP_DISK_CACHE_BASED_SSL_HOST_INFO_H +#ifndef NET_HTTP_DISK_CACHE_BASED_SSL_HOST_INFO_H_ +#define NET_HTTP_DISK_CACHE_BASED_SSL_HOST_INFO_H_ #include <string> @@ -56,7 +56,7 @@ class DiskCacheBasedSSLHostInfo : public SSLHostInfo, class CallbackImpl : public CallbackRunner<Tuple1<int> > { public: CallbackImpl(const base::WeakPtr<DiskCacheBasedSSLHostInfo>& obj, - void (DiskCacheBasedSSLHostInfo::*meth) (int)); + void (DiskCacheBasedSSLHostInfo::*meth)(int)); virtual ~CallbackImpl(); disk_cache::Backend** backend_pointer() { return &backend_; } @@ -69,7 +69,7 @@ class DiskCacheBasedSSLHostInfo : public SSLHostInfo, private: base::WeakPtr<DiskCacheBasedSSLHostInfo> obj_; - void (DiskCacheBasedSSLHostInfo::*meth_) (int); + void (DiskCacheBasedSSLHostInfo::*meth_)(int); disk_cache::Backend* backend_; disk_cache::Entry* entry_; @@ -119,4 +119,4 @@ class DiskCacheBasedSSLHostInfo : public SSLHostInfo, } // namespace net -#endif // NET_HTTP_DISK_CACHE_BASED_SSL_HOST_INFO_H +#endif // NET_HTTP_DISK_CACHE_BASED_SSL_HOST_INFO_H_ |