diff options
author | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-20 20:08:23 +0000 |
---|---|---|
committer | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-20 20:08:23 +0000 |
commit | f3b1afd587e13f4d67288806ed4f07fc8a14ed5f (patch) | |
tree | b5f2071627e5825bf3e12cb7284051cc33767e7a /net | |
parent | e52162ef0805fa045fb4e7be19d0ed49a0258173 (diff) | |
download | chromium_src-f3b1afd587e13f4d67288806ed4f07fc8a14ed5f.zip chromium_src-f3b1afd587e13f4d67288806ed4f07fc8a14ed5f.tar.gz chromium_src-f3b1afd587e13f4d67288806ed4f07fc8a14ed5f.tar.bz2 |
Remove <iostream> where possible.
<iostream> creates a static initializer. Most people don't need <iostream>
anyway--they really need <ostream> for operator<< overloads. <iostream>
should *never* be included in a header file; <iosfwd> exists for that purpose.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3014015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53083 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net')
-rw-r--r-- | net/base/x509_cert_types.cc | 2 | ||||
-rw-r--r-- | net/base/x509_cert_types.h | 2 | ||||
-rw-r--r-- | net/tools/flip_server/balsa_frame.cc | 1 | ||||
-rw-r--r-- | net/tools/flip_server/balsa_headers.cc | 6 | ||||
-rw-r--r-- | net/tools/flip_server/balsa_headers.h | 7 | ||||
-rw-r--r-- | net/tools/flip_server/create_listener.cc | 1 | ||||
-rw-r--r-- | net/tools/flip_server/create_listener.h | 2 |
7 files changed, 13 insertions, 8 deletions
diff --git a/net/base/x509_cert_types.cc b/net/base/x509_cert_types.cc index 8329216..8f7a2ae 100644 --- a/net/base/x509_cert_types.cc +++ b/net/base/x509_cert_types.cc @@ -4,6 +4,8 @@ #include "net/base/x509_cert_types.h" +#include <ostream> + #include "net/base/x509_certificate.h" #include "base/logging.h" diff --git a/net/base/x509_cert_types.h b/net/base/x509_cert_types.h index 0f5122e..ad3ea2d 100644 --- a/net/base/x509_cert_types.h +++ b/net/base/x509_cert_types.h @@ -8,7 +8,7 @@ #include <string.h> #include <functional> -#include <iostream> +#include <iosfwd> #include <map> #include <set> #include <string> diff --git a/net/tools/flip_server/balsa_frame.cc b/net/tools/flip_server/balsa_frame.cc index 90631ce..9b8173e 100644 --- a/net/tools/flip_server/balsa_frame.cc +++ b/net/tools/flip_server/balsa_frame.cc @@ -9,7 +9,6 @@ #include <strings.h> #include <limits> -#include <iostream> #include <string> #include <utility> #include <vector> diff --git a/net/tools/flip_server/balsa_headers.cc b/net/tools/flip_server/balsa_headers.cc index 56a83a2..b58fb03 100644 --- a/net/tools/flip_server/balsa_headers.cc +++ b/net/tools/flip_server/balsa_headers.cc @@ -71,6 +71,12 @@ namespace net { const size_t BalsaBuffer::kDefaultBlocksize; +std::ostream& BalsaHeaders::iterator_base::operator<<(std::ostream& os, + const iterator_base& it) { + os << "[" << it.headers_ << ", " << it.idx_ << "]"; + return os; + } + void BalsaHeaders::Clear() { balsa_buffer_.Clear(); transfer_encoding_is_chunked_ = false; diff --git a/net/tools/flip_server/balsa_headers.h b/net/tools/flip_server/balsa_headers.h index 4f530c7..24e7940 100644 --- a/net/tools/flip_server/balsa_headers.h +++ b/net/tools/flip_server/balsa_headers.h @@ -6,7 +6,7 @@ #define NET_TOOLS_FLIP_SERVER_BALSA_HEADERS_H_ #include <algorithm> -#include <iostream> +#include <iosfwd> #include <iterator> #include <string> #include <utility> @@ -470,10 +470,7 @@ class BalsaHeaders { // operator<< work for the classes it sees. It would be better if there // was an additional traits-like system for the gUnit output... but oh // well. - friend std::ostream& operator<<(std::ostream& os, const iterator_base& it) { - os << "[" << it.headers_ << ", " << it.idx_ << "]"; - return os; - } + std::ostream& operator<<(std::ostream& os, const iterator_base& it); protected: iterator_base(const BalsaHeaders* headers, HeaderLines::size_type index) : diff --git a/net/tools/flip_server/create_listener.cc b/net/tools/flip_server/create_listener.cc index 7ea5efa..3538261 100644 --- a/net/tools/flip_server/create_listener.cc +++ b/net/tools/flip_server/create_listener.cc @@ -10,6 +10,7 @@ #include <sys/socket.h> // for getaddrinfo and getnameinfo #include <sys/types.h> // " #include <unistd.h> // for exit() +#include <ostream> #include "net/tools/flip_server/create_listener.h" diff --git a/net/tools/flip_server/create_listener.h b/net/tools/flip_server/create_listener.h index 06979d9..32758ee 100644 --- a/net/tools/flip_server/create_listener.h +++ b/net/tools/flip_server/create_listener.h @@ -5,7 +5,7 @@ #ifndef NET_TOOLS_FLIP_SERVER_CREATE_LISTENER_H__ #define NET_TOOLS_FLIP_SERVER_CREATE_LISTENER_H__ -#include <iostream> +#include <iosfwd> #include <string> namespace net { |