diff options
| author | wtc@google.com <wtc@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-09-11 17:03:45 +0000 |
|---|---|---|
| committer | wtc@google.com <wtc@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-09-11 17:03:45 +0000 |
| commit | 37312d701f670b52f796b217adc8726a2a0fa52a (patch) | |
| tree | 3dfdbe9193226dcff3a12e0b7bb4aa7d9332cd80 /net | |
| parent | b75c5d19084dfa4cafb6fdb6ffd715bca09e9123 (diff) | |
| download | chromium_src-37312d701f670b52f796b217adc8726a2a0fa52a.zip chromium_src-37312d701f670b52f796b217adc8726a2a0fa52a.tar.gz chromium_src-37312d701f670b52f796b217adc8726a2a0fa52a.tar.bz2 | |
Remove all but one place in this file where we return
ERR_FAILED.
In the remaining place, log the original Win32 error
code to help diagnose a failure in the field.
R=darin
Review URL: http://codereview.chromium.org/1927
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2066 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net')
| -rw-r--r-- | net/base/tcp_client_socket.cc | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/net/base/tcp_client_socket.cc b/net/base/tcp_client_socket.cc index fc65995..d766503 100644 --- a/net/base/tcp_client_socket.cc +++ b/net/base/tcp_client_socket.cc @@ -45,6 +45,7 @@ static int MapWinsockError(DWORD err) { case ERROR_SUCCESS: return OK; default: + LOG(WARNING) << "Unknown error " << err << " mapped to net::ERR_FAILED"; return ERR_FAILED; } } @@ -102,7 +103,7 @@ int TCPClientSocket::Connect(CompletionCallback* callback) { int TCPClientSocket::ReconnectIgnoringLastError(CompletionCallback* callback) { // No ignorable errors! - return ERR_FAILED; + return ERR_UNEXPECTED; } void TCPClientSocket::Disconnect() { @@ -258,7 +259,7 @@ void TCPClientSocket::DidCompleteConnect() { } } else { NOTREACHED(); - result = ERR_FAILED; + result = ERR_UNEXPECTED; } if (result != ERR_IO_PENDING) |