diff options
| author | bradnelson@google.com <bradnelson@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-30 18:13:03 +0000 |
|---|---|---|
| committer | bradnelson@google.com <bradnelson@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-30 18:13:03 +0000 |
| commit | adeedaff76d28c2dd2c75bd399dbae21c415d037 (patch) | |
| tree | f9d4666fc0b9a38ffc280e3dad387f4f42ab2ba7 /o3d/command_buffer/service/cross/cmd_parser.cc | |
| parent | ee7c5cea02327013f7d00cb022788b9e8c14419b (diff) | |
| download | chromium_src-adeedaff76d28c2dd2c75bd399dbae21c415d037.zip chromium_src-adeedaff76d28c2dd2c75bd399dbae21c415d037.tar.gz chromium_src-adeedaff76d28c2dd2c75bd399dbae21c415d037.tar.bz2 | |
This fixes the Linux GYP build, fixing a number of (ahem!) problems
in command buffer code. Watch those signed/unsigned comparisons!
Also, introduced an "invalid" value for CommandBufferOffset
(INVALID_COMMAND_BUFFER_OFFSET) instead of using -1, since it's an
unsigned value.
Review URL: http://codereview.chromium.org/246038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27635 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'o3d/command_buffer/service/cross/cmd_parser.cc')
| -rw-r--r-- | o3d/command_buffer/service/cross/cmd_parser.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/o3d/command_buffer/service/cross/cmd_parser.cc b/o3d/command_buffer/service/cross/cmd_parser.cc index 843d0b8..ffe1d09 100644 --- a/o3d/command_buffer/service/cross/cmd_parser.cc +++ b/o3d/command_buffer/service/cross/cmd_parser.cc @@ -49,7 +49,7 @@ CommandParser::CommandParser(void *shm_address, // check proper alignments. DCHECK_EQ(0, (reinterpret_cast<intptr_t>(shm_address)) % 4); DCHECK_EQ(0, offset % 4); - DCHECK_EQ(0, size % 4); + DCHECK_EQ(0u, size % 4); // check that the command buffer fits into the memory buffer. DCHECK_GE(shm_size, offset + size); char * buffer_begin = static_cast<char *>(shm_address) + offset; |