summaryrefslogtreecommitdiffstats
path: root/o3d/command_buffer/service/cross/mocks.h
diff options
context:
space:
mode:
authorbradnelson@google.com <bradnelson@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2009-09-30 18:13:03 +0000
committerbradnelson@google.com <bradnelson@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2009-09-30 18:13:03 +0000
commitadeedaff76d28c2dd2c75bd399dbae21c415d037 (patch)
treef9d4666fc0b9a38ffc280e3dad387f4f42ab2ba7 /o3d/command_buffer/service/cross/mocks.h
parentee7c5cea02327013f7d00cb022788b9e8c14419b (diff)
downloadchromium_src-adeedaff76d28c2dd2c75bd399dbae21c415d037.zip
chromium_src-adeedaff76d28c2dd2c75bd399dbae21c415d037.tar.gz
chromium_src-adeedaff76d28c2dd2c75bd399dbae21c415d037.tar.bz2
This fixes the Linux GYP build, fixing a number of (ahem!) problems
in command buffer code. Watch those signed/unsigned comparisons! Also, introduced an "invalid" value for CommandBufferOffset (INVALID_COMMAND_BUFFER_OFFSET) instead of using -1, since it's an unsigned value. Review URL: http://codereview.chromium.org/246038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27635 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'o3d/command_buffer/service/cross/mocks.h')
-rw-r--r--o3d/command_buffer/service/cross/mocks.h5
1 files changed, 3 insertions, 2 deletions
diff --git a/o3d/command_buffer/service/cross/mocks.h b/o3d/command_buffer/service/cross/mocks.h
index dbd4c62..3135249 100644
--- a/o3d/command_buffer/service/cross/mocks.h
+++ b/o3d/command_buffer/service/cross/mocks.h
@@ -90,8 +90,8 @@ class AsyncAPIMock : public AsyncAPIInterface {
unsigned int arg_count,
const void* _args) {
DCHECK(engine_);
- DCHECK_EQ(1, command);
- DCHECK_EQ(1, arg_count);
+ DCHECK_EQ(1u, command);
+ DCHECK_EQ(1u, arg_count);
const CommandBufferEntry* args =
static_cast<const CommandBufferEntry*>(_args);
engine_->set_token(args[0].value_uint32);
@@ -133,6 +133,7 @@ class RPCProcessMock : public RPCProcessInterface {
bool AddMessage() {
++message_count_;
+ return true;
}
bool would_have_blocked() { return would_have_blocked_; }